From: Alexey Budankov <alexey.budankov@linux.intel.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Andi Kleen <ak@linux.intel.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v12 05/15] perf evlist: implement control command handling functions
Date: Wed, 22 Jul 2020 15:45:43 +0300 [thread overview]
Message-ID: <cc1e7d3d-32ad-693f-6db6-4573ad49cb20@linux.intel.com> (raw)
In-Reply-To: <20200722123423.GK77866@kernel.org>
On 22.07.2020 15:34, Arnaldo Carvalho de Melo wrote:
> Em Wed, Jul 22, 2020 at 09:27:34AM -0300, Arnaldo Carvalho de Melo escreveu:
>> Em Fri, Jul 17, 2020 at 10:01:33AM +0300, Alexey Budankov escreveu:
>>>
>>> Implement functions of initialization, finalization and processing
>>> of control command messages coming from control file descriptors.
>>> Allocate control file descriptor as descriptor at struct pollfd
>>> object of evsel_list for atomic poll() operation.
>>>
>>> Signed-off-by: Alexey Budankov <alexey.budankov@linux.intel.com>
>>> Acked-by: Jiri Olsa <jolsa@redhat.com>
>>> Acked-by: Namhyung Kim <namhyung@kernel.org>
>>
>> I'm applying locally for testing, but can you answer what is the reason
>> for that newline in the CMD_ACK_TAG? I tried looking at previous
>> discussion but couldn't quickly find any reasoning for that
>>
>> - Arnaldo
>>
>>> +++ b/tools/perf/util/evlist.h
>>> @@ -359,4 +359,22 @@ void perf_evlist__force_leader(struct evlist *evlist);
>>> struct evsel *perf_evlist__reset_weak_group(struct evlist *evlist,
>>> struct evsel *evsel,
>>> bool close);
>>> +#define EVLIST_CTL_CMD_ENABLE_TAG "enable"
>>> +#define EVLIST_CTL_CMD_DISABLE_TAG "disable"
>>> +#define EVLIST_CTL_CMD_ACK_TAG "ack\n"
>>
>> What for? That '\n'?
>
> Oh, I see, this is not a _command_, it is a _response_, and the sender
> expects a newline, right?
Right. Shell commands can expect strings terminated by \n, e.g. 'read -u'.
See sample bash script in 00/15 for example.
>
> So I think this needs to be marked clearly as:
>
> // Commands accepted by 'perf record'
>
> #define EVLIST_CTL_CMD_ENABLE_TAG "enable"
> #define EVLIST_CTL_CMD_DISABLE_TAG "disable"
>
>
> // Responses sent by 'perf record'
>
> #define EVLIST_CTL_RSP_ACK "ack"
>
> And then make the response add the newline, as conceivably we could have
> something like "nack", "invalid", "enoperm", etc, no?
That above makes sense.
>
> Anyway, this can be done on top of this series, so I'm continuing
> processing it locally.
>
> - Arnaldo
>
Alexei
next prev parent reply other threads:[~2020-07-22 12:45 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-17 6:45 [PATCH v12 00/15] perf: support enable and disable commands in stat and record modes Alexey Budankov
2020-07-17 6:59 ` [PATCH v12 01/15] tools/libperf: avoid internal moving of fdarray fds Alexey Budankov
2020-07-21 12:40 ` Arnaldo Carvalho de Melo
2020-07-17 6:59 ` [PATCH v12 02/15] tools/libperf: add flags to fdarray fds objects Alexey Budankov
2020-07-21 12:53 ` Arnaldo Carvalho de Melo
2020-07-17 7:00 ` [PATCH v12 03/15] tools/libperf: avoid counting of nonfilterable fdarray fds Alexey Budankov
2020-07-21 19:59 ` Arnaldo Carvalho de Melo
2020-07-17 7:00 ` [PATCH v12 04/15] perf evlist: introduce control file descriptors Alexey Budankov
2020-07-17 7:01 ` [PATCH v12 05/15] perf evlist: implement control command handling functions Alexey Budankov
2020-07-22 12:27 ` Arnaldo Carvalho de Melo
2020-07-22 12:34 ` Arnaldo Carvalho de Melo
2020-07-22 12:45 ` Alexey Budankov [this message]
2020-07-22 12:41 ` Arnaldo Carvalho de Melo
2020-07-17 7:02 ` [PATCH v12 06/15] perf stat: factor out body of event handling loop for system wide Alexey Budankov
2020-07-17 7:02 ` [PATCH v12 07/15] perf stat: move target check to loop control statement Alexey Budankov
2020-07-17 7:03 ` [PATCH v12 08/15] perf stat: factor out body of event handling loop for fork case Alexey Budankov
2020-07-17 7:04 ` [PATCH v12 09/15] perf stat: factor out event handling loop into dispatch_events() Alexey Budankov
2020-07-17 7:04 ` [PATCH v12 10/15] perf stat: extend -D,--delay option with -1 value Alexey Budankov
2020-07-17 7:05 ` [PATCH v12 11/15] perf stat: implement control commands handling Alexey Budankov
2020-07-22 12:56 ` Arnaldo Carvalho de Melo
2020-07-22 13:18 ` Alexey Budankov
2020-07-17 7:05 ` [PATCH v12 12/15] perf stat: introduce --control fd:ctl-fd[,ack-fd] options Alexey Budankov
2020-07-17 7:07 ` [PATCH v12 13/15] perf record: extend -D,--delay option with -1 value Alexey Budankov
2020-07-17 7:07 ` [PATCH v12 14/15] perf record: implement control commands handling Alexey Budankov
2020-07-17 7:08 ` [PATCH v12 15/15] perf record: introduce --control fd:ctl-fd[,ack-fd] options Alexey Budankov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc1e7d3d-32ad-693f-6db6-4573ad49cb20@linux.intel.com \
--to=alexey.budankov@linux.intel.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox