From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752547AbdLLRu7 (ORCPT ); Tue, 12 Dec 2017 12:50:59 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:55520 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752506AbdLLRuz (ORCPT ); Tue, 12 Dec 2017 12:50:55 -0500 Subject: Re: [PATCH] serial: forbid 8250 on s390 To: Alan Cox Cc: Greg Kroah-Hartman , Jiri Slaby , linux-serial@vger.kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org References: <20171212080835.23610-1-borntraeger@de.ibm.com> <20171212155032.2d5ece72@alans-desktop> From: Christian Borntraeger Date: Tue, 12 Dec 2017 18:50:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171212155032.2d5ece72@alans-desktop> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 17121217-0012-0000-0000-00000598472C X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17121217-0013-0000-0000-000019135CF4 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-12-12_10:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1712120255 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/12/2017 04:50 PM, Alan Cox wrote: > On Tue, 12 Dec 2017 09:08:35 +0100 > Christian Borntraeger wrote: > >> Using "make kvmconfig" results in a potentially unusable linux image >> on s390. The reason is that both the (default on s390) sclp consoles >> as well as the 8250 console register a ttyS as console. Since there >> will be no 8250 on s390 let's fence 8250. This will ensure that there >> is always a working sclp console. > > And there is no physical way to attach a PCI express UART to a 390 ? There is (some sort of) PCI but these cards are packaged in ibm specific I/O cages. So someone would need to apply some some serious hardware and firmware hacking (since only IBM-approved PCi cards are allowed) and you would need to have an MSI-capable 8250 as well as an MSI capable driver. (we only support MSI, no classic interrupts) In addition to that that 8250 probably needs to support virtual functions since we always run with LPARs. And even if we can solve all these issues I would say it really does not make any sense at all, while the current situation obviously breaks the use case "make kvmconfig" So unless IBM sees some serious business case for 8250, I am inclined to answer you question with "no" :-)