From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A5DF2E1C7A for ; Fri, 27 Jun 2025 16:10:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751040602; cv=none; b=ZPJHC4pXcMYQjMzxxGXFQNjRKfSWeyHiHwbn6Z3bqQdT0qSUlMqhxW6f85t/la7PyyVzKB71W50KgBbHNQBoxtNqeF+7t06tqsPYmFWtbhBKhK0f9xrNEzX1dPGdnuCQWfAoT3++VlhgpHb5uRbaX/ULm1qGwKSC+tnhbJnj2XM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751040602; c=relaxed/simple; bh=IH2+O5cU6bMl3dQgfqyetZYxS7jXnkdNLnvW+qxsQ88=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WTHkvq7uXjr0bZWdANqDE39zKlkOSiyzoKnTuwF3hzELjXIS/xxGK1UQSezJInHOb9BhAUxPMHGVLMXFvoBcsVMZAVRvp3klySPezvkCR/X2/nP8s6SG79MQZNeNJRtznFLUe2QDle49L1aWM4hK/L8RsymEsobuJvvm1k7orhk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=H4dCPw8k; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="H4dCPw8k" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-7494999de5cso1860997b3a.3 for ; Fri, 27 Jun 2025 09:10:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1751040600; x=1751645400; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=6tajG5R3MCsrP/w0wwPMIBf3LF9dc2Wm7Uf1cjFJKdc=; b=H4dCPw8kainQkV3U88q1ykgWUxcyaUhGqNx70wITre5B9Uqg0J5ACangeMO0rF8x6v I86lecQmRle0IXAfhBiPjb3MOiHCqYYTthU4m0LlPGixC1QoSv64F+UuBk7yeSTdgtsy 2VaZFR3XhvRA9jigy235+wgd3/xBOuEZOA5KE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751040600; x=1751645400; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6tajG5R3MCsrP/w0wwPMIBf3LF9dc2Wm7Uf1cjFJKdc=; b=i58vjhW/e69T63kiVUPTdLahbUMlPPmljsvtk+RzJw74laVAEa6s852Jh8ikJIqLi7 Wcn2BT69pUdFFy0aySw1f8rOtAqh+RI9E0K1qGqbm8ufHnTUK/Rk/PSSSCMV48jzVjyn f1aMA9c7EZl2+RMKtgTb3zyvl3azTSXdNvZWlHM1F1c4KXhSCvyUJOCNG787MNgY6Eq6 p2y2j8qhZgQqjqTvROdZM+wcmkt5NgWgL4vBDmPRAr8/vopHL+whYBvludk7BhmITWG7 Jvnxkl/xoxXIGimyvi483hB/7Hg+o3LAzopwpIiBUoZMIwtKiFnUuy1JnW7LCENzs0Ru EiFw== X-Forwarded-Encrypted: i=1; AJvYcCWkv00HtI0hWvppT0KvIXL56lmegGm1ydiWCTEKGz+3GKxYlLj+2kcir+9mEd8gwDrH6Al101q5n2ugMNo=@vger.kernel.org X-Gm-Message-State: AOJu0Yz5I+VbRgTNDlpDWLlSPHQGrFU2GYpmPhzMXZJZWWy5YgpGnkmn tLWou5AMpw6M6CKnyvOchKXKtp2GmEayGPM1X/ndvwXRqQ3zRmnNAhzMtoMYa2HSTQ== X-Gm-Gg: ASbGncs4bEiE7mZCTgtSEhku1pNFJNAuIAOHLo17FasdF6FtqynAUeqNVwvMOPXWtn6 lBQgVzRMEEeYktgN3362GVi9hgi2frm6oUoKaXJfskeg2hb7nWbjaj45h4VtoTtpOvhoTbt9Kga v9YVUvy0dq2Cv+XVmQ9zkXA2pNX6o5CsaANbEfRXc7YM72VrvIU9X20NOa3WbFhtI3UbHFqr5d8 8z3BW1HId2iipiWCTehYQyn8GkHFDAsljKuweKEQU2htrPn9v7FH9sbKp5boZO9PMsOwH9I6s/x JszuMlHScOHvQLEwOLt4eCCN9R8z1tQhxNqLvvIJx7IvZszGN1z+c3EGVUZpnGDPEQ599fS1SWT 4oe4ljjuPFFNeHI57Ns9YIiFYcg== X-Google-Smtp-Source: AGHT+IGphu6TPIxsadsg8AJvhSvpk9h0/WSLUUO4UG0XTFbdDPP5hlzrX20zsMC3uarGOiW78rocGg== X-Received: by 2002:a17:902:f709:b0:235:779:edea with SMTP id d9443c01a7336-23ac465d24fmr64232725ad.38.1751040599657; Fri, 27 Jun 2025 09:09:59 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23acb2e1b3esm18966805ad.35.2025.06.27.09.09.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Jun 2025 09:09:58 -0700 (PDT) Message-ID: Date: Fri, 27 Jun 2025 09:09:53 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 00/16] MAINTAINERS: Include GDB scripts under their relevant subsystems To: Jan Kara Cc: "Liam R. Howlett" , linux-kernel@vger.kernel.org, Jan Kiszka , Kieran Bingham , Michael Turquette , Stephen Boyd , Dennis Zhou , Tejun Heo , Christoph Lameter , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Petr Mladek , Steven Rostedt , John Ogness , Sergey Senozhatsky , Ulf Hansson , Thomas Gleixner , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Andrew Morton , Luis Chamberlain , Petr Pavlu , Sami Tolvanen , Daniel Gomez , Kent Overstreet , Anna-Maria Behnsen , Frederic Weisbecker , Alexander Viro , Christian Brauner , Uladzislau Rezki , Matthew Wilcox , Kuan-Ying Lee , Ilya Leoshkevich , Etienne Buira , Antonio Quartulli , Illia Ostapyshyn , "open list:COMMON CLK FRAMEWORK" , "open list:PER-CPU MEMORY ALLOCATOR" , "open list:GENERIC PM DOMAINS" , "open list:KASAN" , "open list:MAPLE TREE" , "open list:MODULE SUPPORT" , "open list:PROC FILESYSTEM" References: <20250625231053.1134589-1-florian.fainelli@broadcom.com> Content-Language: en-US From: Florian Fainelli Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 6/27/25 00:55, Jan Kara wrote: > On Thu 26-06-25 09:39:36, Florian Fainelli wrote: >> On 6/26/25 09:17, Liam R. Howlett wrote: >>> * Florian Fainelli [250625 19:13]: >>>> Linux has a number of very useful GDB scripts under scripts/gdb/linux/* >>>> that provide OS awareness for debuggers and allows for debugging of a >>>> variety of data structures (lists, timers, radix tree, mapletree, etc.) >>>> as well as subsystems (clocks, devices, classes, busses, etc.). >>>> >>>> These scripts are typically maintained in isolation from the subsystem >>>> that they parse the data structures and symbols of, which can lead to >>>> people playing catch up with fixing bugs or updating the script to work >>>> with updates made to the internal APIs/objects etc. Here are some >>>> recents examples: >>>> >>>> https://lore.kernel.org/all/20250601055027.3661480-1-tony.ambardar@gmail.com/ >>>> https://lore.kernel.org/all/20250619225105.320729-1-florian.fainelli@broadcom.com/ >>>> https://lore.kernel.org/all/20250625021020.1056930-1-florian.fainelli@broadcom.com/ >>>> >>>> This patch series is intentionally split such that each subsystem >>>> maintainer can decide whether to accept the extra >>>> review/maintenance/guidance that can be offered when GDB scripts are >>>> being updated or added. >>> >>> I don't see why you think it was okay to propose this in the way you >>> have gone about it. Looking at the mailing list, you've been around for >>> a while. >> >> This should probably have been posted as RFC rather than PATCH, but as I >> indicate in the cover letter this is broken down to allow maintainers like >> yourself to accept/reject >> >>> >>> The file you are telling me about seems to be extremely new and I needed >>> to pull akpm/mm-new to discover where it came from.. because you never >>> Cc'ed me on the file you are asking me to own. >> >> Yes, that file is very new indeed, and my bad for not copying you on it. >> >> I was not planning on burning an entire day worth of work to transition the >> GDB scripts dumping the interrupt tree away from a radix tree to a maple >> tree. All of which happens with the author of that conversion having >> absolutely no idea that broke anything in the tree because very few people >> know about the Python GDB scripts that Linux has. It is not pleasant to be >> playing catch when it would have take maybe an extra couple hours for >> someone intimately familiar with the maple tree to come up with a suitable >> implementation replacement for mtree_load(). >> >> So having done it felt like there is a maintenance void that needs to be >> filled, hence this patch set. > > I can see that it takes a lot of time to do a major update of a gdb > debugging script after some refactoring like this. OTOH mandating some gdb > scripts update is adding non-trivial amount of work to changes that are > already hard enough to do as is. This really should have been posted as RFC, because I can see how posting this as PATCH would be seen as coercing maintainers into taking those GDB scripts under their umbrella. > And the obvious question is what is the > value? I've personally never used these gdb scripts and never felt a strong > need for something like that. People have various debugging aids (like BPF > scripts, gdb scripts, there's crash tool and drgn, and many more) lying > around. Those are valuable tools in the tool box, but GDB scripts can work when your only debug tool accessible is JTAG for instance, I appreciate this is typically miles away from what most of the kernel community does, but this is quite typical and common in embedded systems. When you operate in that environment, having a decent amount of debugger awareness of what is being debugged is immensely valuable in saving time. > I'm personally of an opinion that it is not a responsibility of > the person doing refactoring to make life easier for them or even fixing > them and I don't think that the fact that some debug aid is under > scripts/gdb/ directory is making it more special. That is really the question that I am trying to get answered with this patch series. IMHO as a subsystem maintainer it is not fair to be completely oblivious to scripts that live in the source tree, even if you are not aware of those. > So at least as far as I'm> concerned (VFS, fsnotify and other filesystem related stuff) I don't plan > on requiring updates to gdb scripts from people doing changes or otherwise > actively maintain them. vfs.py script is beyond trivial, the largest and most complicated IMHO is mapletree.py which had to be recently developed to continue to support parsing the interrupt descriptor tree in the kernel, I can maintain that one now that I know a lot more than I ever wished I knew about maple trees. So really the burden is not as big as it may seem but it's fair not to be taking on more work as a maintainer, I get that. Thanks for your feedback! -- Florian