From: Edward Cree <ecree.xilinx@gmail.com>
To: Larysa Zaremba <larysa.zaremba@intel.com>,
Fushuai Wang <wangfushuai@baidu.com>
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
linux-net-drivers@amd.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2] sfc: siena: eliminate xdp_rxq_info_valid using XDP base API
Date: Tue, 1 Jul 2025 14:38:30 +0100 [thread overview]
Message-ID: <cc3dd44a-b94a-4537-b68b-49a800acc935@gmail.com> (raw)
In-Reply-To: <aGPiqlNRMBsQQCgt@soc-5CG4396X81.clients.intel.com>
On 01/07/2025 14:29, Larysa Zaremba wrote:
> On Sat, Jun 28, 2025 at 01:10:33PM +0800, Fushuai Wang wrote:
>> Commit d48523cb88e0 ("sfc: Copy shared files needed for Siena (part 2)")
>> use xdp_rxq_info_valid to track failures of xdp_rxq_info_reg().
>> However, this driver-maintained state becomes redundant since the XDP
>> framework already provides xdp_rxq_info_is_reg() for checking registration
>> status.
>>
>> Signed-off-by: Fushuai Wang <wangfushuai@baidu.com>
>
> You could have sent those patches in a single patchset, but the patches
> themselves are fine.
I asked him to split it, for a few reasons (different blamed commits,
clearer Subject: lines, Siena is EOL).
So if you don't like it, blame me ;-)
> Reviewed-by: Larysa Zaremba <larysa.zaremba@intel.com>
next prev parent reply other threads:[~2025-07-01 13:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-28 5:10 [PATCH net-next v2] sfc: siena: eliminate xdp_rxq_info_valid using XDP base API Fushuai Wang
2025-07-01 12:23 ` Edward Cree
2025-07-01 13:29 ` Larysa Zaremba
2025-07-01 13:38 ` Edward Cree [this message]
2025-07-02 0:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc3dd44a-b94a-4537-b68b-49a800acc935@gmail.com \
--to=ecree.xilinx@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=larysa.zaremba@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net-drivers@amd.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wangfushuai@baidu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox