From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE88F326958 for ; Thu, 13 Nov 2025 23:18:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763075913; cv=none; b=UvnPigiiwKUhe6W6tORGm9fVXUMOLxTYBBNjJVSQa9veViYLVSnpyPjlHM2VVVQvntCPZjM3cft/bb1DnmzR10cLrBETRKdPEa+13fITAoUHbCsoFWvX1/j9C82DhgxpTq4UpNOfA+uQMTrMz7KEXIfxC0VC6FKsig306EWzSqs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763075913; c=relaxed/simple; bh=MHKO0LuYkwgQG08kcxnR45HkZ1E4snqVlozKGhkbUEQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qjt8xaP/oA61VhXy72NbGlbU5UhoB5/SbEZxBWQEY9n6/nrkU/hS09DHrN3eLRQUZomXnrU+u0rGbo3JeDvxjByswTd1ZcXSA22XpS+n9Fkbh4ohxCp0uLqpcJOQo3a/5Z0Sms3tbeELdw50eTLDJD+qOl6eJXVYNpPvxdP54qw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kzu/2UyX; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kzu/2UyX" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-7b86e0d9615so1180827b3a.0 for ; Thu, 13 Nov 2025 15:18:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763075911; x=1763680711; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=JqxHSWJwh9CDjb4VTHqcw2rRdk1CxzwDECQB2jam6Gs=; b=kzu/2UyXgKDSH4O7S2mF+c9ov5WtoxL3p1gj4Y/wPvv/8Paben7QYfalZbxrRQg/KA y4EaQipxxs6tkWe/WvLZJCkNn+mxHSz4HGHCohza0HqIKi/7qYVnpykYJCSkiZki2S7e 54034dJ2I0HQ+4QPUSInOjFRKGrt8pcsLcCUPnUZleJ44ir+XhXNV7uAafOedRXISsqF JuT/rKsH58WKA5uu79ABpqTZ/CjwlZ0Qv9XI60QS6BbLaji8gptDgRQ8nna/3oV/c1a1 aBnQ2Jleoe6Ysm+ja/z0RRYOPHy/P1nzygjB3/GsvORaoaaUfbpae38TXGS3d+jf/3Ld dU2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763075911; x=1763680711; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JqxHSWJwh9CDjb4VTHqcw2rRdk1CxzwDECQB2jam6Gs=; b=YTDA/AYOwdw/NTAPAwo4/qrKdPZ/BG+IXKyr+Eh7jAICJ0OLPxIIFM/vZhDYugc5Ci oicQsTyr8wWS3rybGEAFjR0KLz/jqfoEb/3QxBOdIm5l7LWi+5Lw+1Di6nDsRHSgDBsv MhsFhepSrpa/ofxiSCBUqKQ7MtjUpxCcRUWv1qa7NFeVhmtepbND82SBkcWoVnTq3Pv/ h336Wlt8rS3uMZcbjwhq1prokAvNuExOYE4qM0TYlaB3j+w/1i7edgrn8f2Six7vMrj+ lpAy+KA9FkHGKkUVYlbjFrfvZch4swZI7BH+Ma1gEksrXBUGyPA9X2ptQ6bUWccteBIL A9yw== X-Forwarded-Encrypted: i=1; AJvYcCVaLXVQF6dZUlbgepcsa6d0ifTOGnV3MyGZY4gk17XRUMJm6Kz6tfYfl+JTQrqudyPpv48IKVghuvID27o=@vger.kernel.org X-Gm-Message-State: AOJu0YywUOGyuwplIj6lDgNUxbMfCzQR4q3g1EPYD/0BZK8DhPi9Q5PH w7SNUg9tp2ykyS9mmUdrdjrTtlkHv6gwxkFc2fkwoSOG6nkKUqVHeW9LPKmuQPHE X-Gm-Gg: ASbGnctA9VrKKsiFfEcFIA7hoIuZisgv/PjPxgSaOmcStsoABcmiSfs3RoNGe0tGMjn vigOpAQUrhQdKMXJZyneHHrSk7W7ooGqEba3g9e9heAfCRxMMWhGVC+POsB5wdDh/d+DypmlO+8 tO40AbMQf8CprI43Y08VZKfvMh+5pBXwh+kGiyf1Y8O4FMl732EkAR4Rk2g3RnjD3eC4y0oJhvy it8YRPnkP2uwDOE/CFWcVe4iFhwwgiDaBT+kIXsh3dkjVp4cXsYrTUiZLpjo8qgpOqRvCUFbjBO bPdK7Crl7v+B6wu2OLwDv1ESELHJKo2wsPqhuc1M0BDAflhX0of4Z9S9pMglTmK2CgmKzBmQMOv smE6VMrvvaHd5PWnfEgRmmmudbr28cRNk4fYJ3QL5oOmrqV38ARSEIjQH91YuSO5O4SRShPcSt+ BU7zGQXMbRuVhBnKStaLPbMftadRaLHGHCVg3scB4W4I6FrFR9r1yOv5nvnQ== X-Google-Smtp-Source: AGHT+IEQwGTvzdxqueYQ7ZxwR+VwJWgC9inc87W7wIjhNC6b8Gq6/Q5GoOgqUVdaggkmUxHv8fh/yw== X-Received: by 2002:a05:6a20:7d9f:b0:33d:7c76:5d68 with SMTP id adf61e73a8af0-35ba209f574mr1514067637.46.1763075911213; Thu, 13 Nov 2025 15:18:31 -0800 (PST) Received: from ?IPV6:2a03:83e0:1151:15:c56:221b:35d5:85f? ([2620:10d:c090:500::5:6ae8]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-bc36db25bfbsm3240711a12.1.2025.11.13.15.18.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Nov 2025 15:18:30 -0800 (PST) Message-ID: Date: Thu, 13 Nov 2025 15:18:29 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next] eth: fbnic: Configure RDE settings for pause frame To: Andrew Lunn Cc: netdev@vger.kernel.org, alexanderduyck@fb.com, almasrymina@google.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, horms@kernel.org, kernel-team@meta.com, kuba@kernel.org, linux-kernel@vger.kernel.org, linux@armlinux.org.uk, pabeni@redhat.com, rmk+kernel@armlinux.org.uk References: <20251112180427.2904990-1-mohsin.bashr@gmail.com> <289f4375-c569-44ca-86cb-18b48d17c9c3@lunn.ch> Content-Language: en-US From: Mohsin Bashir In-Reply-To: <289f4375-c569-44ca-86cb-18b48d17c9c3@lunn.ch> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit > You should store this away in mac_link_up. Pause can be negotiated. It > could be the link partner does not want pause, does not support pause. > When phylink calls .mac_link_up this has all been determined and you > then know how to setup the hardware. Here is too early. > > Andrew Agreed. Even though fbnic currently does not support autoneg, moving this to .mac_link_up is the right approach. Thanks for the feedback.