From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FA3FC606CF for ; Wed, 10 Jul 2019 12:54:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E790D20651 for ; Wed, 10 Jul 2019 12:54:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727175AbfGJMyF (ORCPT ); Wed, 10 Jul 2019 08:54:05 -0400 Received: from host-88-217-225-28.customer.m-online.net ([88.217.225.28]:49022 "EHLO mail.dev.tdt.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725956AbfGJMyF (ORCPT ); Wed, 10 Jul 2019 08:54:05 -0400 Received: from mail.dev.tdt.de (localhost [IPv6:::1]) by mail.dev.tdt.de (Postfix) with ESMTP id 478B5216E4; Wed, 10 Jul 2019 12:54:03 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 10 Jul 2019 14:54:03 +0200 From: Florian Eckert To: "Enrico Weigelt, metux IT consult" Cc: Andy Shevchenko , Eckert.Florian@googlemail.com, "Enrico Weigelt, metux IT consult" , Darren Hart , Andy Shevchenko , Platform Driver , Linux Kernel Mailing List Subject: Re: [PATCH 0/3] Update pcengines-apuv2 platform device In-Reply-To: <4b43316c-3e05-0ce9-3ada-db22996205b9@metux.net> References: <20190704090205.19400-1-fe@dev.tdt.de> <4b43316c-3e05-0ce9-3ada-db22996205b9@metux.net> Message-ID: X-Sender: fe@dev.tdt.de User-Agent: Roundcube Webmail/1.1.5 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019-07-08 21:45, Enrico Weigelt, metux IT consult wrote: > On 04.07.19 15:39, Andy Shevchenko wrote: >> On Thu, Jul 4, 2019 at 12:02 PM Florian Eckert wrote: >>> >>> This patchset adds the following changes to this pcengines-apuv2 >>> platform device. >>> >> >> Before doing anything to this driver, what is the plan for previously >> upstreamed: >> >> drivers/leds/leds-apu.c > > Only supports the three front LEDs, nothing else. (we've got more gpios > that are not LEDs, eg. the front button, simsw, ...) > >> arch/x86/platform/geode/alix.c > > completely unrelated - very different chipset. > > > --mtx I'm going to sum it all what we have ALIX family boards (https://www.pcengines.ch/alix.htm): CPU -> AMD Geode LX CPU Stays as it is different because it has a different CPU APU family boards (https://www.pcengines.ch/apu.htm): CPU -> AMD G series T40E APU Remove the related APU2 family stuff from the LEDs driver https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/leds/leds-apu.c this will be handled in the future by the platform device https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/platform/x86/pcengines-apuv2.c The other GPIOs are not supported by this platform. Only LEDs are supported for now. APU2 family boards (https://www.pcengines.ch/apu2.htm): CPU -> AMD Embedded G series GX-412TC Add the additional mpcie reset pins and add additional board descriptions to https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/platform/x86/pcengines-apuv2.c?h=v5.2#n61 so we can distinguish between the APU2,APU3 and APU4 boards of the APU2 board family. My research in the pcengines documentation shows the following GPIO pins for the individual boards which we can support. APU2: front-led1 front-led2 front-led3 front-button mpcie2_reset mpcie3_reset APU3: front-led1 front-led2 front-led3 front-button mpcie2_reset mpcie3_reset simswap APU4: front-led1 front-led2 front-led3 front-button mpcie2_reset mpcie3_reset Until now we support aAPU2 and APU3 and treat it the same way. But the APU2 does not have a simswap. Kind regards Florian