From: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
"Joerg Roedel" <joro@8bytes.org>, Jason Gunthorpe <jgg@ziepe.ca>,
Nicolin Chen <nicolinc@nvidia.com>,
Michael Shavit <mshavit@google.com>,
Mostafa Saleh <smostafa@google.com>,
Lu Baolu <baolu.lu@linux.intel.com>,
Kevin Tian <kevin.tian@intel.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: RE: [PATCH] iommu/arm-smmu-v3: Fix a NULL vs IS_ERR() check
Date: Thu, 15 Aug 2024 13:03:50 +0000 [thread overview]
Message-ID: <cc6b31a1cb334ecf8458e888d66e362a@huawei.com> (raw)
In-Reply-To: <9208cd0d-8105-40df-93e9-bdcdf0d55eec@stanley.mountain>
> -----Original Message-----
> From: Dan Carpenter <dan.carpenter@linaro.org>
> Sent: Thursday, August 15, 2024 12:25 PM
> To: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>
> Cc: Will Deacon <will@kernel.org>; Robin Murphy
> <robin.murphy@arm.com>; Joerg Roedel <joro@8bytes.org>; Jason
> Gunthorpe <jgg@ziepe.ca>; Nicolin Chen <nicolinc@nvidia.com>; Michael
> Shavit <mshavit@google.com>; Mostafa Saleh <smostafa@google.com>; Lu
> Baolu <baolu.lu@linux.intel.com>; Kevin Tian <kevin.tian@intel.com>; linux-
> arm-kernel@lists.infradead.org; iommu@lists.linux.dev; linux-
> kernel@vger.kernel.org; kernel-janitors@vger.kernel.org
> Subject: [PATCH] iommu/arm-smmu-v3: Fix a NULL vs IS_ERR() check
>
> The arm_smmu_domain_alloc() function returns error pointers on error. It
> doesn't return NULL. Update the error checking to match.
>
> Fixes: 52acd7d8a413 ("iommu/arm-smmu-v3: Add support for
> domain_alloc_user fn")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>
Thanks,
Shameer
next prev parent reply other threads:[~2024-08-15 13:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-15 11:25 [PATCH] iommu/arm-smmu-v3: Fix a NULL vs IS_ERR() check Dan Carpenter
2024-08-15 12:06 ` Jason Gunthorpe
2024-08-15 13:03 ` Shameerali Kolothum Thodi [this message]
2024-08-16 15:15 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc6b31a1cb334ecf8458e888d66e362a@huawei.com \
--to=shameerali.kolothum.thodi@huawei.com \
--cc=baolu.lu@linux.intel.com \
--cc=dan.carpenter@linaro.org \
--cc=iommu@lists.linux.dev \
--cc=jgg@ziepe.ca \
--cc=joro@8bytes.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kevin.tian@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mshavit@google.com \
--cc=nicolinc@nvidia.com \
--cc=robin.murphy@arm.com \
--cc=smostafa@google.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox