public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Woody Suwalski <terraluna977@gmail.com>
To: Guanbing Huang <albanhuang@outlook.com>,
	gregkh@linuxfoundation.org, andriy.shevchenko@intel.com,
	rafael.j.wysocki@intel.com
Cc: linux-acpi@vger.kernel.org, tony@atomide.com,
	john.ogness@linutronix.de, yangyicong@hisilicon.com,
	jirislaby@kernel.org, linux-kernel@vger.kernel.org,
	linux-serial@vger.kernel.org, lvjianmin@loongson.cn,
	albanhuang@tencent.com, tombinfan@tencent.com
Subject: Kernel 6.10-rc1 b,Build error with [PATCH v5 2/3] serial: port: Add support of PNP IRQ
Date: Mon, 27 May 2024 15:44:42 -0400	[thread overview]
Message-ID: <cc8a93b2-2504-9754-e26c-5d5c3bd1265c@gmail.com> (raw)
In-Reply-To: <PSAPR06MB4952C4112E75D882AC61CA5EC9002@PSAPR06MB4952.apcprd06.prod.outlook.com>

Guanbing Huang wrote:
> From: Guanbing Huang <albanhuang@tencent.com>
>
> The function __uart_read_properties doesn't cover PNP devices, so add IRQ
> processing for PNP devices in the branch.
>
> Signed-off-by: Guanbing Huang <albanhuang@tencent.com>
> Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> Reviewed-by: Bing Fan <tombinfan@tencent.com>
> Tested-by: Linheng Du <dylanlhdu@tencent.com>
> ---
> v4 -> v5: change "pnp" and "irq" in the commit message to uppercase, modify the subject
>            to start with "serial: port:", modify the location of the header file pnp.h
>
>   drivers/tty/serial/serial_port.c | 7 ++++++-
>   1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/serial_port.c b/drivers/tty/serial/serial_port.c
> index 22b9eeb23e68..8504bae1d2c9 100644
> --- a/drivers/tty/serial/serial_port.c
> +++ b/drivers/tty/serial/serial_port.c
> @@ -11,6 +11,7 @@
>   #include <linux/of.h>
>   #include <linux/platform_device.h>
>   #include <linux/pm_runtime.h>
> +#include <linux/pnp.h>
>   #include <linux/property.h>
>   #include <linux/serial_core.h>
>   #include <linux/spinlock.h>
> @@ -221,7 +222,11 @@ static int __uart_read_properties(struct uart_port *port, bool use_defaults)
>   
>   	if (dev_is_platform(dev))
>   		ret = platform_get_irq(to_platform_device(dev), 0);
> -	else
> +	else if (dev_is_pnp(dev)) {
> +		ret = pnp_irq(to_pnp_dev(dev), 0);
> +		if (ret < 0)
> +			ret = -ENXIO;
> +	} else
>   		ret = fwnode_irq_get(dev_fwnode(dev), 0);
>   	if (ret == -EPROBE_DEFER)
>   		return ret;

Hello all, trying to build 6.10-rc1 fails for me in serial_base.o:
   CALL    scripts/checksyscalls.sh
   DESCEND objtool
   INSTALL libsubcmd_headers
   CC [M]  drivers/tty/serial/serial_port.o
   LD [M]  drivers/tty/serial/serial_base.o
   MODPOST Module.symvers
ERROR: modpost: "pnp_bus_type" [drivers/tty/serial/serial_base.ko] 
undefined!
make[2]: *** [scripts/Makefile.modpost:145: Module.symvers] Error 1
make[1]: *** 
[/woody/src/kernels/linux-6.10-pingu/work/linux-6.10/Makefile:1892: 
modpost] Error 2
make: *** [Makefile:246: __sub-make] Error 2

Reversing the patch "fixes" the problem :-(
I am building on a Debian bookworm system, gcc 12.2

Any suggestions  how to make it work?

Thanks, Woody



  reply	other threads:[~2024-05-27 19:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1712472167.git.albanhuang@tencent.com>
2024-04-08  3:36 ` [PATCH v5 1/3] PNP: Add dev_is_pnp() macro Guanbing Huang
2024-04-08  3:36 ` [PATCH v5 2/3] serial: port: Add support of PNP IRQ to __uart_read_properties() Guanbing Huang
2024-05-27 19:44   ` Woody Suwalski [this message]
2024-05-27 20:15     ` Kernel 6.10-rc1 b,Build error with [PATCH v5 2/3] serial: port: Add support of PNP IRQ Andy Shevchenko
2024-04-08  3:36 ` [PATCH v5 3/3] serial: 8250_pnp: Support configurable reg shift property Guanbing Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cc8a93b2-2504-9754-e26c-5d5c3bd1265c@gmail.com \
    --to=terraluna977@gmail.com \
    --cc=albanhuang@outlook.com \
    --cc=albanhuang@tencent.com \
    --cc=andriy.shevchenko@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=john.ogness@linutronix.de \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=lvjianmin@loongson.cn \
    --cc=rafael.j.wysocki@intel.com \
    --cc=tombinfan@tencent.com \
    --cc=tony@atomide.com \
    --cc=yangyicong@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox