From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F07E3909AC for ; Tue, 23 Jun 2026 09:30:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782207053; cv=none; b=YE9guopnm4F+83zUsIf5M+xBILgn+mjqSSHQqKM3hWwk0gwLlOkPw1jY50qbD5rsSArfmBmwUbOASg2hOyM4f5W2n52RajamfYsWVZx8My/PvFhRdzU37zbr7xqLE7EJz1BwArPylizkExLof68dFnL35g7wyJ5DB5ojoTo2EXo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782207053; c=relaxed/simple; bh=PVljsgrSet0Sw13LcwwZTMfVebAKG1YbyGt074vVCac=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=NihICG0IRl8ouW2sk4me/nrAWvbp3ammbaNwEC5Rx2W8H9jp0p9gtwRxZa4h0GPnYUnhfkMF19+LNoPb2RwxAZO0VVE7exr3wMMTT8Y4KpGsPxcSS2XjBIsPltWoVO84+VEv8IkiDNOROpDiCMK0KgrNQTpjI8HlxOOVmccfVME= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=D5pqRZTz; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=KssXnaGB; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="D5pqRZTz"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="KssXnaGB" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65N6dNhq3631267 for ; Tue, 23 Jun 2026 09:30:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= MJYEI4YXKhKmSUa7HJKZYu1OYH8EbWwSDKhrtSJcDn4=; b=D5pqRZTzXBf0Wa+4 oWFHUqWXRifYWOi9LmF02agtJxLkwtMJAKIPXPlZw7nr12QDcyQlZf0B1L4lIS7p ORG/VQ60ITd5nRuy2zdF6lxctUsU3kraeI6SnTuLTXthyRTWwWTGm1TR5uD+cY5K vlhQDlDIO18nr7AMN+jMFHVpFuGciUZK48ripLlyf3dUYlr/C2ONm7hefI3EcwBr 88AaJPMLpKH2OSu/HapwcGtjzazOq3vJeo1QBxwfYN2fg1tHeevKE39pOw/Y8qIr v0oUHtxVySMqJZc0zlpn/kL7JdUBWiY/ahwQ/slFvcpvmeR2NcgzwJDLpPcuY+RA Qeoytg== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eymnvrrw3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 23 Jun 2026 09:30:51 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-51a15cef334so6070001cf.3 for ; Tue, 23 Jun 2026 02:30:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782207050; x=1782811850; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=MJYEI4YXKhKmSUa7HJKZYu1OYH8EbWwSDKhrtSJcDn4=; b=KssXnaGBuBM27NyZosK9Z7YPmw0YGKNkcdJgaxEeDyzYVJoxMIic5541RB3KfiGVpL F7EwoSDISXVqOLkaRB5alBrd8gIxIcpFIP7sw/3KUADO0I4d9cYegl65A29VnCz00XjB Cq9iyGYhXJWip1YsIb4FFJh31SN6jdwi/5Jp/6HDX0IThVtG5pg+uSxYUD88HT2qlAG1 abT6XBNQkU0fmAdj0+ehFK3Sg3mY/JbFL2J2SkXF32QC8EJgWa7VjxyjayigTIEOhZIC eYxx7AugNl2162eFIEffEFDGJFTs53ivhDQLnv3Z48ja7oDUxl4SW1o7dY6HMRaRr8ML RCuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782207050; x=1782811850; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MJYEI4YXKhKmSUa7HJKZYu1OYH8EbWwSDKhrtSJcDn4=; b=kmDyyMR/kEQAjl4tw6FFKOJXvlg7dpf762Rq+oKgSa9Iy8nxoDDOgLN6KbCPY6YoV+ Vs7+Jnm1F7wMT9cUKbmY+FfGLk61JXpwOUoYkGYqpy+5s07JwudTBsWK7+xfoEvrQPHz hZ4sAlaEvbkmtiTdL0eqMefmoBl9OTKDi0GYXl71K9Pv+FnaOVAUJnyQUlAlCCjIPaHe lU7GfhFEqDNoMpSW1n1kii7KaynSegE6610A5O+V1c9cfBiVSCF1kdTNPKqscc+QiPbO 4sfmB/q45NA5WjxycQI7ECfRJgsK7Aso63pA0B4Jm490ZEvDwmNhWsUd6Rt/UFgHS0fM YTOA== X-Forwarded-Encrypted: i=1; AFNElJ+Zm1vyjFJulwiM3V8sSq3uvV6adNuihzjnLKwM3DMSfm1mkcRruxURpau0JqXf4bUw78iL4c7cGSL3bI0=@vger.kernel.org X-Gm-Message-State: AOJu0YznmX571IRz6bCop0A8vqGXHjCdKGsx7+nbdkWgqanHm0rRZSiu kkCSmfE5Eqp25wuhOeerFL1VpZZW444ldGdzWUj9/1WdP8kpD5S6Njk38deQit0evYOAmyKyyZM u2z0cDp9RB3jRBsD50JuIGdkTLPFOwXjh7BVv7BoVssUzvZWMFHl9nRKmQBkQmxbObIg= X-Gm-Gg: AfdE7cl8q5/AFns9xrrEE1dGAIUispX95SaSm9el6saibeaC/wWo5noQGvgp90VlkkD 8SkDajQ5iivFJeEK6Ly6xbfdzRuGAtvAq3Q0KcWWUQImdIP3vRNa1nBrAN6TA8QofaDJIbkQ6H9 dwdJpfeM84MQcI4u4Aj5IkqUDAtHC2M3mGEqaOFBofR8rVFV+Y3XwL6HgTKYuvaXLaHRlGZ8Vt1 PLiZ/fLdjqWSgdU8KvzLi+u6CuhTB/HrpiIdZqLmZ3iwT+sV+G9jalB4sMd6BXttx7PjLipy2Tm J/23dtJ7RNigKX3wKHR+M7XMRWJzhoHSUgKZTf5Ngd+dU6Y7aJIhXDqyqw752ElIAn+bCnDgnzz D9uW3hi6UjCxL/V2z5JpAFqjlAs7EHiospOU= X-Received: by 2002:a05:622a:650:b0:517:62f4:e3d1 with SMTP id d75a77b69052e-51a4f42cacbmr45002411cf.2.1782207050421; Tue, 23 Jun 2026 02:30:50 -0700 (PDT) X-Received: by 2002:a05:622a:650:b0:517:62f4:e3d1 with SMTP id d75a77b69052e-51a4f42cacbmr45002031cf.2.1782207049668; Tue, 23 Jun 2026 02:30:49 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-69796c10dbasm3342945a12.8.2026.06.23.02.30.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Jun 2026 02:30:48 -0700 (PDT) Message-ID: Date: Tue, 23 Jun 2026 11:30:47 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] soc: qcom: smp2p: fix __iomem annotation on entry->value pointer To: Ben Dooks , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Chris Lew References: <20260623085931.589735-1-ben.dooks@codethink.co.uk> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260623085931.589735-1-ben.dooks@codethink.co.uk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=dOWWXuZb c=1 sm=1 tr=0 ts=6a3a524b cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=1EsaE_6oAAAA:8 a=6-cX_FYrlKhM5fZ7MtYA:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 a=3ZumFrijQQ-2J9H5h8ct:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjIzMDA3NiBTYWx0ZWRfXyKYPQKsu2KQp 1qjFESg16ZGipQwGip+UEooHUGWMcMDydUyTpj3gpSr/cwUHcyPLFyHR/vGt6PRwqnggkhSEqpg XWSqqWG24RE6og7Icnofmt99cO7aUqI= X-Proofpoint-ORIG-GUID: XqvwTfYAHv53hPMjiMgrZy6vDWjsCZxd X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjIzMDA3NiBTYWx0ZWRfX1x2Rpz5Sj/OG hJYBVhI1a2eKYigCHkJXg4nozyH1jq2F8kq58vRNQbcGVbL2O6vOO1J2gsIVIUIVDYsDGXcIUDB xLISFl5e3XMB5611iV643OCVrqG7s4Z7BcnwaBoXZMIj6ZQQliUqyKHk/fY81gVeXF+rIxHNpIK L1P+4FZ1pldQlP0b6gEC6UpkP64Fz/EsfIRzq+LjhmWfPNXVsES+PSgXUBBQLwsheUWJYIyQL2Z jX6Fpx32MjzZz7S/d2QtDVYyAswyuIwU42BUMjxNol6zHhxolvfhx4FnDnfT3GgU5tD5SfZlB2M ZOyTe5UDApQsP6D3XqRmubEBGg/KJmc9NI3mdUb1ing1CJrOGRB/5SyL3m12U6pz3EgJx7j8HQM y1vNppLFQ1rJYnlPmkXDC1mLky035J+CNvPJNZOpW2YRSUNVtKxd4ZnyrScgCAWKRitX2twp+GJ nXYhzxkPHH9UH3M9b3g== X-Proofpoint-GUID: XqvwTfYAHv53hPMjiMgrZy6vDWjsCZxd X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-23_02,2026-06-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 lowpriorityscore=0 priorityscore=1501 impostorscore=0 adultscore=0 bulkscore=0 clxscore=1015 phishscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606230076 On 6/23/26 10:59 AM, Ben Dooks wrote: > The entry->value is passed to readl() so should be marked __iomem > so remove these sparse warnings by marking it __iomem and do the > relevant casting to ensure no further warnings: > > drivers/soc/qcom/smp2p.c:280:64: warning: incorrect type in argument 1 (different address spaces) > drivers/soc/qcom/smp2p.c:280:64: expected void const volatile [noderef] __iomem *addr > drivers/soc/qcom/smp2p.c:280:64: got unsigned int [usertype] *value > drivers/soc/qcom/smp2p.c:318:34: warning: incorrect type in argument 1 (different address spaces) > drivers/soc/qcom/smp2p.c:318:34: expected void const volatile [noderef] __iomem *addr > drivers/soc/qcom/smp2p.c:318:34: got unsigned int [usertype] *value > drivers/soc/qcom/smp2p.c:446:26: warning: incorrect type in argument 1 (different address spaces) > drivers/soc/qcom/smp2p.c:446:26: expected void const volatile [noderef] __iomem *addr > drivers/soc/qcom/smp2p.c:446:26: got unsigned int [usertype] *value > drivers/soc/qcom/smp2p.c:501:33: warning: incorrect type in argument 1 (different address spaces) > drivers/soc/qcom/smp2p.c:501:33: expected void const volatile [noderef] __iomem *addr > drivers/soc/qcom/smp2p.c:501:33: got unsigned int [usertype] *value > drivers/soc/qcom/smp2p.c:504:26: warning: incorrect type in argument 2 (different address spaces) > drivers/soc/qcom/smp2p.c:504:26: expected void volatile [noderef] __iomem *addr > drivers/soc/qcom/smp2p.c:504:26: got unsigned int [usertype] *value > > Signed-off-by: Ben Dooks > --- +Chris, is this actually iomem, or should this be treated as normal memory (since this is just coming from SMEM, perhaps just memmap()?) Konrad > drivers/soc/qcom/smp2p.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/soc/qcom/smp2p.c b/drivers/soc/qcom/smp2p.c > index af0ceeaf6e07..fef6f17c3257 100644 > --- a/drivers/soc/qcom/smp2p.c > +++ b/drivers/soc/qcom/smp2p.c > @@ -102,7 +102,7 @@ struct smp2p_entry { > struct qcom_smp2p *smp2p; > > const char *name; > - u32 *value; > + u32 __iomem *value; > u32 last_value; > > struct irq_domain *domain; > @@ -276,7 +276,7 @@ static void qcom_smp2p_start_in(struct qcom_smp2p *smp2p) > list_for_each_entry(entry, &smp2p->inbound, node) { > memcpy(buf, in->entries[i].name, sizeof(buf)); > if (!strcmp(buf, entry->name)) { > - entry->value = &in->entries[i].value; > + entry->value = (u32 __iomem *)&in->entries[i].value; > entry->last_value = readl(entry->value); > break; > } > @@ -302,7 +302,7 @@ static void qcom_smp2p_notify_in(struct qcom_smp2p *smp2p) > list_for_each_entry(entry, &smp2p->inbound, node) { > memcpy(buf, in->entries[i].name, sizeof(buf)); > if (!strcmp(buf, entry->name)) { > - entry->value = &in->entries[i].value; > + entry->value = (u32 __iomem *)&in->entries[i].value; > break; > } > } > @@ -528,7 +528,7 @@ static int qcom_smp2p_outbound_entry(struct qcom_smp2p *smp2p, > memcpy(out->entries[out->valid_entries].name, buf, SMP2P_MAX_ENTRY_NAME); > > /* Make the logical entry reference the physical value */ > - entry->value = &out->entries[out->valid_entries].value; > + entry->value = (u32 __iomem *)&out->entries[out->valid_entries].value; > > out->valid_entries++; >