Re: [PATCH v11 1/3] dt-bindings: soc: imx93-media-blk-ctrl: Add PDFC subnode to schema and example

Krzysztof Kozlowski
2026-03-04T15:49:35Z

On 03/03/2026 22:00, Frank Li wrote:
> From: Frank Li (AI-BOT) <frank.li@nxp.com>
>
> AI bot review and may be useless.
>
> This is a device tree bindings patch, not kernel C code. The YAML
> schema additions look structurally sound. A few observations:
>
>> + dpi-bridge:
>> + type: object
>> + additionalProperties: false
>> +
>> + properties:
>> + compatible:
>> + enum:
>> + - nxp,imx91-pdfc
>> + - nxp,imx93-pdfc
>
> The compatible strings should be documented in a separate vendor
> prefix file (nxp.yaml) if not already present. Verify they exist
> in Documentation/devicetree/bindings/vendor-prefixes.yaml.

What?!?!?

This is nonsense.

Also, you are responding to an already reviewed patch.

Best regards,
Krzysztof