From: Lee Duncan <LDuncan@suse.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>,
"wubo (T)" <wubo40@huawei.com>
Cc: "cleech@redhat.com" <cleech@redhat.com>,
"jejb@linux.ibm.com" <jejb@linux.ibm.com>,
"open-iscsi@googlegroups.com" <open-iscsi@googlegroups.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Ulrich Windl <Ulrich.Windl@rz.uni-regensburg.de>,
Mingfangsen <mingfangsen@huawei.com>,
"liuzhiqiang (I)" <liuzhiqiang26@huawei.com>
Subject: Re: [PATCH V4] scsi: avoid potential deadlock in iscsi_if_rx func
Date: Tue, 10 Dec 2019 00:40:59 +0000 [thread overview]
Message-ID: <ccda52ac-2ea7-b0d2-e36e-08f162569c7c@suse.com> (raw)
In-Reply-To: <yq1o8whqem3.fsf@oracle.com>
On 12/9/19 3:11 PM, Martin K. Petersen wrote:
>
> wubo,
>
>> In iscsi_if_rx func, after receiving one request through
>> iscsi_if_recv_msg func, iscsi_if_send_reply will be called to try to
>> reply the request in do-loop. If the return of iscsi_if_send_reply
>> func return -EAGAIN all the time, one deadlock will occur.
>>
>> For example, a client only send msg without calling recvmsg func, then
>> it will result in the watchdog soft lockup. The details are given as
>> follows,
>
>> Signed-off-by: Bo Wu <wubo40@huawei.com>
>> Reviewed-by: Zhiqiang Liu <liuzhiqiang26@huawei.com>
>> Reviewed-by: Lee Duncan <LDuncan@suse.com>
>
> I haven't seen a Reviewed-by: from Lee on this patch.
>
Martin:
My sincere apologies. I told wubo I had already reviewed the patch, so
he didn't need another Reviewed-by from me. I see I was wrong.
Please consider my:
Reviewed-by: Lee Duncan <lduncan@suse.com>
in the patch to be re-verified.
next prev parent reply other threads:[~2019-12-10 0:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 13:26 [PATCH V4] scsi: avoid potential deadlock in iscsi_if_rx func wubo (T)
2019-12-07 6:50 ` liuzhiqiang (I)
2019-12-09 23:11 ` Martin K. Petersen
2019-12-10 0:40 ` Lee Duncan [this message]
2019-12-10 1:39 ` Martin K. Petersen
-- strict thread matches above, loose matches on Subject: below --
2019-11-30 7:25 wubo (T)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ccda52ac-2ea7-b0d2-e36e-08f162569c7c@suse.com \
--to=lduncan@suse.com \
--cc=Ulrich.Windl@rz.uni-regensburg.de \
--cc=cleech@redhat.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=liuzhiqiang26@huawei.com \
--cc=martin.petersen@oracle.com \
--cc=mingfangsen@huawei.com \
--cc=open-iscsi@googlegroups.com \
--cc=wubo40@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox