From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 777A1318151 for ; Tue, 23 Dec 2025 15:34:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766504089; cv=none; b=WDS/PGujxPEGiVAtd/FckwlFTJYChQRdFjUMB5bGUBhOdufOlwgD7vxULcGadU0KgDUJB9RSUU6YV/ob5kWr2jBiUeKZveOn7zNT9DwGsK04iTGyRY3He62EghOC3zRIwOf3sEm2L3pr+vthBEqk2aZ72p9mXqx99l2S/WFI8FY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766504089; c=relaxed/simple; bh=LC3cdBZ6Ngf+4CQshxrt4rb7NbJ4XT2zTtCXsIe8ZMc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gSiEcMIWQxJYEfwAAkutl0E2TGSP7U2Zc46reHKtCNRA+lZxmLl/VdMY+4M23/UHQDGCtxtTP3L6deA78H0X6fVSkcHR8ia3rLIyRfs7ZLR5vT5r7mne10ViMMPcqF8cgQA4kpEoXYl02Gfb7KI8iAc3FdQGnHLv+46iI6O1/uE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=h/aT7SJZ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="h/aT7SJZ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C179FC113D0; Tue, 23 Dec 2025 15:34:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1766504089; bh=LC3cdBZ6Ngf+4CQshxrt4rb7NbJ4XT2zTtCXsIe8ZMc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=h/aT7SJZFhu3TPKfr7pa7n+7Kca5g4gxPtM7SDNqp7Mu91YvmBwBcrVd5KZhHdw2m VYEhK0VnDI8vewLgzJcACh7IQKl2LlyCnT4Zdzx1hrZBX0cje9HOkOK2kbW7bypKcj 4FGeYr95q88x94Ta3ljFaCXIqpiPO6cMDxaBNRZJOXUZsivpV6y+RJSulwhcPfw7Z9 LnSQ0x3NWze3wnSmlhpykg2V8fwhyEazyWuUYtNnZ6g/Hq3m5fD2KC0Ka3saiQ4s4l c52yj1k0iPa1BjeFqzUfBtwXM7FplF/qVU3NzoDpWH5p5xQS1IssczdPU9ELQmq4KD KegoYKLjU/m7w== Message-ID: Date: Tue, 23 Dec 2025 16:34:44 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] bus: fsl-mc: fix an error handling in fsl_mc_device_add() To: Haoxiang Li , ioana.ciornei@nxp.com Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Dan Carpenter , Su Hui References: <20251222074958.992911-1-lihaoxiang@isrc.iscas.ac.cn> Content-Language: fr-FR From: "Christophe Leroy (CS GROUP)" In-Reply-To: <20251222074958.992911-1-lihaoxiang@isrc.iscas.ac.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Le 22/12/2025 à 08:49, Haoxiang Li a écrit : > If device_add() fails, call put_device() to drop the device > reference and do the cleanp. > > Reported-by: Dan Carpenter > Closes: https://lore.kernel.org/all/b767348e-d89c-416e-acea-1ebbff3bea20@stanley.mountain/ > Signed-off-by: Su Hui > Signed-off-by: Haoxiang Li > --- > drivers/bus/fsl-mc/fsl-mc-bus.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/bus/fsl-mc/fsl-mc-bus.c b/drivers/bus/fsl-mc/fsl-mc-bus.c > index 25845c04e562..90a2107a9905 100644 > --- a/drivers/bus/fsl-mc/fsl-mc-bus.c > +++ b/drivers/bus/fsl-mc/fsl-mc-bus.c > @@ -896,7 +896,8 @@ int fsl_mc_device_add(struct fsl_mc_obj_desc *obj_desc, > dev_err(parent_dev, > "device_add() failed for device %s: %d\n", > dev_name(&mc_dev->dev), error); > - goto error_cleanup_dev; > + put_device(&mc_dev->dev) This change has obviously not been tested, not even built. And by droping the goto, the kfree() are not done anymore, leaking mc_bus/mc_dev p kzalloced areas. > + return error; > } > > dev_dbg(parent_dev, "added %s\n", dev_name(&mc_dev->dev));