Re: Kernel SCM saga..

Florian Weimer
2005-04-08T12:21:39Z

* Matthias Andree:

>> commiter_name VARCHAR(32) NOT NULL CHECK(commiter_name != ''),
>> commiter_email VARCHAR(32) NOT NULL CHECK(commiter_email != ''),
>
> The length is too optimistic and insufficient to import the current BK
> stuff. I'd vote for 64 or at least 48 for each, although 48 is going to
> be a tight fit. It costs a bit but considering the expected payload
> size it's irrelevant.

You should also check your database documentation if VARCHAR(n) is
actually implemented implemented in the same way as TEXT (or what the
unbounded string type is called), plus an additional length check. It
doesn't make much sense to use VARCHAR if there isn't a performance
(or disk space) benefit, IMHO, especially for such data.