From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 472D8C04FDF for ; Mon, 14 Aug 2023 08:46:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234636AbjHNIqJ (ORCPT ); Mon, 14 Aug 2023 04:46:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234412AbjHNIqG (ORCPT ); Mon, 14 Aug 2023 04:46:06 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C165A91; Mon, 14 Aug 2023 01:46:01 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 604F263D21; Mon, 14 Aug 2023 08:46:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B9824C433C7; Mon, 14 Aug 2023 08:45:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692002760; bh=B3y8EHsDG3ckVBJqhMu+4wNcutKVET22OPIzB3BHlZ0=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=IAwz4csbyfvh6Sc60rY3F4KQBQhcpuI6oJ+2qyYb1X2EbPWPD3nk515LAGsCCsdua /RrfgQ8LZe60yxmHXmLqV2iNhQXTZt2yJNHTUAdt5j2LnL1x91+2f5crAXVuXr7I+M 4yclnHX6puLJ4n3dhyx6fFlKoAJrUyCEJEOmcFpwYcb5oz6hDBAECRGUtxHoU2pTIO MFGXP339tDE3ExQFau5AQwyOMqlNhNAVCuVXJbJGJti/5BtYxFL5HOtTmPoxvb3ZI5 /6NUgd6v072+ZFgYjyLs9xp0kxcFYsd108Ld5M+KyiFrmZ+S1cmRAt8Vy6EnHsgF6C 14tNDLeY82NTw== Message-ID: Date: Mon, 14 Aug 2023 10:45:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: hawk@kernel.org, "davem@davemloft.net" , "edumazet@google.com" , "kuba@kernel.org" , "pabeni@redhat.com" , "ast@kernel.org" , "daniel@iogearbox.net" , "john.fastabend@gmail.com" , "jiawenwu@trustnetic.com" , "mengyuanlou@net-swift.com" , "yang.lee@linux.alibaba.com" , "error27@gmail.com" , "linyunsheng@huawei.com" , "linux-hyperv@vger.kernel.org" , "kys@microsoft.com" , "haiyangz@microsoft.com" , "wei.liu@kernel.org" , "decui@microsoft.com" , "longli@microsoft.com" , "shradhagupta@linux.microsoft.com" , "linux-hwmon@vger.kernel.org" , "michael.chan@broadcom.com" , "richardcochran@gmail.com" , "jdelvare@suse.com" , "linux@roeck-us.net" , "yisen.zhuang@huawei.com" , "salil.mehta@huawei.com" , "linux-arm-kernel@lists.infradead.org" , "linux-mediatek@lists.infradead.org" , "nbd@nbd.name" , "john@phrozen.org" , "sean.wang@mediatek.com" , "Mark-MC.Lee@mediatek.com" , "lorenzo@kernel.org" , "matthias.bgg@gmail.com" , "angelogioacchino.delregno@collabora.com" , "linux@armlinux.org.uk" , "linux-rdma@vger.kernel.org" , "saeedm@nvidia.com" , "leon@kernel.org" , "gerhard@engleder-embedded.com" , "maciej.fijalkowski@intel.com" , "alexanderduyck@fb.com" , "wei.fang@nxp.com" , "shenwei.wang@nxp.com" , "xiaoning.wang@nxp.com" , "linux-imx@nxp.com" , "lgirdwood@gmail.com" , "broonie@kernel.org" , "jaswinder.singh@linaro.org" , "ilias.apalodimas@linaro.org" , "UNGLinuxDriver@microchip.com" , "horatiu.vultur@microchip.com" , "linux-omap@vger.kernel.org" , "grygorii.strashko@ti.com" , "simon.horman@corigine.com" , "vladimir.oltean@nxp.com" , "aleksander.lobakin@intel.com" , "linux-stm32@st-md-mailman.stormreply.com" , "alexandre.torgue@foss.st.com" , "joabreu@synopsys.com" , "mcoquelin.stm32@gmail.com" , "p.zabel@pengutronix.de" , "thomas.petazzoni@bootlin.com" , "mw@semihalf.com" , Sunil Kovvuri Goutham , Geethasowjanya Akula , Subbaraya Sundeep Bhatta , Hariprasad Kelam , "xen-devel@lists.xenproject.org" , "jgross@suse.com" , "sstabellini@kernel.org" , "oleksandr_tyshchenko@epam.com" , "linux-wireless@vger.kernel.org" , "ryder.lee@mediatek.com" , "shayne.chen@mediatek.com" , "kvalo@kernel.org" , "andrii@kernel.org" , "martin.lau@linux.dev" , "song@kernel.org" , "yonghong.song@linux.dev" , "kpsingh@kernel.org" , "sdf@google.com" , "haoluo@google.com" , "jolsa@kernel.org" Subject: Re: [EXT] Re: [PATCH v1 net] page_pool: Cap queue size to 32k. Content-Language: en-US To: Ratheesh Kannoth , Johannes Berg , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20230814060411.2401817-1-rkannoth@marvell.com> <8c6d19da5c4c38062b7a4e500de1d5dc1280fbc8.camel@sipsolutions.net> From: Jesper Dangaard Brouer In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/08/2023 10.05, Ratheesh Kannoth wrote: >> From: Johannes Berg >> Subject: [EXT] Re: [PATCH v1 net] page_pool: Cap queue size to 32k. >>> Please find discussion at >>> https://urldefense.proofpoint.com/v2/url?u=https-3A__lore.kernel.org_l >>> >> I'm not the one who's going to apply this, but honestly, I don't think that will >> work as a commit message for such a change ... >> Sure, link to it by all means, but also summarize it and make sense of it for >> the commit message? > > Why do you think it will not work ?. There is a long discussion about pros and cons of different approaches by > Page pool maintainers in the discussion link. However I summarize it here, as commit message, it will > Lead to some more questions by reviewers. > I agree with Johannes, this commit message is too thin. It makes sense to give a summary of the discussion, because it show us (page_pool maintainers) what you concluded for the discussion. Further more, you also send another patch: - "[PATCH net-next] page_pool: Set page pool size" - https://lore.kernel.org/all/20230809021920.913324-1-rkannoth@marvell.com/ That patch solves the issue for your driver marvell/octeontx2 and I like than change. Why did you conclude that PP core should also change? --Jesper (p.s. Cc/To list have gotten excessive with 89 recipients)