From: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>
To: Mimi Zohar <zohar@linux.ibm.com>, linux-integrity@vger.kernel.org
Cc: eric.snowberg@oracle.com, dhowells@redhat.com,
mathew.j.martineau@linux.intel.com, matthewgarrett@google.com,
sashal@kernel.org, jamorris@linux.microsoft.com,
linux-kernel@vger.kernel.org, keyrings@vger.kernel.org
Subject: Re: [PATCH v2 1/2] IMA: Define workqueue for early boot "key" measurements
Date: Thu, 12 Dec 2019 14:58:22 -0800 [thread overview]
Message-ID: <cd0d6b0c-1be4-493d-6ba7-72bd60f601cb@linux.microsoft.com> (raw)
In-Reply-To: <1576191258.4579.181.camel@linux.ibm.com>
On 12/12/2019 2:54 PM, Mimi Zohar wrote:
>>
>> I can also move the setting of ima_process_key flag inside the lock
>> along with the above change.
>
> My concern is with the last sentence "Since ima_process_keys is set to
> true above, any new key will be processed immediately and not queued."
> It's unlikely, but possible, that a second process will wait for the
> ima_keys_mutex. Either we remove this sentence or move setting
> ima_process_keys to after taking the lock.
>
> Mimi
Sure - i'll move the setting of ima_process_keys flag inside the lock
and define the flag as static. Will keep the comment as is.
thanks,
-lakshmi
next prev parent reply other threads:[~2019-12-12 22:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 18:51 [PATCH v2 0/2] IMA: Deferred measurement of keys Lakshmi Ramasubramanian
2019-12-11 18:51 ` [PATCH v2 1/2] IMA: Define workqueue for early boot "key" measurements Lakshmi Ramasubramanian
2019-12-12 8:19 ` Mimi Zohar
2019-12-12 16:57 ` Lakshmi Ramasubramanian
2019-12-12 21:13 ` Mimi Zohar
2019-12-12 21:59 ` Lakshmi Ramasubramanian
2019-12-12 22:54 ` Mimi Zohar
2019-12-12 22:58 ` Lakshmi Ramasubramanian [this message]
2019-12-11 18:51 ` [PATCH v2 2/2] IMA: Call workqueue functions to measure queued keys Lakshmi Ramasubramanian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd0d6b0c-1be4-493d-6ba7-72bd60f601cb@linux.microsoft.com \
--to=nramas@linux.microsoft.com \
--cc=dhowells@redhat.com \
--cc=eric.snowberg@oracle.com \
--cc=jamorris@linux.microsoft.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathew.j.martineau@linux.intel.com \
--cc=matthewgarrett@google.com \
--cc=sashal@kernel.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox