From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751445AbdJ1Hk2 (ORCPT ); Sat, 28 Oct 2017 03:40:28 -0400 Received: from mout.web.de ([212.227.17.11]:64431 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750788AbdJ1HkX (ORCPT ); Sat, 28 Oct 2017 03:40:23 -0400 Subject: Re: IB/mlx4: Use common error handling code in __mlx4_ib_create_flow() To: Dennis Dalessandro , linux-rdma@vger.kernel.org Cc: Leon Romanovsky , Doug Ledford , Hal Rosenstock , Sean Hefty , Yishai Hadas , Yuval Shaia , LKML , kernel-janitors@vger.kernel.org References: <0bcea3cf-91e3-01d5-8d80-34cd6b611fb1@users.sourceforge.net> <20171027193902.GJ16127@mtr-leonro.local> <5cc2ecf7-cc6e-76e0-c73b-08ce717fef83@users.sourceforge.net> <7c5a7827-209c-9bb7-5b77-ac62d3d54604@intel.com> From: SF Markus Elfring Message-ID: Date: Sat, 28 Oct 2017 09:39:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <7c5a7827-209c-9bb7-5b77-ac62d3d54604@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:G4hoEaLM1hj6lq8PqTRLNwsxt4+J3W/LZ/22dk+kd7nkr8w8YZo DklGqrVVWXlY/fUdvtjqj7PpC6L7DZJwY5THNpcEOEicIETZzzJQAb2IoEGl4cxm/O2rcWD +9nTGORBD8I36+QWzHpVRvOzXRB2zFvqVyIXQqOsbFJt90xehixP1GcDPHUthcRYWEHf9LS 89SLFYjY2Mt7MvHr+Q8/A== X-UI-Out-Filterresults: notjunk:1;V01:K0:2808vgHAdaM=:yjshwdT7xw2Ht6/niSB3BG 2rqWilTQ+cJS/gzWV2Aety35HBO4IDMnAH9IOwudfDLsmp3fwaPNDl9m3Y6D/Ru2cEjxzAwp3 +NJdSecF0Je/EdkqpympA1+qrdap7qgZq0p6Grugta979BZXnJ9zOGrWOZt4z3jXwCYDvOuZo aawm9tjQuypoJLisUcWdXoYeQNMAxOyiRE+LTEf3jjztPtr+owsDxbcdPnUMyptrJHyfybtVU PgMAHXaiHgdk7U70TRtpMnT4YNKY8FDOgd5Lts2vYMM4Vu17CvbgeVjlrQnRvTnZq6lRqo9kT tLTfoz2WC3bmN7CBgV3Ch9Zd9BYS4fdG3otTYuu8/WcVzG1BJYkq0GguadQ6GXaZAMqZttFOv fj2rBrEhTjEOQBKWTuVW+Q5SBFH7eP4WEhyjsaH2MCDwvmIqmPrKTi3DOpl9/jSMjiukhVVeV Vp24FrXjszIlTB9JUZQ5abYuzp/o78gDl4X14gwNc3i2mImDeTIxg/TuoEFT8a34K4rCBCIb5 ZZx8mnU34W+sspUTWrpkjvxIPwpUMY/+SiVeXqtx+x076nYqIHqJiFJJonPUUO24M1tuiGTs6 8P0EBK5zwy6dwJYLiKUZenS65p6YAAMBDSP+FYfBzpb6bHEQ7Kwk59JONvCvITXiukwS5lkpK aH1nGr9Qz633Sobi9Zi1gX7kWwchFJnJ9zpD0skbwxl2T7Agt2iS7IXX09FWrpupjq7ai71bm dBjZazgMGEkdZpVvVurQsACGNHMuHILPfKoqfcpfjk28we3Rax117Vr4OIuN0Mz8OchT3OkxR t4yWBZFnRmZr+apUFX/xrUMfQQMA+oj7FGlVCs3aAOLHT87bPA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> I guess that the shown change possibility can reduce the object code size >> for the affected function. … > You guess? I am convinced somehow! > Well perhaps you should find out for certain. I am trying to point another general implementation detail out: A jump to an existing call of a function like “mlx4_free_cmd_mailbox” can be useful if you would like to optimise also this software for smaller code size. Are you looking for an information source which you would trust more (than me)? > Is it an appreciable impact? I hope so. But I showed only the replacement of two function calls here. I am curious if you care for a small effect at a special place. A similar refactoring can have a bigger influence in other software modules, can't it? There might be an other useful side effect. My concrete proposal can be questionable as usual. It seems that the software development attention was increased a bit so that contributors started thinking about the relevance of the error code “-EINVAL” at another source code place again. Regards, Markus