The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Sergey Shtylyov <s.shtylyov@omp.ru>
To: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Guenter Roeck <linux@roeck-us.net>
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>, <linux-sh@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sh: Avoid using IRQ0 on SH3 and SH4
Date: Sat, 8 Jul 2023 23:52:07 +0300	[thread overview]
Message-ID: <cd1caa5d-fbd8-c3fe-29e9-b848ddd5634c@omp.ru> (raw)
In-Reply-To: <7b2c0d812280afaefee0c70a9aea00a0fcf84e3a.camel@physik.fu-berlin.de>

On 7/6/23 7:38 PM, John Paul Adrian Glaubitz wrote:
[...]

>> Which sh4 platforms in particular?
>>
>> I booted a kernel with this patch on rts7751r2d (QEMU) and landisk
>> (physical) two days ago.
> 
> I gave it a try with the command line Guenter suggested and indeed the kernel locks
> up right here with the patch applied and boots fine without it:
> 
> Creating 4 MTD partitions on "physmap-flash":
> 0x000000000000-0x000000040000 : "U-Boot"
> 0x000000040000-0x000000080000 : "Environment"
> 0x000000080000-0x000000240000 : "Kernel"
> 0x000000240000-0x000001000000 : "Flash_FS"
> 8139too: 8139too Fast Ethernet driver 0.9.28
> 8139too 0000:00:01.0: This (id 10ec:8139 rev 20) is an enhanced 8139C+ chip, use 8139cp
> sm501-usb sm501-usb: SM501 OHCI
> sm501-usb sm501-usb: new USB bus registered, assigned bus number 1
> sm501-usb sm501-usb: irq 116, io mem 0x13e40000

   I guess it was irq 100 before my patch. What if you undo the following
part of my patch?

Index: linux/arch/sh/include/mach-common/mach/r2d.h
===================================================================
--- linux.orig/arch/sh/include/mach-common/mach/r2d.h
+++ linux/arch/sh/include/mach-common/mach/r2d.h
@@ -47,7 +47,7 @@
 
 #define IRLCNTR1	(PA_BCR + 0)	/* Interrupt Control Register1 */
 
-#define R2D_FPGA_IRQ_BASE	100
+#define R2D_FPGA_IRQ_BASE	(100 + 16)
 
 #define IRQ_VOYAGER		(R2D_FPGA_IRQ_BASE + 0)
 #define IRQ_EXT			(R2D_FPGA_IRQ_BASE + 1)

> usb usb1: New USB device found, idVendor=1d6b, idProduct=0001, bcdDevice= 6.04
> usb usb1: New USB device strings: Mfr=3, Product=2, SerialNumber=1
> usb usb1: Product: SM501 OHCI
> usb usb1: Manufacturer: Linux 6.4.0-12069-gc17414a273b8 ohci_hcd
> usb usb1: SerialNumber: sm501-usb
> hub 1-0:1.0: USB hub found
> hub 1-0:1.0: 2 ports detected
> usbcore: registered new interface driver usb-storage
> rtc-r9701 spi0.0: cannot read RTC register
> usbcore: registered new interface driver usbhid
> usbhid: USB HID core driver
> NET: Registered PF_PACKET protocol family
> heartbeat: version 0.1.2 loaded
> ata1: found unknown device (class 0)
[...]

> Adrian

MBR, Sergey

  parent reply	other threads:[~2023-07-08 20:52 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-06 13:57 [PATCH] sh: Avoid using IRQ0 on SH3 and SH4 Guenter Roeck
2023-07-06 14:01 ` John Paul Adrian Glaubitz
2023-07-06 15:51   ` Guenter Roeck
2023-07-08 20:35   ` Sergey Shtylyov
2023-07-08 20:43     ` Sergey Shtylyov
2023-07-06 15:39 ` Geert Uytterhoeven
2023-07-06 15:51   ` Guenter Roeck
2023-07-06 16:38   ` John Paul Adrian Glaubitz
2023-07-06 17:04     ` Guenter Roeck
2023-07-06 17:41       ` John Paul Adrian Glaubitz
2023-07-08 20:55         ` Sergey Shtylyov
2023-07-07  7:14     ` Geert Uytterhoeven
2023-07-07  8:48       ` Geert Uytterhoeven
2023-07-07  9:30         ` John Paul Adrian Glaubitz
2023-07-07  9:53         ` John Paul Adrian Glaubitz
2023-07-07 14:34           ` Guenter Roeck
     [not found]             ` <407492B8-5D9F-41BC-A696-24C421C69F49@physik.fu-berlin.de>
2023-07-07 15:30               ` Guenter Roeck
2023-07-08 20:52     ` Sergey Shtylyov [this message]
2023-07-08 22:06       ` Guenter Roeck
2023-07-08 23:13         ` John Paul Adrian Glaubitz
2023-07-09  0:28           ` Guenter Roeck
2023-07-12  8:12           ` David Laight
2023-07-12  8:15             ` John Paul Adrian Glaubitz
2023-07-12  8:20             ` Sergei Shtylyov
2023-07-12  8:24               ` David Laight
2023-07-12 15:38               ` Guenter Roeck
2023-07-12 15:51                 ` John Paul Adrian Glaubitz
2023-07-12 16:22                 ` Sergey Shtylyov
2023-07-12 16:25                   ` Sergey Shtylyov
2023-07-08 13:26 ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cd1caa5d-fbd8-c3fe-29e9-b848ddd5634c@omp.ru \
    --to=s.shtylyov@omp.ru \
    --cc=dalias@libc.org \
    --cc=geert@linux-m68k.org \
    --cc=glaubitz@physik.fu-berlin.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox