From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E53CCE79AB for ; Wed, 20 Sep 2023 09:26:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234095AbjITJ0I (ORCPT ); Wed, 20 Sep 2023 05:26:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234046AbjITJZ7 (ORCPT ); Wed, 20 Sep 2023 05:25:59 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 7655810D1; Wed, 20 Sep 2023 02:25:23 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 22BA1C15; Wed, 20 Sep 2023 02:26:00 -0700 (PDT) Received: from [10.1.197.1] (ewhatever.cambridge.arm.com [10.1.197.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8048A3F5A1; Wed, 20 Sep 2023 02:25:21 -0700 (PDT) Message-ID: Date: Wed, 20 Sep 2023 10:25:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH V5 - RESEND 3/3] Documentation: coresight: Add cc_threshold tunable Content-Language: en-US To: Anshuman Khandual , linux-arm-kernel@lists.infradead.org Cc: Catalin Marinas , Will Deacon , Mike Leach , James Clark , Leo Yan , Jonathan Corbet , linux-doc@vger.kernel.org, coresight@lists.linaro.org, linux-kernel@vger.kernel.org References: <20230915093649.435163-1-anshuman.khandual@arm.com> <20230915093649.435163-4-anshuman.khandual@arm.com> From: Suzuki K Poulose In-Reply-To: <20230915093649.435163-4-anshuman.khandual@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/09/2023 10:36, Anshuman Khandual wrote: > This updates config option to include 'cc_threshold' tunable value. > > Cc: Suzuki K Poulose > Cc: Mike Leach > Cc: James Clark > Cc: Jonathan Corbet > Cc: coresight@lists.linaro.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-doc@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Reviewed by: Mike Leach > Signed-off-by: Anshuman Khandual > --- > Documentation/trace/coresight/coresight.rst | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/trace/coresight/coresight.rst b/Documentation/trace/coresight/coresight.rst > index 4a71ea6cb390..ce55adb80b82 100644 > --- a/Documentation/trace/coresight/coresight.rst > +++ b/Documentation/trace/coresight/coresight.rst > @@ -624,6 +624,10 @@ They are also listed in the folder /sys/bus/event_source/devices/cs_etm/format/ > * - timestamp > - Session local version of the system wide setting: :ref:`ETMv4_MODE_TIMESTAMP > ` > + * - cc_threshold > + - Cycle count threshold value. If nothing is provided here or the provided value is 0, then the > + default value i.e 0x100 will be used. If provided value is less than minimum cycles threshold > + value, as indicated via TRCIDR3.CCITMIN, then the minimum value will be used instead. > > How to use the STM module > ------------------------- The patch as such looks good to me. If possible, could you fold this into the previous patch ? Suzuki