From: Zijun Hu <zijun_hu@icloud.com>
To: Rob Herring <robh@kernel.org>
Cc: Saravana Kannan <saravanak@google.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Zijun Hu <quic_zijuhu@quicinc.com>
Subject: Re: [PATCH 4/5] of: Do not change property state under __of_add_property() failure
Date: Tue, 25 Feb 2025 23:24:06 +0800 [thread overview]
Message-ID: <cd4ec50b-dadd-490b-ab15-078dcf4bb02a@icloud.com> (raw)
In-Reply-To: <20250225144108.GB2279028-robh@kernel.org>
On 2025/2/25 22:41, Rob Herring wrote:
> On Mon, Feb 24, 2025 at 10:28:00PM +0800, Zijun Hu wrote:
>> From: Zijun Hu <quic_zijuhu@quicinc.com>
>>
>> Do not remove the property from list @np->deadprops if
>> __of_add_property() encounters -EEXIST failure.
> A property can never be on both np->deadprops and np->props.
i made this patch based on convention that
This change is made base on convention that tasks which have
been done successfully needs to be undid if fails to do the
remaining task.
It is okay to drop this patch based on condition you mentioned.
thank you. (^^)(^^)
next prev parent reply other threads:[~2025-02-25 15:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-24 14:27 [PATCH 0/5] of: Trivial cleanup Zijun Hu
2025-02-24 14:27 ` [PATCH 1/5] of: Compare property names by of_prop_cmp() in of_alias_scan() Zijun Hu
2025-02-25 14:42 ` Rob Herring (Arm)
2025-02-24 14:27 ` [PATCH 2/5] of: Introduce and apply private is_pseudo_property() Zijun Hu
2025-02-25 14:44 ` Rob Herring (Arm)
2025-02-24 14:27 ` [PATCH 3/5] of: Correct property name comparison in __of_add_property() Zijun Hu
2025-02-25 14:38 ` Rob Herring
2025-02-25 15:04 ` Zijun Hu
2025-02-25 19:57 ` Rob Herring
2025-02-24 14:28 ` [PATCH 4/5] of: Do not change property state under __of_add_property() failure Zijun Hu
2025-02-25 14:41 ` Rob Herring
2025-02-25 15:24 ` Zijun Hu [this message]
2025-02-25 15:25 ` Zijun Hu
2025-02-24 14:28 ` [PATCH 5/5] of/platform: Do not use of_get_property() to test property presence Zijun Hu
2025-02-25 14:44 ` Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd4ec50b-dadd-490b-ab15-078dcf4bb02a@icloud.com \
--to=zijun_hu@icloud.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_zijuhu@quicinc.com \
--cc=robh@kernel.org \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox