Re: [PATCH 09/10] drm/imx: Add i.MX8qxp Display Controller KMS

Markus Elfring
2024-07-07T19:16:57Z

…
> registers of the display controller is accessed without command sequencer
…

Wording suggestion:
The registers of … are …

…
> +++ b/drivers/gpu/drm/imx/dc/dc-crtc.c
> @@ -0,0 +1,578 @@
…
> +static irqreturn_t
> +dc_crtc_dec_framecomplete_irq_handler(int irq, void *dev_id)
> +{
…
> + spin_lock_irqsave(&crtc->dev->event_lock, flags);
> + if (dc_crtc->event) {
…
> + }
> + spin_unlock_irqrestore(&crtc->dev->event_lock, flags);
> +
> + return IRQ_HANDLED;
> +}
…

Under which circumstances would you become interested to apply a statement
like “guard(spinlock_irqsave)(&crtc->dev->event_lock);”?
https://elixir.bootlin.com/linux/v6.10-rc6/source/include/linux/spinlock.h#L574

Regards,
Markus