Re: [PATCH 01/10] dt-bindings: display: imx: Add some i.MX8qxp Display Controller processing units

Rob Herring
2024-07-08T20:04:32Z

On Mon, Jul 08, 2024 at 02:30:37PM +0800, Liu Ying wrote:
> On 07/07/2024, Krzysztof Kozlowski wrote:
> > On 05/07/2024 11:09, Liu Ying wrote:
> >> Freescale i.MX8qxp Display Controller is implemented as construction set of
> >> building blocks with unified concept and standardized interfaces.
> >>
> >> Document some processing units to support two display outputs.
> >
> >
> >> +maintainers:
> >> + - Liu Ying <victor.liu@nxp.com>
> >> +
> >> +properties:
> >> + compatible:
> >> + const: fsl,imx8qxp-dc-tcon
> >> +
> >> + reg:
> >> + maxItems: 1
> >> +
> >> + fsl,dc-tc-id:
> >> + description: Timing Controller unit instance number
> >
> > No instance numbering. This applies to your entire patchset.
>
> Then, I'll call of_alias_get_id() from the drivers to get
> instance number instead.

Ideally, no.

> As i.MX8qm SoC embeds two Display Controllers, the alias
> stem would contain the Display Controller instance
> number, like "dc0-tcon" and "dc1-tcon". Is this ok?

The format of aliases is fooN, so no. Aliases should also be generic
rather than vendor specific.

If you need to describe the connection of components in the display
pipeline, then use the graph binding.

Rob