* [PATCH v1] cpufreq: core: Rearrange variable declarations involving __free()
@ 2025-09-03 14:56 Rafael J. Wysocki
2025-09-03 15:08 ` Krzysztof Kozlowski
2025-09-04 4:14 ` Viresh Kumar
0 siblings, 2 replies; 4+ messages in thread
From: Rafael J. Wysocki @ 2025-09-03 14:56 UTC (permalink / raw)
To: Linux PM; +Cc: LKML, Viresh Kumar, Krzysztof Kozlowski, Zihuan Zhang
From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Follow cleanup.h recommendations and always define and assign variables
in one statement when __free() is used.
No intentional functional impact.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
drivers/cpufreq/cpufreq.c | 27 +++++++--------------------
1 file changed, 7 insertions(+), 20 deletions(-)
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -1845,7 +1845,6 @@ static unsigned int cpufreq_verify_curre
*/
unsigned int cpufreq_quick_get(unsigned int cpu)
{
- struct cpufreq_policy *policy __free(put_cpufreq_policy) = NULL;
unsigned long flags;
read_lock_irqsave(&cpufreq_driver_lock, flags);
@@ -1860,7 +1859,7 @@ unsigned int cpufreq_quick_get(unsigned
read_unlock_irqrestore(&cpufreq_driver_lock, flags);
- policy = cpufreq_cpu_get(cpu);
+ struct cpufreq_policy *policy __free(put_cpufreq_policy) = cpufreq_cpu_get(cpu);
if (policy)
return policy->cur;
@@ -1876,9 +1875,7 @@ EXPORT_SYMBOL(cpufreq_quick_get);
*/
unsigned int cpufreq_quick_get_max(unsigned int cpu)
{
- struct cpufreq_policy *policy __free(put_cpufreq_policy);
-
- policy = cpufreq_cpu_get(cpu);
+ struct cpufreq_policy *policy __free(put_cpufreq_policy) = cpufreq_cpu_get(cpu);
if (policy)
return policy->max;
@@ -1894,9 +1891,7 @@ EXPORT_SYMBOL(cpufreq_quick_get_max);
*/
__weak unsigned int cpufreq_get_hw_max_freq(unsigned int cpu)
{
- struct cpufreq_policy *policy __free(put_cpufreq_policy);
-
- policy = cpufreq_cpu_get(cpu);
+ struct cpufreq_policy *policy __free(put_cpufreq_policy) = cpufreq_cpu_get(cpu);
if (policy)
return policy->cpuinfo.max_freq;
@@ -1920,9 +1915,7 @@ static unsigned int __cpufreq_get(struct
*/
unsigned int cpufreq_get(unsigned int cpu)
{
- struct cpufreq_policy *policy __free(put_cpufreq_policy);
-
- policy = cpufreq_cpu_get(cpu);
+ struct cpufreq_policy *policy __free(put_cpufreq_policy) = cpufreq_cpu_get(cpu);
if (!policy)
return 0;
@@ -2751,9 +2744,7 @@ static void cpufreq_policy_refresh(struc
*/
void cpufreq_update_policy(unsigned int cpu)
{
- struct cpufreq_policy *policy __free(put_cpufreq_policy);
-
- policy = cpufreq_cpu_get(cpu);
+ struct cpufreq_policy *policy __free(put_cpufreq_policy) = cpufreq_cpu_get(cpu);
if (!policy)
return;
@@ -2770,9 +2761,7 @@ EXPORT_SYMBOL(cpufreq_update_policy);
*/
void cpufreq_update_limits(unsigned int cpu)
{
- struct cpufreq_policy *policy __free(put_cpufreq_policy);
-
- policy = cpufreq_cpu_get(cpu);
+ struct cpufreq_policy *policy __free(put_cpufreq_policy) = cpufreq_cpu_get(cpu);
if (!policy)
return;
@@ -3054,9 +3043,7 @@ static int __init cpufreq_core_init(void
static bool cpufreq_policy_is_good_for_eas(unsigned int cpu)
{
- struct cpufreq_policy *policy __free(put_cpufreq_policy);
-
- policy = cpufreq_cpu_get(cpu);
+ struct cpufreq_policy *policy __free(put_cpufreq_policy) = cpufreq_cpu_get(cpu);
if (!policy) {
pr_debug("cpufreq policy not set for CPU: %d\n", cpu);
return false;
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] cpufreq: core: Rearrange variable declarations involving __free()
2025-09-03 14:56 [PATCH v1] cpufreq: core: Rearrange variable declarations involving __free() Rafael J. Wysocki
@ 2025-09-03 15:08 ` Krzysztof Kozlowski
2025-09-04 4:14 ` Viresh Kumar
1 sibling, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2025-09-03 15:08 UTC (permalink / raw)
To: Rafael J. Wysocki, Linux PM; +Cc: LKML, Viresh Kumar, Zihuan Zhang
On 03/09/2025 16:56, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> Follow cleanup.h recommendations and always define and assign variables
> in one statement when __free() is used.
>
> No intentional functional impact.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] cpufreq: core: Rearrange variable declarations involving __free()
2025-09-03 14:56 [PATCH v1] cpufreq: core: Rearrange variable declarations involving __free() Rafael J. Wysocki
2025-09-03 15:08 ` Krzysztof Kozlowski
@ 2025-09-04 4:14 ` Viresh Kumar
2025-09-04 10:47 ` Zihuan Zhang
1 sibling, 1 reply; 4+ messages in thread
From: Viresh Kumar @ 2025-09-04 4:14 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: Linux PM, LKML, Krzysztof Kozlowski, Zihuan Zhang
On 03-09-25, 16:56, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> Follow cleanup.h recommendations and always define and assign variables
> in one statement when __free() is used.
>
> No intentional functional impact.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
> drivers/cpufreq/cpufreq.c | 27 +++++++--------------------
> 1 file changed, 7 insertions(+), 20 deletions(-)
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] cpufreq: core: Rearrange variable declarations involving __free()
2025-09-04 4:14 ` Viresh Kumar
@ 2025-09-04 10:47 ` Zihuan Zhang
0 siblings, 0 replies; 4+ messages in thread
From: Zihuan Zhang @ 2025-09-04 10:47 UTC (permalink / raw)
To: Viresh Kumar, Rafael J. Wysocki; +Cc: Linux PM, LKML, Krzysztof Kozlowski
> On 03-09-25, 16:56, Rafael J. Wysocki wrote:
>> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>>
>> Follow cleanup.h recommendations and always define and assign variables
>> in one statement when __free() is used.
>>
>> No intentional functional impact.
>>
>> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>> ---
>> drivers/cpufreq/cpufreq.c | 27 +++++++--------------------
>> 1 file changed, 7 insertions(+), 20 deletions(-)
>
>
Reviewd-by: Zihuan Zhang <zhangzihuan@kylinos.cn>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-09-04 10:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-03 14:56 [PATCH v1] cpufreq: core: Rearrange variable declarations involving __free() Rafael J. Wysocki
2025-09-03 15:08 ` Krzysztof Kozlowski
2025-09-04 4:14 ` Viresh Kumar
2025-09-04 10:47 ` Zihuan Zhang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).