From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E8903BD638 for ; Wed, 26 Aug 2026 09:24:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787736248; cv=none; b=NWZWLB8/aqWJwTFLzPsz9fKBhTbV6TaKb92IBzovceNmnoo2TmQnuBiI+PVvcvRYRqS7/JUuBoiUQd6pSwKBF4vRe8vPbPN8gNyuz1wYxfrqvUYS2B3/mxuoGf65rq2a2lFOci07ysLEhbHc4lFih3BBIZUrBNyXcYoFWxzF0Jk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787736248; c=relaxed/simple; bh=HqnDvKEanItWN4sZGrC35XsJJ1cF3PJL+CnWLNUiuN8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EeIGDinTjvPMh6D7VqWehOTYHehU0Q5fH1GcJU8ZY865nHTuKALQ2J4NXv5RpkFc90kN9zcWCn4y2ams/SD45QMzYPHNci+OQM4RtZm2eJUXabOZLa+Uu59qXKThFChWiLkuMGXX5xDrWB2renwLs/smU4SVTEdrJZ8ix07JKSQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=KyluUFwF; arc=none smtp.client-ip=209.85.208.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="KyluUFwF" Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-6a41191c9a9so795554a12.3 for ; Wed, 26 Aug 2026 02:24:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1787736245; x=1788341045; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=jCn0c8on5VhTMPvJMk79IvJUhN4ps8pLKsOfBaE2aTk=; b=KyluUFwFXoyN/tfgV/Tz4QF3bTjfmxkyRl/Sq65/7GnZ3UGKkb8obPY8gIl3nDJONZ XojL2AXT7C5nwlXXQNlUdbJPjkpz39mH6oX3gmcjSr0KsHQ7MmL1zeUC6YlufOS7IYNn CMzQ5/d06NOMJXrOpVeDxQ8M3u+2wGKmg9TFFdKp+F1sHH2lQS3vgXZ5OYz8k6njjY5w Yx3KAMNcp5/eVnqIYOKtSVzkm8YkAqnQLNdOpMDnmZRtCQsvyFjcvoyZ1A7Q9kTC+O4B rDF5dQF4dHOtEZtT5kiL8eLIYxMe0KTg31wcPJmi4O1cRbJYVXAyWStJ9bEXbsry6Emw Z6bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787736245; x=1788341045; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=jCn0c8on5VhTMPvJMk79IvJUhN4ps8pLKsOfBaE2aTk=; b=jQENfhBv7AZyula/OPIwGO1U3roQvx4hGBLeUDEX7zczDaqeJ5fItNVr+NbUqla6w/ U4yYZVmK85z6CxkVmzf0UpTXUu62JypjeMoZiPAU0RQ3kPWyJq1XB3RscJQXfLGfnmTi TkIkEYyuRi2rvdzMb8GnkouW8wqqlflui75Dkdiro6gU3JXv1PAvFVuPqvzb4vDiJTpx 3oXcoXAn68x2njH2UPmuds0sjRVrRPXGqCRvETsIoiZFoy34GKCtfrOqEVQghUkJtpgR 085/HzEy31Y947kWH25VOc/87ZIeMSfJl8pQFpcXw3RbIjjMiFzMsKg2pibkL1JciNeG 9u+Q== X-Forwarded-Encrypted: i=1; AHgh+RrklpbnH7Dn0TWW391DWON6K8a5xRp8imDQ9sXPQpd8S1YDVQX1NucbVsf8gMHxLVA4gGGrIjxVueuf6KA=@vger.kernel.org X-Gm-Message-State: AFuF++nwhjYFCudzsUa9qd2xobK3dvLOyyy1BDC3XWsJ+BVkUd/iSafJ 3OY2UhqBuCeJvg7TcLEvAx4SeMqqcNRsL8NSOxlLlZk28tHcHPs7rlwslj4ygon9niA= X-Gm-Gg: AR+sD13d32FN1IIwGBijg3oc2OS0HFtYjUd/+In/dEsbnguW7qO3oYb1H3aM5decsDP idK1iipiG9QkMmD5sJ/bZRH6pWbd+qsT9UrG6p6Y8ZqmDnDOo7U37gYd1jB9DgMCb5YOTUdoLJD YO2nC2V2djqveR13E3Ln5vfU/aJMrNxJvDdlUZuv8Iz+lD/qFs8R7tX8zwFphmJgD7eqlahO23X /uFpAdfgjCOhMR+Frd009PAVccgrGChPwJJwO+brUdRIpbYYGFUHjzWbNKbh5002I3pi3nOdE+1 BP9OXqo7v7bAlaoM8+zcXql24hRFtcgDC6zrj3SoOdFlnTIgqMifdIuRfh7Q4xexBSml0XxSceG /G1Hk5C1OQXf1Fv0FhejM93uTLcOQljaD8fwDEUkMovGtmE93HZ8s1OaJ3zXnaUNTjCWaz8wEP/ nEzMK4nQ2gnIsDFB2yxh8/imcG+xmkcjaQAaRkrOyi1EsaHZP4zGKl6FzfLuXeecCdToeiClnfN YaEbCWSttaYshJwz7kVMmtl X-Received: by 2002:a17:907:8749:b0:c25:2fb5:e572 with SMTP id a640c23a62f3a-c252fb5efa7mr36929566b.23.1787736244662; Wed, 26 Aug 2026 02:24:04 -0700 (PDT) Received: from ?IPV6:2a07:de40:8100:0:fc6c:f9a2:4a0a:6354? ([2001:af0:8000:1409:193:86:92:181]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a5dea83a25sm3726306a12.18.2026.08.26.02.24.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Aug 2026 02:24:04 -0700 (PDT) Message-ID: Date: Wed, 26 Aug 2026 11:24:03 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] module: fix lost error code from codetag_load_module() To: Hao Ge Cc: Suren Baghdasaryan , Andrew Morton , Luis Chamberlain , Daniel Gomez , Sami Tolvanen , Aaron Tomlin , linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org, Sashiko , stable@vger.kernel.org References: <20260824014736.35026-1-hao.ge@linux.dev> Content-Language: en-US From: Petr Pavlu In-Reply-To: <20260824014736.35026-1-hao.ge@linux.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/24/26 3:47 AM, Hao Ge wrote: > If codetag_load_module() fails, err is never set and load_module() > returns 0 after the module has been torn down. > > Fixes: 044d2aee6c57 ("alloc_tag: handle module codetag load errors as module load failures") > Reported-by: Sashiko > Cc: stable@vger.kernel.org > Signed-off-by: Hao Ge > --- > kernel/module/main.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/kernel/module/main.c b/kernel/module/main.c > index 46dd8d25a605..afb810f0154c 100644 > --- a/kernel/module/main.c > +++ b/kernel/module/main.c > @@ -3568,7 +3568,8 @@ static int load_module(struct load_info *info, const char __user *uargs, > goto sysfs_cleanup; > } > > - if (codetag_load_module(mod)) > + err = codetag_load_module(mod); > + if (err) > goto sysfs_cleanup; > > /* Get rid of temporary copy. */ This looks ok to me but there appears another bug related to this code that would be good to fix at the same time. If the module is a livepatch, the preceding call to copy_module_elf() allocates mod->klp_info. However, if codetag_load_module() fails, the code doesn't free it. I think we want something like this (not tested): diff --git a/kernel/module/main.c b/kernel/module/main.c index d0e1e0bd2ad0..c1b34dc1e89a 100644 --- a/kernel/module/main.c +++ b/kernel/module/main.c @@ -3581,8 +3581,9 @@ static int load_module(struct load_info *info, const char __user *uargs, goto sysfs_cleanup; } - if (codetag_load_module(mod)) - goto sysfs_cleanup; + err = codetag_load_module(mod); + if (err) + goto livepatch_cleanup; /* Get rid of temporary copy. */ free_copy(info, flags); @@ -3592,6 +3593,9 @@ static int load_module(struct load_info *info, const char __user *uargs, return do_init_module(mod); + livepatch_cleanup: + if (is_livepatch_module(mod)) + free_module_elf(mod); sysfs_cleanup: mod_sysfs_teardown(mod); coming_cleanup: -- Thanks, Petr