From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4983E1A315C for ; Wed, 17 Sep 2025 19:05:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758135953; cv=none; b=j64OKzvS/g2+XRynTir6hsenuRoVpyaKpNdzcfJ58lK2jyVdluBkeuS6yJjxSBfZLWnolubpiFzS0kESYUH1cZvOzDVzG7sQWlEB35sr7L0Gz0j0/OfsT+wXSot9C8Ct4nLjMFXiFVJsaCCpqs06xznkXr6WSJfXhwUcxsVz8sw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758135953; c=relaxed/simple; bh=4r3OnglhmQv5f95g1m3EPAqqkjghukFweMHUd+HyG0k=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=aeocy6Ev1K7118FZTgbcMj1FyMigENQdBEuXbB5SibnDtQwF6tF+53vBYsgXD3XGDnaGEiy+1WCQrcyy9LPkQjl7SsnhdZHFArBK7lh+zz+j1sNJrgitLtwEFTuxFRCBTG/qZC8U9IfTQGkcHz+/83jv4ORmSWm7ME8KQ9FPRm0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=G1RiB5ql; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="G1RiB5ql" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758135951; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=iYdTqhfdz9F3OSmNWg0L2Bcl9ZF1XfZz244Dszls6io=; b=G1RiB5qlvpnPm6CnS1p3/Xs5XNpJEOAaEhdCFOl6Hfj4bLQ7nRD8r7+zwF3WudFJseFC1Q sAv9F3/zvCkngIkJ6QTIEItfCz5Bu564U8MZQ63JS24oTwZhvW6cBGSA7evrjpJrxL9FsI y5t47PTIieTv10idDoIaei/kKAg9HCM= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-541-ee87USS9N3CMNWZwWOxY_Q-1; Wed, 17 Sep 2025 15:05:49 -0400 X-MC-Unique: ee87USS9N3CMNWZwWOxY_Q-1 X-Mimecast-MFC-AGG-ID: ee87USS9N3CMNWZwWOxY_Q_1758135949 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3df07c967e9so21184f8f.2 for ; Wed, 17 Sep 2025 12:05:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758135949; x=1758740749; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=iYdTqhfdz9F3OSmNWg0L2Bcl9ZF1XfZz244Dszls6io=; b=Jfbyp8jv+b7fPGDhLDf7KPEBDITWggBcl8hs848AxL32JLjFXsqXWJXFt3rmKNm542 +4IwaGpwHQZpUK1S6sgnWXohVDPkmhQHoiPLuWr/j+/PKHGhnrsKLhtSitkosS+lSVPt 4HY5fVasjd/zwxa4/UDY4bMcphsIxiN+m58Lmh0RRy+RyuKh5NW3A0Skm4jFpN3rA+LO cudSBTdlMYsAkxXhDXWLDM8ejQRB1t6VW3HzFJKDjqKADnxSdTgFd6pWN9OrYNAgeY/e Jq/akk1ByaiBt4CBmNy7QuuGLXrsG6sDcn17wP0kHMMkQ96GZeNOIN3/Ry8NVNSkgsKE P3FA== X-Forwarded-Encrypted: i=1; AJvYcCUjP7elvHurB5mld5Wr06tpnmlBAZpu6LKT64X2DwOuDQVxp/Yu4nkECfVAkZ9krdVXQdcIsuG26ilmgNQ=@vger.kernel.org X-Gm-Message-State: AOJu0Ywy9omSgdj3XYtvaqW64cjce2JWZOyzACW7hsMmlZUW0Z1Kv3aN Sbd5j8SoIg4RaG+KiaVeFODu8ehLw5r+pVsqLl2LWIy/dZlbaNwfC8OIDZGA9G0+oN33C0YY6XC pWiznVA+nE9uTBRtA8Y3w+l2the6FSij0TC/GUkJ+3PZqBh5SQCveaKYbP7ifqGPAsw== X-Gm-Gg: ASbGnctsWBXBwPXBVgOmd5s30hqYsO0JCbaMgyKdXRcIak4OQCTKUEdaMMHAxUOqta4 +Ly9du6kCtjY/VRTt3nWfu2pc+psyka/1BP5BbxndwYMS/i/Ycrx0EpciCKFwnSzQv4MHKUeZJL hah0bFGrAkVP90Q2K38nlKXki/2R1k/aH8Jw5Ps1GmlOsg9qjzIvKvYAdO3ysUq1eXJr92KmJVG QwdnOjxdP4moB8qGsvQXFz1JthQis0eRGjuGd5ThAUg4+b55YD/aVWQ304bewibNnEW/2OREW7v LmjRwvdGgOJ6ubvjseZV8Mux13cyzAWhZkUrqjhvRnobclnRiSW/ghzT5Rlcut1E5Jao3/r5NbP z7waUgkUimj+Zv98QRvD8h37thjQ2KFk8H04oY45YrYSnCoxyfhIUQuuStikiUZTv X-Received: by 2002:a5d:64c8:0:b0:3ea:e0fd:290b with SMTP id ffacd0b85a97d-3ecdfa0d2f1mr3067884f8f.40.1758135948732; Wed, 17 Sep 2025 12:05:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHkB9K5+m3ks5tDl26fGtwUBcSZFKAuJY0U4QfQl4kZMxsZJ5NivU//n+3kzLJsG+tBhuQWwg== X-Received: by 2002:a5d:64c8:0:b0:3ea:e0fd:290b with SMTP id ffacd0b85a97d-3ecdfa0d2f1mr3067845f8f.40.1758135948270; Wed, 17 Sep 2025 12:05:48 -0700 (PDT) Received: from ?IPV6:2003:d8:2f27:6d00:7b96:afc9:83d0:5bd? (p200300d82f276d007b96afc983d005bd.dip0.t-ipconnect.de. [2003:d8:2f27:6d00:7b96:afc9:83d0:5bd]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3ee07412111sm453030f8f.28.2025.09.17.12.05.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Sep 2025 12:05:47 -0700 (PDT) Message-ID: Date: Wed, 17 Sep 2025 21:05:44 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm/memory-failure: Support disabling soft offline for HugeTLB pages To: Kyle Meyer Cc: Anshuman Khandual , akpm@linux-foundation.org, corbet@lwn.net, linmiaohe@huawei.com, shuah@kernel.org, tony.luck@intel.com, jane.chu@oracle.com, jiaqiyan@google.com, Liam.Howlett@oracle.com, bp@alien8.de, hannes@cmpxchg.org, jack@suse.cz, joel.granados@kernel.org, laoar.shao@gmail.com, lorenzo.stoakes@oracle.com, mclapinski@google.com, mhocko@suse.com, nao.horiguchi@gmail.com, osalvador@suse.de, rafael.j.wysocki@intel.com, rppt@kernel.org, russ.anderson@hpe.com, shawn.fan@intel.com, surenb@google.com, vbabka@suse.cz, linux-acpi@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org References: <8c3188da-7078-4099-973a-1d0d74db2720@redhat.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZoEEwEIAEQCGwMCF4ACGQEFCwkIBwICIgIG FQoJCAsCBBYCAwECHgcWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaJzangUJJlgIpAAKCRBN 3hD3AP+DWhAxD/9wcL0A+2rtaAmutaKTfxhTP0b4AAp1r/eLxjrbfbCCmh4pqzBhmSX/4z11 opn2KqcOsueRF1t2ENLOWzQu3Roiny2HOU7DajqB4dm1BVMaXQya5ae2ghzlJN9SIoopTWlR 0Af3hPj5E2PYvQhlcqeoehKlBo9rROJv/rjmr2x0yOM8qeTroH/ZzNlCtJ56AsE6Tvl+r7cW 3x7/Jq5WvWeudKrhFh7/yQ7eRvHCjd9bBrZTlgAfiHmX9AnCCPRPpNGNedV9Yty2Jnxhfmbv Pw37LA/jef8zlCDyUh2KCU1xVEOWqg15o1RtTyGV1nXV2O/mfuQJud5vIgzBvHhypc3p6VZJ lEf8YmT+Ol5P7SfCs5/uGdWUYQEMqOlg6w9R4Pe8d+mk8KGvfE9/zTwGg0nRgKqlQXrWRERv cuEwQbridlPAoQHrFWtwpgYMXx2TaZ3sihcIPo9uU5eBs0rf4mOERY75SK+Ekayv2ucTfjxr Kf014py2aoRJHuvy85ee/zIyLmve5hngZTTe3Wg3TInT9UTFzTPhItam6dZ1xqdTGHZYGU0O otRHcwLGt470grdiob6PfVTXoHlBvkWRadMhSuG4RORCDpq89vu5QralFNIf3EysNohoFy2A LYg2/D53xbU/aa4DDzBb5b1Rkg/udO1gZocVQWrDh6I2K3+cCs7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 17.09.25 20:51, Kyle Meyer wrote: > On Wed, Sep 17, 2025 at 09:02:55AM +0200, David Hildenbrand wrote: >> >>>> + >>>> + 0 - Enable soft offline >>>> + 1 - Disable soft offline for HugeTLB pages >>>> + >>>> +Supported values:: >>>> + >>>> + 0 - Soft offline is disabled >>>> + 1 - Soft offline is enabled >>>> + 3 - Soft offline is enabled (disabled for HugeTLB pages) >>> >>> This looks very adhoc even though existing behavior is preserved. >>> >>> - Are HugeTLB pages the only page types to be considered ? >>> - How the remaining bits here are going to be used later ? >>> >> >> What I proposed (that could be better documented here) is that all other >> bits except the first one will be a disable mask when bit 0 is set. >> >> 2 - ... but yet disabled for hugetlb >> 4 - ... but yet disabled for $WHATEVER >> 8 - ... but yet disabled for $WHATEVERELSE >> >>> Also without a bit-wise usage roadmap, is not changing a procfs >>> interface (ABI) bit problematic ? >> >> For now we failed setting it to values that are neither 0 or 1, IIUC >> set_enable_soft_offline() correctly? > > Yes, -EINVAL will be returned. > >> So there should not be any problem, or which scenario do you have in mind? > > Here's an alternative approach. > > Do not modify the existing sysctl parameter: > > /proc/sys/vm/enable_soft_offline > > 0 - Soft offline is disabled > 1 - Soft offline is enabled > > Instead, introduce a new sysctl parameter: > > /proc/sys/vm/enable_soft_offline_hugetlb > > 0 - Soft offline is disabled for HugeTLB pages > 1 - Soft offline is enabled for HugeTLB pages > > and note in documentation that this setting only takes effect if > enable_soft_offline is enabled. > > Anshuman (and David), would you prefer this? Hmm, at least I don't particularly like that. For each new exception we would create a new file, and the file has weird semantics such that it has no meaning when enable_soft_offline=0. -- Cheers David / dhildenb