From: Denis Efremov <efremov@linux.com>
To: Paul Burton <paul.burton@mips.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
"David S. Miller" <davem@davemloft.net>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Ralf Baechle <ralf@linux-mips.org>,
James Hogan <jhogan@kernel.org>, Michal Simek <monstr@monstr.eu>,
"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"sparclinux@vger.kernel.org" <sparclinux@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [EXTERNAL][PATCH 1/5] PCI: Convert pci_resource_to_user to a weak function
Date: Mon, 29 Jul 2019 13:06:19 +0300 [thread overview]
Message-ID: <cd83d298-45f6-7330-0347-96025cde8959@linux.com> (raw)
In-Reply-To: <20190728224953.kezztdozc6k24ya3@pburton-laptop>
Hi Paul,
On 29.07.2019 01:49, Paul Burton wrote:
> Hi Denis,
>
> This is wrong - using __weak on the declaration in a header will cause
> the weak attribute to be applied to all implementations too (presuming
> the C files containing the implementations include the header). You then
> get whichever impleentation the linker chooses, which isn't necessarily
> the one you wanted.
Thank you for pointing me on that. I will prepare the v2.
next prev parent reply other threads:[~2019-07-29 10:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-28 20:22 [PATCH 0/5] PCI: Convert pci_resource_to_user() to a weak function Denis Efremov
2019-07-28 20:22 ` [PATCH 1/5] PCI: Convert pci_resource_to_user " Denis Efremov
2019-07-28 22:49 ` [EXTERNAL][PATCH " Paul Burton
2019-07-29 6:31 ` Joe Perches
2019-07-29 10:06 ` Denis Efremov [this message]
2019-07-28 20:22 ` [PATCH 2/5] microblaze/PCI: Remove HAVE_ARCH_PCI_RESOURCE_TO_USER Denis Efremov
2019-07-28 20:22 ` [PATCH 3/5] mips/PCI: " Denis Efremov
2019-07-28 20:22 ` [PATCH 4/5] powerpc/PCI: " Denis Efremov
2019-07-28 20:22 ` [PATCH 5/5] spark/PCI: " Denis Efremov
2019-07-28 20:25 ` John Paul Adrian Glaubitz
2019-07-28 21:17 ` Denis Efremov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd83d298-45f6-7330-0347-96025cde8959@linux.com \
--to=efremov@linux.com \
--cc=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=davem@davemloft.net \
--cc=jhogan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=monstr@monstr.eu \
--cc=mpe@ellerman.id.au \
--cc=paul.burton@mips.com \
--cc=paulus@samba.org \
--cc=ralf@linux-mips.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox