From: Florian Fainelli <f.fainelli@gmail.com>
To: Doug Berger <opendmb@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>
Cc: bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 1/7] net: bcmgenet: set Rx mode before starting netif
Date: Wed, 29 Apr 2020 14:21:34 -0700 [thread overview]
Message-ID: <cdc08d25-eafa-9b14-62b6-20d95c0c1866@gmail.com> (raw)
In-Reply-To: <1588190526-2082-2-git-send-email-opendmb@gmail.com>
On 4/29/20 1:02 PM, Doug Berger wrote:
> This commit explicitly calls the bcmgenet_set_rx_mode() function when
> the network interface is started. This function is normally called by
> ndo_set_rx_mode when the flags are changed, but apparently not when
> the driver is suspended and resumed.
>
> This change ensures that address filtering or promiscuous mode are
> properly restored by the driver after the MAC may have been reset.
>
> Fixes: b6e978e50444 ("net: bcmgenet: add suspend/resume callbacks")
> Signed-off-by: Doug Berger <opendmb@gmail.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2020-04-29 21:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 20:01 [PATCH net-next v2 0/7] net: bcmgenet: add support for Wake on Filter Doug Berger
2020-04-29 20:02 ` [PATCH net-next v2 1/7] net: bcmgenet: set Rx mode before starting netif Doug Berger
2020-04-29 21:21 ` Florian Fainelli [this message]
2020-04-29 20:02 ` [PATCH net-next v2 2/7] net: bcmgenet: Fix WoL with password after deep sleep Doug Berger
2020-04-29 21:22 ` Florian Fainelli
2020-04-29 20:02 ` [PATCH net-next v2 3/7] net: bcmgenet: move clk_wol management to bcmgenet_wol Doug Berger
2020-04-29 21:34 ` Florian Fainelli
2020-04-29 20:02 ` [PATCH net-next v2 4/7] Revert "net: bcmgenet: remove unused function in bcmgenet.c" Doug Berger
2020-04-29 21:34 ` Florian Fainelli
2020-04-29 20:02 ` [PATCH net-next v2 5/7] net: bcmgenet: code movement Doug Berger
2020-04-29 21:34 ` Florian Fainelli
2020-04-29 20:02 ` [PATCH net-next v2 6/7] net: bcmgenet: add support for ethtool rxnfc flows Doug Berger
2020-04-29 21:47 ` Florian Fainelli
2020-04-29 20:02 ` [PATCH net-next v2 7/7] net: bcmgenet: add WAKE_FILTER support Doug Berger
2020-04-29 21:48 ` Florian Fainelli
2020-04-29 22:07 ` [PATCH net-next v2 0/7] net: bcmgenet: add support for Wake on Filter Doug Berger
2020-04-29 23:00 ` Doug Berger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cdc08d25-eafa-9b14-62b6-20d95c0c1866@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox