From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32BDD3D6CC2 for ; Fri, 24 Apr 2026 13:30:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777037422; cv=none; b=VaZ7OXOV1s06T7ze3gjgdpxokY7HQMhRA9hnfva1yO5/esCOqyIlNiCMBYtj3yqV7Nd5ra7vWExGF+jp8AwL+D+PFxzXGJp2wKIXt+LJ4aCRNoeh/YqbhW4I8jL6AMsU6FKgymxCYOJ3fcaVhK0aI9VFaPi0foGJj2RU7bigyEY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777037422; c=relaxed/simple; bh=6xx/cqSPmGGq5SiVIeMj63/5yGyjb6+6H5Qsk2Hj8Ew=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=L6ZYbPcpn+ZfS/FKB+TCQ1+l6H77OJfnNBkkVCu2QBCV4o/Q7WHtAIpT7XW7aVye8npvV9a/CysEAgSVYDpkVTlnF3bZnBWewrNP4tEhL9RYRpUqndetO6HABHWXN2Ft5DiZTULqaEuaggUVR2LS1FEU9QVHyYUTjyJnwBrt03U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KHv26dpB; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KHv26dpB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 78A69C19425; Fri, 24 Apr 2026 13:30:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777037421; bh=6xx/cqSPmGGq5SiVIeMj63/5yGyjb6+6H5Qsk2Hj8Ew=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=KHv26dpBitAOieQFueRFmWncLQ61m6IeEZIKgZGW5cfMLFC2FizUtSyVSr3J3+joD ORGEljE9Gy63Lpy9zlbW9maKXl06uhKwbAcivaIho1Tj85lhrCFx5Xkum1u/gqbEYp H+0ljf9900HdWdmDHVeujr5AI5FwllkyXy8jFgVnEP88VUm4rjGaR4+Lsw0QvsQEZZ K9h7gX7yMcNJWfPw5AnshjEuE3D6My4ZS5XSbqwHkSF3k5D9HbFwzrOkrizCpkJHWw E0vUzeH9sRfRo+uphqmV+prYFW7qBkMNv/0Y06MIqQ52XdBE4R/s9bnmjmiyJeP0Gd KQXW7PZ19w1eQ== Message-ID: Date: Fri, 24 Apr 2026 08:30:19 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V1 3/3] accel/amdxdna: Set the system efficiency factor to 2 Content-Language: en-US To: Lizhi Hou , ogabbay@kernel.org, quic_jhugo@quicinc.com, dri-devel@lists.freedesktop.org, maciej.falkowski@linux.intel.com Cc: Nishad Saraf , linux-kernel@vger.kernel.org, max.zhen@amd.com, sonal.santan@amd.com References: <20260424040824.2253607-1-lizhi.hou@amd.com> <20260424040824.2253607-3-lizhi.hou@amd.com> From: Mario Limonciello In-Reply-To: <20260424040824.2253607-3-lizhi.hou@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/23/26 23:08, Lizhi Hou wrote: > From: Nishad Saraf > > The system efficiency factor is used for QoS calculation. Change it to 2 > to account for the efficiency overhead. > > Signed-off-by: Nishad Saraf > Signed-off-by: Lizhi Hou Reviewed-by: Mario Limonciello (AMD) > --- > drivers/accel/amdxdna/aie2_pci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/accel/amdxdna/aie2_pci.c b/drivers/accel/amdxdna/aie2_pci.c > index a07e453a1721..f0ddb843eb21 100644 > --- a/drivers/accel/amdxdna/aie2_pci.c > +++ b/drivers/accel/amdxdna/aie2_pci.c > @@ -595,7 +595,7 @@ static int aie2_init(struct amdxdna_dev *xdna) > xrs_cfg.clk_list.num_levels = ndev->max_dpm_level + 1; > for (i = 0; i < xrs_cfg.clk_list.num_levels; i++) > xrs_cfg.clk_list.cu_clk_list[i] = ndev->priv->dpm_clk_tbl[i].hclk; > - xrs_cfg.sys_eff_factor = 1; > + xrs_cfg.sys_eff_factor = 2; > xrs_cfg.ddev = &xdna->ddev; > xrs_cfg.actions = &aie2_xrs_actions; > xrs_cfg.total_col = ndev->total_col;