From: Paul Moore <paul@paul-moore.com>
To: Eric Dumazet <edumazet@google.com>,
Casey Schaufler <casey@schaufler-ca.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org, Eric Dumazet <eric.dumazet@gmail.com>,
Eric Dumazet <edumazet@google.com>,
syzbot+bb185b018a51f8d91fd2@syzkaller.appspotmail.com,
Eric Paris <eparis@redhat.com>,
audit@vger.kernel.org
Subject: Re: [PATCH] audit: init ab->skb_list earlier in audit_buffer_alloc()
Date: Thu, 04 Sep 2025 11:06:31 -0400 [thread overview]
Message-ID: <cde565adc43452e83958fbe0ab54080d@paul-moore.com> (raw)
In-Reply-To: <20250904072537.2278210-1-edumazet@google.com>
On Sep 4, 2025 Eric Dumazet <edumazet@google.com> wrote:
>
> syzbot found a bug in audit_buffer_alloc() if nlmsg_new() returns NULL.
>
> We need to initialize ab->skb_list before calling audit_buffer_free()
> which will use both the skb_list spinlock and list pointers.
>
> Fixes: eb59d494eebd ("audit: add record for multiple task security contexts")
> Reported-by: syzbot+bb185b018a51f8d91fd2@syzkaller.appspotmail.com
> Closes: https://lore.kernel.org/lkml/68b93e3c.a00a0220.eb3d.0000.GAE@google.com/T/#u
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Casey Schaufler <casey@schaufler-ca.com>
> Cc: Paul Moore <paul@paul-moore.com>
> Cc: Eric Paris <eparis@redhat.com>
> Cc: audit@vger.kernel.org
> ---
> kernel/audit.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Thanks Eric, merged into audit/dev.
--
paul-moore.com
prev parent reply other threads:[~2025-09-04 15:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-04 7:25 [PATCH] audit: init ab->skb_list earlier in audit_buffer_alloc() Eric Dumazet
2025-09-04 15:06 ` Paul Moore [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cde565adc43452e83958fbe0ab54080d@paul-moore.com \
--to=paul@paul-moore.com \
--cc=audit@vger.kernel.org \
--cc=casey@schaufler-ca.com \
--cc=edumazet@google.com \
--cc=eparis@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=syzbot+bb185b018a51f8d91fd2@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox