From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A125C33290F for ; Thu, 27 Nov 2025 14:12:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764252737; cv=none; b=T/Em+1YvIUKdLZ0rvcIv4H9NWIigN5GayVaSSWMT2URHOcgqc7rOWYPU3cdBDsGMQ+Y4uQ8Sn6PhnRyXbkfD84zxza45OeYaatK2qcqRY8rBrUhYzGQAAQJyWWnXCqOKYpurX82qCIYRjSftYqQgBlwpRf8kXbhMDfulUBmrIPc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764252737; c=relaxed/simple; bh=lPbejQRzLGwK7I1gopu3GY5ha7xC6bHJ9U4GIaoCZNU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UyyDjgy1y9TJGKkAuKIVwsxvlItV4bO9RXHeKQNTABg6K9HZrsKmcx+SEAbGrfNUYG2sG9EqiTkxx222KM/gFxouOOQkNDETRyhbCjmFZOHZhjQdjNebJrBmsEwluxpygMlwJ/6BxvKcE9qIQmCgAsheQU/7o2XNPAneq/svKiQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=A0N1gQMm; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=R4zjXlja; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="A0N1gQMm"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="R4zjXlja" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AR9slJe3840449 for ; Thu, 27 Nov 2025 14:12:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= fCiYRHPq3rlvKmF8kWI43Q2cFwW+J8eYLT37CyJ1pt8=; b=A0N1gQMm7AHEOGho fZk5FoOnO2+O0SloBk+NsTwB2zW7qUOxS1QSUsx5/9bkx4aANfbc4Q6RDYGFfzqi cz10Pi5o/vVk9yJXWr/VJMFPYYrZvGsG827i/ZQqbPbA/7vq+josK2xxx4AzjniA Dkq6vm+qGtLgYVZ5NXhT/3VkHJxqxxLBsOt1OgLCHy4O7FoOJuz7cfQBJAknIhjX v7BmEU4+mIr3u3Nx+dDDwqUtRMdg/sIzCbhZzO6gSjUJLXcq6xjTrdmPEdJIKaEq SmXyEMkoFYfv+ZGrIVGJIbFlBiDOIB843VOazVfSv6W460R/BaB4kM1sq84J/3ba gEgvKw== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4apdj09vgn-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 27 Nov 2025 14:12:14 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-4ee07f794fcso1572881cf.2 for ; Thu, 27 Nov 2025 06:12:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764252734; x=1764857534; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fCiYRHPq3rlvKmF8kWI43Q2cFwW+J8eYLT37CyJ1pt8=; b=R4zjXljaKrplvRi0fRetIL0D4Fcfjw6b/bwiUEU2ozgj8654kDi4ucHJZKJGnsriAS Ek/JNIp/J5Ag5aYJ/nDhOvf5uuH7PPPLezBjrE6sgDylxwmUgzwpCmuXixyYOppVDD2h ADdtdknjJcKyszbOKp1A98E2glx959s5tu8BiSbzjgNCOVLd5jLQc37rAgU4B9EiJCwZ ObJZa1/RtvOOPnwEI+kHZtqfTjWdp2J51Pf+to+z2HJx7Q+Lrq5XWqwCHOR0vO0Munte d16KeLXZB/BxLk7yHnsgRQPSW15/hKc4J2DTqkPkf+bgXY90F2Y4stzVMdQcIkoQRhcK UYcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764252734; x=1764857534; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=fCiYRHPq3rlvKmF8kWI43Q2cFwW+J8eYLT37CyJ1pt8=; b=Fu+RY2EKtL/kHyTTRWBwYO10uPGoakjLlrlC7/oDgO5Ts3wFHspTgmqz2B/pWMvBFR YqRJWeVat3YMK/1u38cKEa1bSZJMrPVdVoODMjYkh1eNI61egel+gbLgTfXS94TXGj6e FOzZot0EZ8WEAuxW3SesEuxxP+k7dYbylPzeRmiajb1EQH/ri6GpkqITnTifs+XVwQXN tpzNDfTZJAJANRKbWdd8810cumfcFqquSh+bTYw668ZiL6m9fcyQtig2vh7UPyEmRqRE /lOoQFzTF9YfOQEFpH/nzPJD1RJEnkyHguFV9/0uPhtd7sEgM5buS6pQzEpCqJ2UwMrV 4r1Q== X-Forwarded-Encrypted: i=1; AJvYcCWTD/nRCx8ey8Pp6fEutqDc++6YmN2g8Z6oAMK5NccOtxLUQr+31MZgNtSssktFpVcj4KTocqacDtBiSaQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yxh+tVdlT6H7jEb7DF157hLS93GLcrEVosBY12aYGU96QrAdgsh H8T2gKTuagFOJym/LXbH2ar+1WC23WHBz8nlC2sxqShhsFbselIevsghvmYD8mQE6RecTe2Kc5y qcs180g73TJpkPXcVQinwpRFOVad6WiWl7sw/Mjl7zanZUNj6fJpjqQO+q3rl7UenWKU= X-Gm-Gg: ASbGncueNOyUSfJpVQUUtMZGi+f7QLyAcmUydNwFYaJqYBX1IL3ZZ98Xu3UgbQ/g6e6 DW+a+WG/pFZNNOX1PvIdCvUlf7WE8E/WXwI6d7IpgGDBlgw7/eyFW9Dga4X/x3iAU0A0oNTDVA6 JoKN0C2BCbTLqs2kMFhmqmhoY3PGBUqQ2uCz+e5U+TRcH4UZ2UkybNDrqXR56OUqW7joUjIQrMF /OULtwdLfBjT/NaOAWBcjYFvc8Z0YHhFeRVWrienNKM/H9k3Z5eXeoP9evH1vAoRnoDxnlQH/qZ 1XQTtxgU+RvRa7l5aOj+Ui7jmTb2pwq1To38egD31j/YVaTDOZi/qfonRgMVMcbuBLyieScg5+b GEP8J9SbBTCC2Vei5w22KDqEKfS+n2DSryMCe/Y+Kj426Is4IxPUuyy+UdfLD+1yTIHg= X-Received: by 2002:a05:622a:144d:b0:4ee:2638:ea2 with SMTP id d75a77b69052e-4ee58930d72mr245470301cf.9.1764252732218; Thu, 27 Nov 2025 06:12:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IHAENiG2NWzvRUpC2N3DyEf6LKMfN1Rk9Nazrw11y8MKYBoWmJU39W3UKHkR1LhJjRLAlv1gQ== X-Received: by 2002:a05:622a:144d:b0:4ee:2638:ea2 with SMTP id d75a77b69052e-4ee58930d72mr245469471cf.9.1764252731408; Thu, 27 Nov 2025 06:12:11 -0800 (PST) Received: from [192.168.119.202] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-64751062081sm1632438a12.34.2025.11.27.06.12.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Nov 2025 06:12:10 -0800 (PST) Message-ID: Date: Thu, 27 Nov 2025 15:12:08 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] PCI: qcom: Clear ASPM L0s CAP for MSM8996 SoC To: Manivannan Sadhasivam Cc: Manivannan Sadhasivam , lpieralisi@kernel.org, kwilczynski@kernel.org, bhelgaas@google.com, robh@kernel.org, linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov References: <20251126081718.8239-1-mani@kernel.org> <7rmiof6lxrr27vd4rnilc6ynxj7c2eiv33uw62lt4sheylpjny@6m2nuqnbnifc> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <7rmiof6lxrr27vd4rnilc6ynxj7c2eiv33uw62lt4sheylpjny@6m2nuqnbnifc> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTI3MDEwNSBTYWx0ZWRfX6mj9quALos7E B0wRH+u2N+B7yzJB1o2149aQ0uASxyREAkSY+HbgR25KytbxHadH9K4ZSz+1VfHCHoSyJxQ6oRf cdqdURBQN9Gtw27qUhbkQ63SG211Op6gwTeTKrYJEi/gQGVY7cynbHA6y0QIQEJS2YEt903jrhf LtpSlzG7KDewUeR7kdJ0Ykz1yXG1SbjjevUz0qZBk3TotdqNDbj0JnOM5LqCXK0PywDCFFaGq8T fZKW/gbRJH8wxf82I6VOCZ5MPwAMOECBw9T4myLIVptKpkzJ4ta6OiqYCCRriW7+riPvkZKaA02 IeiMqJMiAIoLqy7w6JFZ4S5CwmtIuuLqgQCC6MM6SzyyqRvmm7NcRr80vLonuGk8lFPTzr4/k0s fS0SeaO07M6kueH7UC2bpjVgKlyvfQ== X-Proofpoint-GUID: U_QpukqC4gVIrszHQQX1ltGGKZaNd4r4 X-Proofpoint-ORIG-GUID: U_QpukqC4gVIrszHQQX1ltGGKZaNd4r4 X-Authority-Analysis: v=2.4 cv=PJoCOPqC c=1 sm=1 tr=0 ts=69285c3e cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=BQ-7DGIy8I7IhXLRZ7wA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-25_02,2025-11-27_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 lowpriorityscore=0 suspectscore=0 phishscore=0 priorityscore=1501 clxscore=1015 adultscore=0 impostorscore=0 malwarescore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511270105 On 11/27/25 2:55 PM, Manivannan Sadhasivam wrote: > On Thu, Nov 27, 2025 at 11:55:15AM +0100, Konrad Dybcio wrote: >> On 11/26/25 9:17 AM, Manivannan Sadhasivam wrote: >>> From: Manivannan Sadhasivam >>> >>> Though I couldn't confirm the ASPM L0s support with the Qcom hardware team, >>> bug report from Dmitry suggests that L0s is broken on this legacy SoC. >>> Hence, clear the L0s CAP for the Root Ports in this SoC. >> >> FWIW if we trust the downstream DT, we have this hunk: >> >> arch/arm64/boot/dts/qcom/msm8996.dtsi >> 1431: qcom,l1-supported; >> 1432: qcom,l1ss-supported; >> 1586: qcom,l1-supported; >> 1587: qcom,l1ss-supported; >> 1739: qcom,l1-supported; >> 1740: qcom,l1ss-supported; >> >> But also funnily enough, msm8996auto boards specifically manually >> do a /delete-property/ on those.. >> >> (there exists one 'qcom,l0s-supported', but it's NOT set for 8996, 98, >> or 845) >> >> On msm-4.14, this became "qcom,no-l0s/l1/l1ss-supported". This forbids L0s >> on at least 8150 and 8250. >> >> Later, both hosts on SM8350 and SM8450-PCIe0 (not 1) forbid L0s. >> > > Thanks for digging in. Unfortunately, I have to rely on word of mouth to get the > ASPM capability as there is no proper doc that says which SoC supports which > state. And, I'm quite nervous to trust downstream DTS as they were not very > accurate in describing the hardware capabilities. But I think we should atleast > consider the 'no-l0s' properties seriously. > > Let me go through all DTS and build try to build a sane ASPM compatibility > table. But just be clear, the above exercise should not block this patch as it > fixes a real issue that has been reported. Yeah definitely fwiw Reviewed-by: Konrad Dybcio >> SM8350-PCIe0 sets 'qcom,l1ss-sleep-disable' which influences some RPMh >> things, but also prevents some clock ops wrt the CLKREF source >> > > We can ignore 'qcom,l1ss-sleep-disable' as it is a Qcom low power feature built > around PCIe L1ss, which is not yet supported in upstream. OK thanks Konrad