From: Yevgeny Kliteynik <kliteyn@nvidia.com>
To: Qasim Ijaz <qasdev00@gmail.com>,
saeedm@nvidia.com, leon@kernel.org, tariqt@nvidia.com,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com
Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net/mlx5: DR, remove redundant object_range assignment
Date: Mon, 24 Mar 2025 22:19:08 +0200 [thread overview]
Message-ID: <cdf5be92-1a13-4368-b36f-c3ccdaa866a4@nvidia.com> (raw)
In-Reply-To: <20250324194159.24282-1-qasdev00@gmail.com>
On 24-Mar-25 21:41, Qasim Ijaz wrote:
> The initial assignment of object_range from
> pool->dmn->info.caps.log_header_modify_argument_granularity is
> redundant because it is immediately overwritten by the max_t() call.
>
> Remove the unnecessary assignment.
>
> Signed-off-by: Qasim Ijaz <qasdev00@gmail.com>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/steering/sws/dr_arg.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/sws/dr_arg.c b/drivers/net/ethernet/mellanox/mlx5/core/steering/sws/dr_arg.c
> index 01ed6442095d..c2218dc556c7 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/sws/dr_arg.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/sws/dr_arg.c
> @@ -39,9 +39,6 @@ static int dr_arg_pool_alloc_objs(struct dr_arg_pool *pool)
>
> INIT_LIST_HEAD(&cur_list);
>
> - object_range =
> - pool->dmn->info.caps.log_header_modify_argument_granularity;
> -
> object_range =
> max_t(u32, pool->dmn->info.caps.log_header_modify_argument_granularity,
> DR_ICM_MODIFY_HDR_GRANULARITY_4K);
Reviewed-by: Yevgeny Kliteynik <kliteyn@nvidia.com>
next prev parent reply other threads:[~2025-03-24 20:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-24 19:41 [PATCH] net/mlx5: DR, remove redundant object_range assignment Qasim Ijaz
2025-03-24 20:19 ` Yevgeny Kliteynik [this message]
2025-03-26 6:13 ` Tariq Toukan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cdf5be92-1a13-4368-b36f-c3ccdaa866a4@nvidia.com \
--to=kliteyn@nvidia.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=qasdev00@gmail.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox