From: "Jin, Yao" <yao.jin@linux.intel.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com,
alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org,
linux-perf-users@vger.kernel.org, ak@linux.intel.com,
kan.liang@intel.com, yao.jin@intel.com, rickyman7@gmail.com,
john.garry@huawei.com, Kan Liang <kan.liang@linux.intel.com>
Subject: Re: [PATCH v7 1/2] perf pmu: Add PMU alias support
Date: Sun, 5 Sep 2021 17:10:58 +0800 [thread overview]
Message-ID: <ce0e8ecd-94fc-886d-665a-744ceff5a129@linux.intel.com> (raw)
In-Reply-To: <YTIJLyL4Ba7wuZqs@kernel.org>
Hi Arnaldo,
On 9/3/2021 7:38 PM, Arnaldo Carvalho de Melo wrote:
> Committer notes:
>
> Rename 'struct perf_pmu_alias_name' to 'pmu_alias', the 'perf_' prefix
> should be used for libperf, things inside just tools/perf/ are being
> moved away from that prefix.
>
> Also 'pmu_alias' is shorter and reflects the abstraction.
>
> Also don't use 'pmu' as the name for variables for that type, we should
> use that for the 'struct perf_pmu' variables, avoiding confusion. Use
> 'pmu_alias' for 'struct pmu_alias' variables.
I fully agree your recommended changes. I think Kan will agree too. :) Thanks so much!
Thanks
Jin Yao
next prev parent reply other threads:[~2021-09-05 9:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 6:59 [PATCH v7 0/2] perf tools: Add PMU alias support Jin Yao
2021-09-02 6:59 ` [PATCH v7 1/2] perf pmu: " Jin Yao
2021-09-03 11:38 ` Arnaldo Carvalho de Melo
2021-09-03 11:52 ` Arnaldo Carvalho de Melo
2021-09-05 9:36 ` Jin, Yao
2021-09-05 9:10 ` Jin, Yao [this message]
2021-09-02 6:59 ` [PATCH v7 2/2] perf tests: Test for PMU alias Jin Yao
2021-09-03 11:40 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce0e8ecd-94fc-886d-665a-744ceff5a129@linux.intel.com \
--to=yao.jin@linux.intel.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=john.garry@huawei.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=kan.liang@linux.intel.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rickyman7@gmail.com \
--cc=yao.jin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox