From: John Garry <john.garry@huawei.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "xuwei (O)" <xuwei5@hisilicon.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Linuxarm <linuxarm@huawei.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
SoC Team <soc@kernel.org>,
Yang Yingliang <yangyingliang@huawei.com>
Subject: Re: [PATCH v2 5/5] bus: hisi_lpc: Use platform_device_register_full()
Date: Fri, 2 Sep 2022 10:35:45 +0100 [thread overview]
Message-ID: <ce2312ef-fffa-2467-f6b3-98ac31244065@huawei.com> (raw)
In-Reply-To: <CAHp75VeE2OZHzwG-KbTHYks+G=sLfyx9Yy1W=RxORTtet-vDnQ@mail.gmail.com>
On 02/09/2022 10:21, Andy Shevchenko wrote:
>> Reviewed-by: Andy Shevchenko<andy.shevchenko@gmail.com>
> Too fast to give a tag, see below (keep tag if addressing it)
thanks
>
> ...
>
>>> - pdev = platform_device_alloc(cell->name, PLATFORM_DEVID_AUTO);
>>> + pdev = platform_device_register_full(cell->pdevinfo);
>>> if (!pdev)
>>> return -ENOMEM;
> As per kernel doc:
> * Returns &struct platform_device pointer on success, or ERR_PTR() on error.
ah, right, I thought that I got that correct....
John
prev parent reply other threads:[~2022-09-02 9:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-02 7:47 [PATCH v2 0/5] Misc hisi_lpc changes John Garry
2022-09-02 7:47 ` [PATCH v2 1/5] bus: hisi_lpc: Don't dereference fwnode handle John Garry
2022-09-02 7:47 ` [PATCH v2 2/5] bus: hisi_lpc: Use devm_platform_ioremap_resource John Garry
2022-09-02 7:47 ` [PATCH v2 3/5] bus: hisi_lpc: Correct error code for timeout John Garry
2022-09-02 7:47 ` [PATCH v2 4/5] bus: hisi_lpc: Don't guard ACPI IDs with ACPI_PTR() John Garry
2022-09-02 7:47 ` [PATCH v2 5/5] bus: hisi_lpc: Use platform_device_register_full() John Garry
2022-09-02 9:18 ` Andy Shevchenko
2022-09-02 9:21 ` Andy Shevchenko
2022-09-02 9:35 ` John Garry [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce2312ef-fffa-2467-f6b3-98ac31244065@huawei.com \
--to=john.garry@huawei.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=rafael.j.wysocki@intel.com \
--cc=soc@kernel.org \
--cc=xuwei5@hisilicon.com \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox