public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Vishnu Sankar <vishnuocv@gmail.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
	platform-driver-x86@vger.kernel.org,
	 LKML <linux-kernel@vger.kernel.org>,
	 Mark Pearson <mpearson-lenovo@squebb.ca>,
	vsankar@lenovo.com
Subject: Re: [PATCH v2 2/2] platform/x86: thinkpad_acpi: Fix to correct wrong temp reporting on some ThinkPads
Date: Mon, 19 Feb 2024 13:44:18 +0200 (EET)	[thread overview]
Message-ID: <ce399b39-aef8-b911-3575-191a0c1104a5@linux.intel.com> (raw)
In-Reply-To: <20240215134102.25118-2-vishnuocv@gmail.com>

On Thu, 15 Feb 2024, Vishnu Sankar wrote:

> Added non-standard thermal register's support for some ThinkPads.
> 
> Some of the Thinkpads use a non-standard ECFW which has different
> thermal register addresses. This is a fix to correct the wrong temperature
> reporting on those systems.
> 
> Tested on Lenovo ThinkPad L13 Yoga Gen2.
> 
> Suggested-by: Mark Pearson <mpearson-lenovo@squebb.ca>
> Signed-off-by: Vishnu Sankar <vishnuocv@gmail.com>

> @@ -6290,6 +6332,8 @@ static int thermal_get_sensors(struct ibm_thermal_sensors_struct *s)
>  
>  	if (thermal_read_mode == TPACPI_THERMAL_TPEC_16)
>  		n = 16;
> +	else if (thermal_read_mode == TPACPI_THERMAL_TPEC_12)
> +		n = 12;
>  
>  	for (i = 0 ; i < n; i++) {
>  		res = thermal_get_sensor(i, &s->temp[i]);

Thanks. Both patches now applied. I did some further cleanups into the 
first patch (which I had requested you to do :-().

This 2nd patch didn't apply cleanly on top of for-next but I handled the 
conflict for you this time, in future, please try to base your work on top 
of for-next branch.


-- 
 i.


      reply	other threads:[~2024-02-19 11:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-15 13:41 [PATCH v2 1/2] platform/x86: thinkpad_acpi: Simplify thermal mode checking Vishnu Sankar
2024-02-15 13:41 ` [PATCH v2 2/2] platform/x86: thinkpad_acpi: Fix to correct wrong temp reporting on some ThinkPads Vishnu Sankar
2024-02-19 11:44   ` Ilpo Järvinen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ce399b39-aef8-b911-3575-191a0c1104a5@linux.intel.com \
    --to=ilpo.jarvinen@linux.intel.com \
    --cc=hdegoede@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpearson-lenovo@squebb.ca \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=vishnuocv@gmail.com \
    --cc=vsankar@lenovo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox