From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D907C76196 for ; Wed, 29 Mar 2023 02:35:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229807AbjC2CfF (ORCPT ); Tue, 28 Mar 2023 22:35:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43652 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229456AbjC2CfC (ORCPT ); Tue, 28 Mar 2023 22:35:02 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B8A7F2703; Tue, 28 Mar 2023 19:35:01 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3CAD061A3F; Wed, 29 Mar 2023 02:35:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 818F7C433D2; Wed, 29 Mar 2023 02:35:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680057300; bh=GqNruyQ94NkZ9NZt0BUZLkCLHVLlwAwMXOdfDeCJI04=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=ovg0HlNr3Bs88xxOHq4hcpTCtbM+6JRYm0WsI4AU+1u5NlvgImtKg6x2VOrNqhzmy TXo7abF/Uk6iVlsJedflsT7NZ1qXTPi9LYQirrguYQKQFJ3EEqf3ntsIOe0+zk5DES cpt/Nnb5NDzbaAuklKOJtjlLXpNzjYQlhUk+9DPff5rSRmNljbwFkKUgHVfwDPbGwW fKHdMZTPeIaw8iWgBjhJO9jC+OBXaaaSEIYp4m0C1Oo5OAeMfJFDmywcnwTL+RHc5F DNUQofY35JnnjosPfUZcGgfaHjDNSvTY/OrfctUMLtCFIke/F8qDhHgB87vERs5fK6 zMZZ3BDDpf5DA== Message-ID: Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20230312161512.2715500-3-u.kleine-koenig@pengutronix.de> References: <20230312161512.2715500-1-u.kleine-koenig@pengutronix.de> <20230312161512.2715500-3-u.kleine-koenig@pengutronix.de> Subject: Re: [PATCH 02/30] clk: tegra: Don't warn three times about failure to unregister From: Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org To: Jonathan Hunter , Michael Turquette , Peter De Schrijver , Prashant Gaikwad , Thierry Reding , Uwe =?utf-8?q?Kleine-K=C3=B6nig?= Date: Tue, 28 Mar 2023 19:34:58 -0700 User-Agent: alot/0.10 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Uwe Kleine-K=C3=B6nig (2023-03-12 09:14:44) > tegra124_dfll_fcpu_remove() calls tegra_dfll_unregister() and the former > emits an error message if the latter fails. In that case > tegra_dfll_unregister() already printed an error message. Additionally > tegra124_dfll_fcpu_remove() returns an error code which results in yet > another warning emitted by platform_remove(). >=20 > So drop the error message from tegra124_dfll_fcpu_remove() and let it > return 0. (Retuning 0 has no side effect but suppressing the error > message in platform_remove().) >=20 > Also add two comments about exiting early being wrong. This is something > that needs fixing separately. >=20 > Signed-off-by: Uwe Kleine-K=C3=B6nig > --- Applied to clk-next