From: "Asutosh Das (asd)" <asutoshd@codeaurora.org>
To: Can Guo <cang@codeaurora.org>,
nguyenb@codeaurora.org, hongwus@codeaurora.org,
rnayak@codeaurora.org, linux-scsi@vger.kernel.org,
kernel-team@android.com, saravanak@google.com,
salyzyn@google.com
Cc: Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Stanley Chu <stanley.chu@mediatek.com>,
Bean Huo <beanhuo@micron.com>,
Bart Van Assche <bvanassche@acm.org>,
Satya Tangirala <satyat@google.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] scsi: ufs: Remove scale down gear hard code
Date: Mon, 30 Nov 2020 14:54:52 -0800 [thread overview]
Message-ID: <ce5e6132-8284-c2c5-3eaa-78d400763534@codeaurora.org> (raw)
In-Reply-To: <1606442334-22641-1-git-send-email-cang@codeaurora.org>
On 11/26/2020 5:58 PM, Can Guo wrote:
> Instead of making the scale down gear a hard code, make it a member of
> ufs_clk_scaling struct.
>
> Signed-off-by: Can Guo <cang@codeaurora.org>
> ---
Reviewed-by: Asutosh Das <asutoshd@codeaurora.org>
> drivers/scsi/ufs/ufshcd.c | 12 +++++++-----
> drivers/scsi/ufs/ufshcd.h | 2 ++
> 2 files changed, 9 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index 44254c9..1789df3 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -1100,7 +1100,6 @@ static int ufshcd_wait_for_doorbell_clr(struct ufs_hba *hba,
> */
> static int ufshcd_scale_gear(struct ufs_hba *hba, bool scale_up)
> {
> - #define UFS_MIN_GEAR_TO_SCALE_DOWN UFS_HS_G1
> int ret = 0;
> struct ufs_pa_layer_attr new_pwr_info;
>
> @@ -1111,16 +1110,16 @@ static int ufshcd_scale_gear(struct ufs_hba *hba, bool scale_up)
> memcpy(&new_pwr_info, &hba->pwr_info,
> sizeof(struct ufs_pa_layer_attr));
>
> - if (hba->pwr_info.gear_tx > UFS_MIN_GEAR_TO_SCALE_DOWN
> - || hba->pwr_info.gear_rx > UFS_MIN_GEAR_TO_SCALE_DOWN) {
> + if (hba->pwr_info.gear_tx > hba->clk_scaling.min_gear ||
> + hba->pwr_info.gear_rx > hba->clk_scaling.min_gear) {
> /* save the current power mode */
> memcpy(&hba->clk_scaling.saved_pwr_info.info,
> &hba->pwr_info,
> sizeof(struct ufs_pa_layer_attr));
>
> /* scale down gear */
> - new_pwr_info.gear_tx = UFS_MIN_GEAR_TO_SCALE_DOWN;
> - new_pwr_info.gear_rx = UFS_MIN_GEAR_TO_SCALE_DOWN;
> + new_pwr_info.gear_tx = hba->clk_scaling.min_gear;
> + new_pwr_info.gear_rx = hba->clk_scaling.min_gear;
> }
> }
>
> @@ -1824,6 +1823,9 @@ static void ufshcd_init_clk_scaling(struct ufs_hba *hba)
> if (!ufshcd_is_clkscaling_supported(hba))
> return;
>
> + if (!hba->clk_scaling.min_gear)
> + hba->clk_scaling.min_gear = UFS_HS_G1;
> +
> INIT_WORK(&hba->clk_scaling.suspend_work,
> ufshcd_clk_scaling_suspend_work);
> INIT_WORK(&hba->clk_scaling.resume_work,
> diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
> index 6f0f2d4..bdab23e 100644
> --- a/drivers/scsi/ufs/ufshcd.h
> +++ b/drivers/scsi/ufs/ufshcd.h
> @@ -385,6 +385,7 @@ struct ufs_saved_pwr_info {
> * @workq: workqueue to schedule devfreq suspend/resume work
> * @suspend_work: worker to suspend devfreq
> * @resume_work: worker to resume devfreq
> + * @min_gear: lowest HS gear to scale down to
> * @is_allowed: tracks if scaling is currently allowed or not
> * @is_busy_started: tracks if busy period has started or not
> * @is_suspended: tracks if devfreq is suspended or not
> @@ -399,6 +400,7 @@ struct ufs_clk_scaling {
> struct workqueue_struct *workq;
> struct work_struct suspend_work;
> struct work_struct resume_work;
> + u32 min_gear;
> bool is_allowed;
> bool is_busy_started;
> bool is_suspended;
>
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
Linux Foundation Collaborative Project
next prev parent reply other threads:[~2020-11-30 22:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-27 1:58 [PATCH 1/1] scsi: ufs: Remove scale down gear hard code Can Guo
2020-11-30 2:23 ` Stanley Chu
2020-11-30 18:58 ` Bean Huo
2020-11-30 22:54 ` Asutosh Das (asd) [this message]
2020-12-01 5:17 ` Martin K. Petersen
2020-12-08 4:51 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce5e6132-8284-c2c5-3eaa-78d400763534@codeaurora.org \
--to=asutoshd@codeaurora.org \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=hongwus@codeaurora.org \
--cc=jejb@linux.ibm.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=nguyenb@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=salyzyn@google.com \
--cc=saravanak@google.com \
--cc=satyat@google.com \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox