Re: [PATCH 00 of 10] x86: unify asm/pgtable.h

Ingo Molnar
2008-01-09T01:37:50Z

* Jeremy Fitzhardinge <jeremy@goop.org> wrote:

>>> +#define GLOBAL_PGPROT(prot) __pgprot(prot | _PAGE_GLOBAL)
>>> +
>>> +#define PAGE_KERNEL GLOBAL_PGPROT(__PAGE_KERNEL)
>>> +#define PAGE_KERNEL_RO GLOBAL_PGPROT(__PAGE_KERNEL_RO)
>>> +#define PAGE_KERNEL_EXEC GLOBAL_PGPROT(__PAGE_KERNEL_EXEC)
>>> +#define PAGE_KERNEL_RX GLOBAL_PGPROT(__PAGE_KERNEL_RX)
>>> +#define PAGE_KERNEL_NOCACHE GLOBAL_PGPROT(__PAGE_KERNEL_NOCACHE)
>>> +#define PAGE_KERNEL_LARGE GLOBAL_PGPROT(__PAGE_KERNEL_LARGE)
>>> +#define PAGE_KERNEL_LARGE_EXEC GLOBAL_PGPROT(__PAGE_KERNEL_LARGE_EXEC)
>>> +#define PAGE_KERNEL_VSYSCALL GLOBAL_PGPROT(__PAGE_KERNEL_VSYSCALL)
>>> +#define PAGE_KERNEL_VSYSCALL_NOCACHE GLOBAL_PGPROT(__PAGE_KERNEL_VSYSCALL_NOCACHE)
>>>
>>
>> i suspect you wanted to make GLOBAL_PGPROT a NOP on 32-bit?
>>
>
> Yeah, cut'n'paste from a stale buffer.

ok.

i've updated x86.git with the latest bits, could you double-check it?
Havent applied any pgattr*.c changes yet. Note, it's not fully tested
through yet, so it might have a few rough edges, but wanted to get the
current stuff out.

Ingo