From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754061AbdA0GGq (ORCPT ); Fri, 27 Jan 2017 01:06:46 -0500 Received: from mx2.suse.de ([195.135.220.15]:46489 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753831AbdA0GGo (ORCPT ); Fri, 27 Jan 2017 01:06:44 -0500 Subject: Re: [PATCH] xen,input: try to read screen resolution for xen-kbdfront To: Dmitry Torokhov References: <20170124120955.24898-1-jgross@suse.com> <20170124184750.GG27969@dtor-ws> Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, xen-devel@lists.xenproject.org, stable@vger.kernel.org From: Juergen Gross Message-ID: Date: Fri, 27 Jan 2017 07:06:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <20170124184750.GG27969@dtor-ws> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/01/17 19:47, Dmitry Torokhov wrote: > On Tue, Jan 24, 2017 at 01:09:55PM +0100, Juergen Gross wrote: >> Instead of using the default resolution of 800*600 for the pointing >> device of xen-kbdfront try to read the resolution of the (virtual) >> framebuffer device. Use the default as fallback only. >> >> Cc: stable@vger.kernel.org >> Signed-off-by: Juergen Gross >> --- >> drivers/input/misc/xen-kbdfront.c | 15 ++++++++++++--- >> 1 file changed, 12 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/input/misc/xen-kbdfront.c b/drivers/input/misc/xen-kbdfront.c >> index 3900875..0032c81 100644 >> --- a/drivers/input/misc/xen-kbdfront.c >> +++ b/drivers/input/misc/xen-kbdfront.c >> @@ -16,6 +16,7 @@ >> #include >> #include >> #include >> +#include >> #include >> #include >> >> @@ -108,10 +109,11 @@ static irqreturn_t input_handler(int rq, void *dev_id) >> static int xenkbd_probe(struct xenbus_device *dev, >> const struct xenbus_device_id *id) >> { >> - int ret, i; >> + int ret, i, width, height; >> unsigned int abs; >> struct xenkbd_info *info; >> struct input_dev *kbd, *ptr; >> + struct fb_info *fb0; >> >> info = kzalloc(sizeof(*info), GFP_KERNEL); >> if (!info) { >> @@ -173,9 +175,16 @@ static int xenkbd_probe(struct xenbus_device *dev, >> ptr->id.product = 0xfffe; >> >> if (abs) { >> + width = XENFB_WIDTH; >> + height = XENFB_HEIGHT; >> + fb0 = registered_fb[0]; > > This will break if !CONFIG_FBi I think. While i see that xen.config has > it on I wonder if it is still possible to turn it off (either randconfig > or intentionally). kbuild robot says it is. :-( Sending V2. Thanks, Juergen