From: hpa@zytor.com (H. Peter Anvin)
To: linux-kernel@vger.kernel.org
Subject: Re: PATCH: fix some 32bit isms
Date: Wed, 28 Jul 2004 15:42:42 +0000 (UTC) [thread overview]
Message-ID: <ce8hhi$ogg$1@terminus.zytor.com> (raw)
In-Reply-To: 20040728135941.GA17409@devserv.devel.redhat.com
Followup to: <20040728135941.GA17409@devserv.devel.redhat.com>
By author: Alan Cox <alan@redhat.com>
In newsgroup: linux.dev.kernel
>
> Fairly self explanatory. int is not size_t.
>
> Alan
>
> OSDL Developer Certificate of Origin 1.0 included herein by reference
>
>
> diff -u --new-file --recursive --exclude-from /usr/src/exclude
> linux.vanilla-2.6.8-rc2/drivers/message/fusion/mptbase.c linux-2.6.8-rc2/drivers/message/fusion/mptbase.c
> --- linux.vanilla-2.6.8-rc2/drivers/message/fusion/mptbase.c 2004-07-27 19:22:42.000000000 +0100
> +++ linux-2.6.8-rc2/drivers/message/fusion/mptbase.c 2004-07-28 14:27:53.603586584 +0100
> @@ -2417,7 +2417,7 @@
> } else {
> printk(MYIOC_s_ERR_FMT
> "Invalid IOC facts reply, msgLength=%d offsetof=%d!\n",
> - ioc->name, facts->MsgLength, (offsetof(IOCFactsReply_t,
> + ioc->name, facts->MsgLength, (int)(offsetof(IOCFactsReply_t,
> RequestFrameSize)/sizeof(u32)));
> return -66;
> }
This is probably better fixed by changing %d to %zu.
-hpa
next prev parent reply other threads:[~2004-07-28 15:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-28 13:59 PATCH: fix some 32bit isms Alan Cox
2004-07-28 15:42 ` H. Peter Anvin [this message]
2004-07-28 15:51 ` David S. Miller
2004-07-28 16:23 ` Andrew Morton
2004-07-28 16:27 ` Alan Cox
2004-08-06 22:53 ` H. Peter Anvin
2004-08-06 23:03 ` viro
2004-08-06 23:07 ` viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='ce8hhi$ogg$1@terminus.zytor.com' \
--to=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox