From: Danilo Krummrich <dakr@kernel.org>
To: Daniel Almeida <daniel.almeida@collabora.com>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Mika Westerberg" <mika.westerberg@linux.intel.com>,
"Ying Huang" <huang.ying.caritas@gmail.com>,
"Benno Lossin" <lossin@kernel.org>,
linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org
Subject: Re: [PATCH v11 4/4] rust: platform: allow ioremap of platform resources
Date: Wed, 2 Jul 2025 12:36:13 +0200 [thread overview]
Message-ID: <ce990cdf-f279-466d-b402-d98e4a75edb3@kernel.org> (raw)
In-Reply-To: <20250701-topics-tyr-platform_iomem-v11-4-6cd5d5061151@collabora.com>
On 7/1/25 4:34 PM, Daniel Almeida wrote:
> +impl Device<device::Bound> {
<snip>
> + pub fn iomap_resource_sized<const SIZE: usize>(
> + &self,
> + resource: &Resource,
> + ) -> Result<impl PinInit<Devres<IoMem<SIZE>>, Error> + '_> {
> + IoMem::new(resource, self.as_ref())
> + }
Sorry that I did not catch this earlier, but what if I supply a Resource here
that has *not* been obtained by any of the platform::Device methods and from the
same platform::Device as you call this function for?
I think this also needs something similar to what we do in the IRQ abstraction,
e.g.:
/// # Invariants
///
/// `res` has been obtained from `dev`.
pub struct IoRequest<'a> {
dev: &'a Device<Bound>,
res: &'a Resource,
}
Such that IoMem::new() can take an IoRequest instance instead.
next prev parent reply other threads:[~2025-07-02 10:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-01 14:34 [PATCH v11 0/4] rust: platform: add Io support Daniel Almeida
2025-07-01 14:34 ` [PATCH v11 1/4] rust: io: add resource abstraction Daniel Almeida
2025-07-02 7:44 ` Miguel Ojeda
2025-07-02 18:04 ` Daniel Almeida
2025-07-02 10:21 ` Danilo Krummrich
2025-07-02 18:11 ` Daniel Almeida
2025-07-02 18:16 ` Danilo Krummrich
2025-07-01 14:34 ` [PATCH v11 2/4] rust: io: mem: add a generic iomem abstraction Daniel Almeida
2025-07-01 14:34 ` [PATCH v11 3/4] rust: platform: add resource accessors Daniel Almeida
2025-07-01 14:34 ` [PATCH v11 4/4] rust: platform: allow ioremap of platform resources Daniel Almeida
2025-07-02 10:36 ` Danilo Krummrich [this message]
2025-07-02 7:52 ` [PATCH v11 0/4] rust: platform: add Io support Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce990cdf-f279-466d-b402-d98e4a75edb3@kernel.org \
--to=dakr@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=daniel.almeida@collabora.com \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=huang.ying.caritas@gmail.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=ojeda@kernel.org \
--cc=rafael@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox