From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752212AbdIVUom (ORCPT ); Fri, 22 Sep 2017 16:44:42 -0400 Received: from mout.web.de ([212.227.17.11]:57842 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751845AbdIVUok (ORCPT ); Fri, 22 Sep 2017 16:44:40 -0400 Subject: Re: [media] spca500: Use common error handling code in spca500_synch310() To: Daniele Nicolodi , linux-media@vger.kernel.org Cc: Julia Lawall , Hans Verkuil , Mauro Carvalho Chehab , Sakari Ailus , LKML , kernel-janitors@vger.kernel.org References: <4921ea61-49cd-4071-e636-c199daddec8e@users.sourceforge.net> <0baa322a-6019-70dc-0245-caae824ccb49@users.sourceforge.net> <25a82438-8760-66fd-23d3-24569078f906@grinta.net> From: SF Markus Elfring Message-ID: Date: Fri, 22 Sep 2017 22:44:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <25a82438-8760-66fd-23d3-24569078f906@grinta.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:t3yIAweECePkX0mtCTy8KwV3lN+Dxlabd7DvbOEZtT+kwLAIAVu VwLEHhXA9fG0GIBbjob/X+Ideph8sI/rTyhHpLQjrCcu9LENusQoYNcs7ytFxDvN4VxoadI DpjcGDvojGecdkJzp9QcU0Th1lKb+lYRhP0InFcydG3C4yZ6Nlrg7BrAI/y0DNFtre0jVcP ksZfh6ChGFYJxcCl9MRCQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:CPaXTX8PJTw=:vokzvYW55WQIgb+B3cA97c FT11cXtJuhZP7UfU/WMeDDvkegsuVlL+k4MlhHfG+81u6i3VU3AGWBIWx5q5a1546sjh2pQHj HE6l1DrL8yEgwV6H7N3lwGeaZ9LEp6/YdDnJbNZBX8tgvmwDeBkVcfHDeqDRJTnoa8tuZcxLz HTJ4plfODZGxH3+7P3z1kV/SrpziSQ+ReLElqcRkhud8iny6ulmT+ErakKHARK8R1xBrNA3TD gDg9EGKjYlHIYB6rwsudFwT4wLvOTd/Hhvv7vPJZzDcPr3QF1j0vDdRc6OWAeIdZg+XV7lZ7A 01/5CpQleJWriFWT4Hyh/0zHgJHelxQyIG4JP79VPlzqyR0+LzLg3fPBT1lGTFHmLx6UcF+eH elRZczBKBMgQv/xdg7dI2jKeDV3RGAaR+Z+G7O3+fA9rvzhHk5o4iYDTNmR3cGyOnc4nSN6HR TJkJt0h3UD2bqvtt2BCOsegQC4S1k7p2qGSs5EYnjx3lTArP3Ig/uEHYP1DvJOE1q/1K1WBnE 972Mfm5askElBfj4Myx1HzTpULFh1elw0HL+SpcoyA9mSqHjoKXKmH8rik+lmR7kyyYvkgJQU 7zN7Ebgit0AT4AwnA4w5le0+B1QGYl2/15NmAnvbNkBqWMwfdwfxr9ZgYdtDa/dTUtqXZisd3 weaYM2ZssmQwNotP4fQ5F+XFxDLbCRjScoS8E0Jd4Mi9OaiFlisl+yj3MKIHEWGMWT362ccs4 SmWwCMrPDr2butTxEvxQ1Yj7ftLungvVNGYRvajdZxKydE9J2n7eHQdNDIvN9Ste5YjxCcCVs z0x5kXWTXRbItFoU10m6tdiG4KCNdtPv4+C10HXfUg/RR9oa4k= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > No one needs to argue about keeping it the way it is. I got an other impression in this case after a bit of information was presented which seems to be contradictory. > I don't see any improvement brought by the proposed change, Do you care if the source code for an error message is present only once in this function? > other than making the code harder to read. I suggest to reconsider this concern. > I find goto statements hard to read, because they inherently make some > information non local. They are justified in error path handling, > if the error path only unwinds what the function did early on. > That's not the case here. I am looking also for change possibilities without such a restriction. > The same applies to dozens of patches you proposed recently. I proposed some software updates to reduce a bit of code duplication. Do you find any corresponding approaches useful? Regards, Markus