From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: <linux-kernel@vger.kernel.org>, <llvm@lists.linux.dev>,
<oe-kbuild-all@lists.linux.dev>,
<amadeuszx.slawinski@linux.intel.com>,
"Tony Nguyen" <anthony.l.nguyen@intel.com>,
<nex.sw.ncis.osdt.itp.upstreaming@intel.com>,
<netdev@vger.kernel.org>, Markus Elfring <Markus.Elfring@web.de>,
Kees Cook <keescook@chromium.org>,
David Lechner <dlechner@baylibre.com>,
Dan Carpenter <error27@gmail.com>,
Andy Shevchenko <andriy.shevchenko@intel.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v3] cleanup: adjust scoped_guard() macros to avoid potential warning
Date: Wed, 23 Oct 2024 16:44:10 +0200 [thread overview]
Message-ID: <cea9c68e-758a-44ce-8afc-448294456317@intel.com> (raw)
In-Reply-To: <20241023143204.GB9767@noisy.programming.kicks-ass.net>
On 10/23/24 16:32, Peter Zijlstra wrote:
> On Wed, Oct 23, 2024 at 03:43:22PM +0200, Przemek Kitszel wrote:
>> On 10/18/24 12:50, Peter Zijlstra wrote:
>>> On Sun, Oct 13, 2024 at 12:01:24PM +0800, kernel test robot wrote:
>
>>> --- a/include/linux/cleanup.h
>>> +++ b/include/linux/cleanup.h
>>> @@ -323,7 +323,7 @@ static __maybe_unused const bool class_#
>>> */
>>> #define __scoped_guard(_name, _fail, _label, args...) \
>>> for (CLASS(_name, scope)(args); true; ({ goto _label; })) \
>>> - if (!__guard_ptr(_name)(&scope) && __is_cond_ptr(_name)) { \
>>> + if (__is_cond_ptr(_name) && !__guard_ptr(_name)(&scope)) { \
>>
>> but this will purge the attempt to call __guard_ptr(), and thus newer
>> lock ;) good that there is at least some comment above
>
> No, __guard_ptr() will only return a pointer, it has no action. The lock
> callback is in CLASS(_name, scope)(args).
Ach, true! Thanks again for taking a look at my series!
next prev parent reply other threads:[~2024-10-23 14:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-11 12:15 [PATCH v3] cleanup: adjust scoped_guard() macros to avoid potential warning Przemek Kitszel
2024-10-13 4:01 ` kernel test robot
2024-10-18 10:50 ` Peter Zijlstra
2024-10-23 13:43 ` Przemek Kitszel
2024-10-23 14:32 ` Peter Zijlstra
2024-10-23 14:44 ` Przemek Kitszel [this message]
2024-10-13 5:16 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cea9c68e-758a-44ce-8afc-448294456317@intel.com \
--to=przemyslaw.kitszel@intel.com \
--cc=Markus.Elfring@web.de \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=andriy.shevchenko@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=dlechner@baylibre.com \
--cc=dmitry.torokhov@gmail.com \
--cc=error27@gmail.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=nex.sw.ncis.osdt.itp.upstreaming@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox