From: Jonathan Cameron <jic23@kernel.org>
To: Enric Balletbo Serra <eballetbo@gmail.com>,
Lars-Peter Clausen <lars@metafoo.de>
Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: light: acpi-als: Add a tuning parameter interface.
Date: Sat, 10 Sep 2016 16:57:34 +0100 [thread overview]
Message-ID: <cebd989a-6c84-fb60-eb26-e37b7eaf90ab@kernel.org> (raw)
In-Reply-To: <CAFqH_513e24aOZ8NJ+m0WtzKmf-n3R8FwwApFGWCdgoQbJRdNA@mail.gmail.com>
On 06/09/16 17:48, Enric Balletbo Serra wrote:
> Hi Lars,
>
> 2016-09-06 12:31 GMT+02:00 Lars-Peter Clausen <lars@metafoo.de>:
>> On 09/06/2016 12:25 PM, Enric Balletbo i Serra wrote:
>>> From: Bryan Freed <bfreed@chromium.org>
>>>
>>> Add IIO_CHAN_INFO_CALIBSCALE to the channel to scale up or down
>>> the raw measurements through the IIO framework.
>>>
>>> Add IIO_CHAN_INFO_PROCESSED to provide the interface to read the
>>> scaled measurements through the in_illuminance_input file.
>>
>> What is the use-case for this, how is this interface supposed to be used?
>
> The idea behind this is be able to do a per-device calibration. The
> use case we're thinking is:
>
> 1. Read raw measurements from sensor in controlled environment (at
> 30, 500 and 1000 lux)
> 2. do some math to calculate the calibration value.
> 3. write the value to calibscale (in_illuminance_calibscale)
> 4. read the calibrated measurement (in_illuminance_input)
>
I can see where you are coming from but its a rather nasty fudge.
Given we have non trivial maths involved I'd be inclined to say this
should really be left for userspace HAL layers.
If we were getting it from ACPI tables (as the manufacturer had
done the measurements for the device) then we might expose it this
way but given userspace has to be involved to apply the tuning anyway
I'm not sure having a means to 'fudge' the kernel returned value
really makes sense.
Jonathan
> Regards,
> Enric
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2016-09-10 15:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-06 10:25 [PATCH] iio: light: acpi-als: Add a tuning parameter interface Enric Balletbo i Serra
2016-09-06 10:31 ` Lars-Peter Clausen
2016-09-06 16:48 ` Enric Balletbo Serra
2016-09-10 15:57 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cebd989a-6c84-fb60-eb26-e37b7eaf90ab@kernel.org \
--to=jic23@kernel.org \
--cc=eballetbo@gmail.com \
--cc=enric.balletbo@collabora.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox