Re: [PATCH v4 2/2] ARM: dts: aspeed: Add Initial device tree for AMD Onyx Platform

Rajaganesh Rathinasabapathi
2025-03-19T16:41:42Z

On 3/18/25 23:44, Krzysztof Kozlowski wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>
>
> On 18/03/2025 18:47, Rajaganesh Rathinasabapathi wrote:
>> Add initial device tree and makefile updates for
>> AMD Onyx platform.
>>
>> AMD Onyx platform is an AMD customer reference board with an Aspeed
>> ast2600 BMC manufactured by AMD.
>> It describes I2C devices, UARTs, MAC, FMC, etc.
>> present on AMD Onyx platform.
>>
>> Signed-off-by: Supreeth Venkatesh <supreeth.venkatesh@amd.com>
>> Signed-off-by: Rajaganesh Rathinasabapathi <Rajaganesh.Rathinasabapathi@amd.com>
>> ---
>> Changes since v1:
>> * Incorporate review comments
>
> Which ones? I do not see my comments addressed and if you do not list
> them, I treat it as a clear sign you do not care.
>

Understood, will list them in next patch submission.
>> * Update commit message
>> * Remove vmalloc and earlyprintk
>>
>> Changes since v2:
>> * Address review comments
>
> Which ones? This has to be specific
>
Got it, will add details and fix in next patch.

>> * Fix checkpatch warnings
>> * Remove bootargs
>>
>> Changes since v3:
>> * Fix stdout-path
>> * Change commit summary
>> ---
>> arch/arm/boot/dts/aspeed/Makefile | 1 +
>> .../boot/dts/aspeed/aspeed-bmc-amd-onyx.dts | 102 ++++++++++++++++++
>> 2 files changed, 103 insertions(+)
>> create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-amd-onyx.dts
>>
>> diff --git a/arch/arm/boot/dts/aspeed/Makefile b/arch/arm/boot/dts/aspeed/Makefile
>> index 2e5f4833a073..1e6a130377b8 100644
>> --- a/arch/arm/boot/dts/aspeed/Makefile
>> +++ b/arch/arm/boot/dts/aspeed/Makefile
>> @@ -5,6 +5,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
>> aspeed-ast2600-evb.dtb \
>> aspeed-bmc-amd-daytonax.dtb \
>> aspeed-bmc-amd-ethanolx.dtb \
>> + aspeed-bmc-amd-onyx.dtb \
>> aspeed-bmc-ampere-mtjade.dtb \
>> aspeed-bmc-ampere-mtjefferson.dtb \
>> aspeed-bmc-ampere-mtmitchell.dtb \
>> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-amd-onyx.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-amd-onyx.dts
>> new file mode 100644
>> index 000000000000..32509a651183
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-amd-onyx.dts
>> @@ -0,0 +1,102 @@
>> +// SPDX-License-Identifier: GPL-2.0+
>> +// Copyright (c) 2021 - 2024 AMD Inc.
>> +// Author: Supreeth Venkatesh <supreeth.venkatesh@amd.com>
>> +
>> +/dts-v1/;
>> +
>> +#include "aspeed-g6.dtsi"
>> +#include <dt-bindings/gpio/aspeed-gpio.h>
>> +
>> +/ {
>> + model = "AMD Onyx BMC";
>> + compatible = "amd,onyx-bmc", "aspeed,ast2600";
>> +
>> + aliases {
>> + serial0 = &uart1;
>> + serial4 = &uart5;
>> + };
>> +
>> + chosen {
>> + stdout-path = "serial4:115200n8";
>> + };
>> +
>> + memory@80000000 {
>> + device_type = "memory";
>> + reg = <0x80000000 0x80000000>;
>> + };
>> +
>> +};
> How did you address comment here from v1 which was responded with "ACK"?
>
> What else what exactly fixed and what not?
>
> Best regards,
> Krzysztof

Thanks for the comments.
I will add 'Acked-by' and in next patch submission.

Thanks,
Raja