public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Nuno Sá" <noname.nuno@gmail.com>
To: Ramona Bolboaca <ramona.bolboaca@analog.com>,
	jic23@kernel.org, nuno.sa@analog.com, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/3] iio: Add IIO_DELTA_ANGL channel type
Date: Mon, 07 Aug 2023 16:26:17 +0200	[thread overview]
Message-ID: <cef38375a5259e7df0111821b112341ed670e682.camel@gmail.com> (raw)
In-Reply-To: <20230807111227.374371-2-ramona.bolboaca@analog.com>

On Mon, 2023-08-07 at 14:12 +0300, Ramona Bolboaca wrote:
> The delta angle is defined as a piece-wise integration of angular
> velocity data. The delta angle represents the amount of
> angular displacement between two consecutive measurements and it
> is measured in radians.
> 
> In order to track the total angular displacement during a desired
> period of time, simply sum-up the delta angle samples acquired
> during that time.
> 
> IIO currently does not offer a suitable channel type for this
> type of measurements hence this patch adds it.
> 
> Signed-off-by: Ramona Bolboaca <ramona.bolboaca@analog.com>
> ---
>  Documentation/ABI/testing/sysfs-bus-iio | 14 ++++++++++++++
>  drivers/iio/industrialio-core.c         |  1 +
>  include/uapi/linux/iio/types.h          |  1 +
>  tools/iio/iio_event_monitor.c           |  2 ++
>  4 files changed, 18 insertions(+)
> 
> diff --git a/Documentation/ABI/testing/sysfs-bus-iio
> b/Documentation/ABI/testing/sysfs-bus-iio
> index a2854dc9a839..32675fa7dc6f 100644
> --- a/Documentation/ABI/testing/sysfs-bus-iio
> +++ b/Documentation/ABI/testing/sysfs-bus-iio
> @@ -279,6 +279,20 @@ Description:
>                 but should match other such assignments on device).
>                 Units after application of scale and offset are m/s^2.
>  
> +What:          /sys/bus/iio/devices/iio:deviceX/in_deltaangl_x_raw
> +What:          /sys/bus/iio/devices/iio:deviceX/in_deltaangl_y_raw
> +What:          /sys/bus/iio/devices/iio:deviceX/in_deltaangl_z_raw

I wonder if we also need to add these to the scan element specific bits? From a
quick look, it seems not all supported attributes are in there so I'm not sure
what's the policy in here :)


- Nuno Sá

  reply	other threads:[~2023-08-07 14:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-07 11:12 [PATCH v4 0/3] Add new channels for adis16475 Ramona Bolboaca
2023-08-07 11:12 ` [PATCH v4 1/3] iio: Add IIO_DELTA_ANGL channel type Ramona Bolboaca
2023-08-07 14:26   ` Nuno Sá [this message]
2023-08-07 14:25     ` Jonathan Cameron
2023-08-07 11:12 ` [PATCH v4 2/3] iio: Add IIO_DELTA_VELOCITY " Ramona Bolboaca
2023-08-07 11:12 ` [PATCH v4 3/3] iio: imu: adis16475.c: Add delta angle and delta velocity channels Ramona Bolboaca

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cef38375a5259e7df0111821b112341ed670e682.camel@gmail.com \
    --to=noname.nuno@gmail.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=ramona.bolboaca@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox