Re: [PATCH v6 05/10] dt-bindings: mailbox: add cix,sky1-mbox

Krzysztof Kozlowski
2025-04-16T06:34:37Z

On 15/04/2025 09:27, Peter Chen wrote:
> From: Guomin Chen <Guomin.Chen@cixtech.com>
>
> Add a dt-binding for the Cixtech Mailbox Controller.
>
> Reviewed-by: Peter Chen <peter.chen@cixtech.com>
> Signed-off-by: Lihua Liu <Lihua.Liu@cixtech.com>
> Signed-off-by: Guomin Chen <Guomin.Chen@cixtech.com>

You send patches to soc@ AFTER you get community review, not during.
Look again at document I linked some time ago. New files are not sent to
review to soc@.

> ---
> Changes for v3:
> - Replace the direction attribute of the mailbox with the strings "rx" and "tx"
>
> .../bindings/mailbox/cix,sky1-mbox.yaml | 71 +++++++++++++++++++
> 1 file changed, 71 insertions(+)

That's a completely new file? If you add new patches, mention in the
changelog.

And keep the changelog from the other patchset. What changed here? were
my comments resolved or not?

Best regards,
Krzysztof