Re: [PATCH v6 09/10] arm64: dts: cix: add initial CIX P1(SKY1) dts support

Peter Chen
2025-04-16T01:13:41Z

On 25-04-15 13:48:38, Kajetan Puchalski wrote:
>
> On Tue, Apr 15, 2025 at 03:27:23PM +0800, Peter Chen wrote:
> > CIX SKY1 SoC is high performance Armv9 SoC designed by Cixtech,
> > and Orion O6 is the motherboard launched by Radxa. See below for
> > detail:
> > https://docs.radxa.com/en/orion/o6/getting-started/introduction
> > In this commit, it adds sky1 base, mailbox, clock (scmi firmware baseed)
> > and uart, and the kernel could boot up to console.
>
> The commit message style is supposed to be in imperative tone, i.e. "Add sky1 base".

Thanks, I will change subject to
"arm64: dts: cix: Add sky1 base dts initial support"
>
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > Acked-by: Fugang Duan <fugang.duan@cixtech.com>
> > Signed-off-by: Guomin Chen <Guomin.Chen@cixtech.com>
> > Signed-off-by: Gary Yang <gary.yang@cixtech.com>
> > Signed-off-by: Peter Chen <peter.chen@cixtech.com>
> > ---
>
> I've tested this on my own Orion O6 with 6.15-rc2, the UART does work and the kernel
> does boot up to the expected point. Feel free to add the tag if you'd like.
>
> Tested-by: Kajetan Puchalski <kajetan.puchalski@arm.com>

Thanks for your testing.

Peter

--

Best regards,
Peter