From: Damien Le Moal <dlemoal@kernel.org>
To: "Andreas Hindborg (Samsung)" <nmi@metaspace.dk>,
Ming Lei <ming.lei@redhat.com>
Cc: Hans Holmberg <Hans.Holmberg@wdc.com>,
Aravind Ramesh <Aravind.Ramesh@wdc.com>,
Jens Axboe <axboe@kernel.dk>,
"open list:BLOCK LAYER" <linux-block@vger.kernel.org>,
Christoph Hellwig <hch@infradead.org>,
Matias Bjorling <Matias.Bjorling@wdc.com>,
open list <linux-kernel@vger.kernel.org>,
gost.dev@samsung.com, Minwoo Im <minwoo.im.dev@gmail.com>
Subject: Re: [PATCH v4 4/4] ublk: add zone append
Date: Thu, 29 Jun 2023 18:43:10 +0900 [thread overview]
Message-ID: <cefae2c3-c8b5-f5ff-13dc-e8527ca2346f@kernel.org> (raw)
In-Reply-To: <87edluy5l3.fsf@metaspace.dk>
On 6/29/23 18:17, Andreas Hindborg (Samsung) wrote:
>
> Ming Lei <ming.lei@redhat.com> writes:
>
>> On Wed, Jun 28, 2023 at 09:06:49PM +0200, Andreas Hindborg wrote:
>>> From: Andreas Hindborg <a.hindborg@samsung.com>
>>>
>>> Add zone append feature to ublk. This feature uses the `addr` field of `struct
>>> ublksrv_io_cmd`. Therefore ublk must be used with the user copy
>>> feature (UBLK_F_USER_COPY) for zone append to be available. Without this
>>> feature, ublk will fail zone append requests.
>>
>> Given zone append is a must, please fail to add device in case of zoned
>> and !user_copy, then we can make fast IO code path clean.
>
> I will squash the patches and reject zone support if not user copy is
> enabled 👍
Or if !CONFIG_BLK_DEV_ZONED or if the user specifies a bad parameter (invalid
limits etc).
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2023-06-29 9:43 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-28 19:06 [PATCH v4 0/4] ublk: add zoned storage support Andreas Hindborg
2023-06-28 19:06 ` [PATCH v4 1/4] ublk: change ublk IO command defines to enum Andreas Hindborg
2023-06-28 22:47 ` Damien Le Moal
2023-06-29 0:38 ` Ming Lei
2023-06-29 1:14 ` Damien Le Moal
2023-06-29 7:09 ` Andreas Hindborg (Samsung)
2023-06-29 7:11 ` Andreas Hindborg (Samsung)
[not found] ` <83E5C27A-9AEF-4900-9652-78ACFF47E6B0@wdc.com>
2023-06-30 10:33 ` aravind.ramesh
2023-06-30 16:30 ` Andreas Hindborg (Samsung)
2023-06-28 19:06 ` [PATCH v4 2/4] ublk: move types to shared header file Andreas Hindborg
2023-06-28 22:49 ` Damien Le Moal
[not found] ` <6BEB9EA7-7445-498E-9492-21BC2B5D8B19@wdc.com>
2023-06-30 10:33 ` aravind.ramesh
2023-06-28 19:06 ` [PATCH v4 3/4] ublk: enable zoned storage support Andreas Hindborg
2023-06-28 23:16 ` Damien Le Moal
2023-06-29 7:50 ` Andreas Hindborg (Samsung)
2023-06-29 9:41 ` Damien Le Moal
2023-06-30 11:53 ` Andreas Hindborg (Samsung)
2023-06-29 2:39 ` Ming Lei
2023-06-30 16:51 ` Andreas Hindborg (Samsung)
2023-06-29 2:54 ` kernel test robot
2023-06-29 5:39 ` Christoph Hellwig
2023-06-29 7:25 ` Andreas Hindborg (Samsung)
2023-06-29 7:31 ` Christoph Hellwig
2023-06-29 7:22 ` kernel test robot
[not found] ` <62426D68-1E01-4804-9CFC-A1146770F362@wdc.com>
2023-06-30 10:34 ` aravind.ramesh
2023-06-30 16:37 ` Andreas Hindborg (Samsung)
2023-06-28 19:06 ` [PATCH v4 4/4] ublk: add zone append Andreas Hindborg
2023-06-28 23:17 ` Damien Le Moal
2023-06-29 2:46 ` Ming Lei
2023-06-29 9:17 ` Andreas Hindborg (Samsung)
2023-06-29 9:43 ` Damien Le Moal [this message]
[not found] ` <39701CAF-7AE2-4C83-A4DD-929A0A4FB8F0@wdc.com>
2023-06-30 10:35 ` aravind.ramesh
2023-06-30 16:33 ` Andreas Hindborg (Samsung)
[not found] ` <5F597343-EC91-4698-ACBE-9111B52FC3FC@wdc.com>
2023-06-30 10:33 ` [PATCH v4 0/4] ublk: add zoned storage support aravind.ramesh
2023-06-30 14:26 ` Andreas Hindborg (Samsung)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cefae2c3-c8b5-f5ff-13dc-e8527ca2346f@kernel.org \
--to=dlemoal@kernel.org \
--cc=Aravind.Ramesh@wdc.com \
--cc=Hans.Holmberg@wdc.com \
--cc=Matias.Bjorling@wdc.com \
--cc=axboe@kernel.dk \
--cc=gost.dev@samsung.com \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=minwoo.im.dev@gmail.com \
--cc=nmi@metaspace.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox