From: Baolu Lu <baolu.lu@linux.intel.com>
To: "Tian, Kevin" <kevin.tian@intel.com>,
"iommu@lists.linux.dev" <iommu@lists.linux.dev>
Cc: baolu.lu@linux.intel.com, Joerg Roedel <joro@8bytes.org>,
Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
"Liu, Yi L" <yi.l.liu@intel.com>,
"Pan, Jacob jun" <jacob.jun.pan@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/7] iommu/vt-d: Allocate pasid table in device probe path
Date: Sat, 5 Nov 2022 09:09:33 +0800 [thread overview]
Message-ID: <cf157186-1ee1-0981-5425-d9cd186df57f@linux.intel.com> (raw)
In-Reply-To: <BN9PR11MB52765902DF41858EF445E5BC8C3B9@BN9PR11MB5276.namprd11.prod.outlook.com>
On 2022/11/4 10:06, Tian, Kevin wrote:
>> From: Lu Baolu <baolu.lu@linux.intel.com>
>> Sent: Thursday, November 3, 2022 1:53 PM
>>
>> @@ -4513,6 +4506,16 @@ static struct iommu_device
>> *intel_iommu_probe_device(struct device *dev)
>>
>> dev_iommu_priv_set(dev, info);
>>
>> + if (sm_supported(iommu) && !dev_is_real_dma_subdevice(dev)) {
>> + ret = intel_pasid_alloc_table(dev);
>> + if (ret) {
>> + dev_err(dev, "PASID table allocation failed\n");
>> + dev_iommu_priv_set(dev, NULL);
>> + kfree(info);
>> + return ERR_PTR(ret);
>> + }
>> + }
>> +
>
> move the added lines before dev_iommu_priv_set()
intel_pasid_alloc_table() needs to reference info and store the pasid
table into it.
Best regards,
baolu
next prev parent reply other threads:[~2022-11-05 1:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-03 5:53 [PATCH 0/7] iommu/vt-d: Some cleanups Lu Baolu
2022-11-03 5:53 ` [PATCH 1/7] iommu/vt-d: Allocate pasid table in device probe path Lu Baolu
2022-11-04 2:06 ` Tian, Kevin
2022-11-05 1:09 ` Baolu Lu [this message]
2022-11-05 1:33 ` Tian, Kevin
2022-11-03 5:53 ` [PATCH 2/7] iommu/vt-d: Add blocking domain support Lu Baolu
2022-11-04 2:11 ` Tian, Kevin
2022-11-05 1:54 ` Baolu Lu
2022-11-03 5:53 ` [PATCH 3/7] iommu/vt-d: Use device_block_translation() in dev_attach error path Lu Baolu
2022-11-04 2:18 ` Tian, Kevin
2022-11-05 2:09 ` Baolu Lu
2022-11-05 2:59 ` Baolu Lu
2022-11-03 5:53 ` [PATCH 4/7] iommu/vt-d: Fold dmar_remove_one_dev_info() into its caller Lu Baolu
2022-11-03 5:53 ` [PATCH 5/7] iommu/vt-d: Rename domain_add_dev_info() Lu Baolu
2022-11-03 5:53 ` [PATCH 6/7] iommu/vt-d: Remove unnecessary domain_context_mapped() Lu Baolu
2022-11-04 2:19 ` Tian, Kevin
2022-11-03 5:53 ` [PATCH 7/7] iommu/vt-d: Use real field for indication of first level Lu Baolu
2022-11-04 2:20 ` Tian, Kevin
-- strict thread matches above, loose matches on Subject: below --
2022-11-22 0:29 [PATCH 0/7] [PULL REQUEST] Intel IOMMU updates for Linux v6.2 Lu Baolu
2022-11-22 0:29 ` [PATCH 1/7] iommu/vt-d: Allocate pasid table in device probe path Lu Baolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf157186-1ee1-0981-5425-d9cd186df57f@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=iommu@lists.linux.dev \
--cc=jacob.jun.pan@intel.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox