From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754051AbcICKr5 (ORCPT ); Sat, 3 Sep 2016 06:47:57 -0400 Received: from mail-cys01nam02on0082.outbound.protection.outlook.com ([104.47.37.82]:2518 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753163AbcICKry (ORCPT ); Sat, 3 Sep 2016 06:47:54 -0400 X-Greylist: delayed 7292 seconds by postgrey-1.27 at vger.kernel.org; Sat, 03 Sep 2016 06:47:54 EDT Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Christian.Koenig@amd.com; Subject: Re: [PATCH] drm: amdgpu: mark symbols static where possible To: Baoyou Xie , , , , , , , , , , , , , , , , , , References: <1472882234-19385-1-git-send-email-baoyou.xie@linaro.org> CC: , , , From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: Date: Sat, 3 Sep 2016 10:12:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1472882234-19385-1-git-send-email-baoyou.xie@linaro.org> Content-Type: text/plain; charset="iso-8859-15"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [2a02:908:1251:7981:852b:c1d5:2598:985f] X-ClientProxiedBy: AMSPR02CA0028.eurprd02.prod.outlook.com (10.242.225.156) To MWHPR12MB1310.namprd12.prod.outlook.com (10.169.205.135) X-MS-Office365-Filtering-Correlation-Id: 552f63a2-cdd1-4ea5-d2ed-08d3d3d21633 X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1310;2:J+zwetKlZ41H1NtD4vw+/bwgXG7R6GfKpgO2oDixB2ptyTCvzIIgWVNCjNKXe4eg5JHgJ4RLT0jZv4v+WQ8t3jhflT9uhFt0Rrt5finnX8YeiHKFE/jVXwESygFQ6p8Gsho8LEbeHA68Zq0XaCETskYHFopcPTUjhOO6me/poLpfHiZBVWMzEG3clV3TrV2P;3:AgadlJxx0x+kpuKWm005b0GYlhUqZ97DjgFvv6zsMTva4NTBg0YlrAfIovksAvCQT0BFGfLqfDnUnilTVIS4xg+yS6+sArtfwJraqS0i9Rs01lYwDuegoHvyTLLHB6tf;25:S9Ksjyx1jdYYqiAdQdWvo2WfWS2QOe6gNn87sXV9lmSd2hrWzJ2v2DwsKNr4Dsqn2hSouo8WdR0spp3PU+LlTfip+cVIv7pnK9EFB/1VA31aaVyacggXJ7NICJeNMFuzfYtjNjB2oMMEiER8sLFAqQhFN8+9VX+munWAeFY6q0xBdBbqBiVpHmUfEV+cUmmISKCX9Uw0ck+QUhSwB3ys9lvOeuY5wd/Ax5TthWG85KwMWmxgDuEXse/7/sKq4/pzd52M1o+b+ii/fm/FiCBB70JO88ZmFz3fZR8uM4czddTZpug1es5m0TMSkxt+Yn0iaYt5Z9dtqQYyKqrtH1dCE1atXpfXZ4PXCl9a5w1LMZnzw91zbU8L4Xzc2QOLFM4ZPgW/6t49R0Q0RtpDWHlolOEfEjrRdqEbPiwnJOz1AG8= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:MWHPR12MB1310; X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1310;31:xhtmAuBcfzYVCsgS7S3BhYqET5hlS/xoVmHKVrtg7CJckedvwVMAvFyb+/NrgydIDBzyV55ijQJCg2fUgbLjZuZnv1D5GbImRFoz+MMNl+8mxGNc3TQbDcius4wAzfMYt1B+8cGeN9PmoEaRarFDsfZHsw4n+pmvPQO/sqhWj0DX67whQfRRj5I+fYZuEV+IoO2pN6Nt6GXF6SRnWSAdxhY1/IMiIcpF/nzN4ZQba6I=;20:i/mYTJ9uImB0Kf7WcBKs+lbM0eWjJn4u5i68R49pGGXMG0piyIzfqNdLqJ8bw50K7AMAnVSGefIGv0pKXp4NLTPRG2Twr38ni9dbYMCCYTn8KQjVJBVUwrijTrFcckwZ2irU9oz9ggyz8xK03m4f1M0TEt/UO6Dsbj7EiNIZ+1e2PSONl98VFdBlvHvsp+iNX/1UXYNJqMeCOM4rXXXamTTGSD8uicshu45syeD/KKyl9sWYdPUDZWIvBafpCt7TouAwKRMk5FVkuZC0gzSF1ZOituR1oL84mtSTYtaA4Cl2RlYS+8Gn81SSRph3vVqQAj1x8fFnS7Pq7HdJp/wlrvO/j2QcQs5yo2NJqtMrcfxpivv9FaRxSQcCfAl5RG9gI2Qxbbpy5IsSASeeuVTg8KdrRgDDxr/3jhmtXKhuNi5JLWLdfc3xHfgEyRq14PK6waBcvWAtC2gYz4fPP18gClPjw2ZUr46LzQbIng3gJmubc6STAtA1o5kSvo64GMRA X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026);SRVR:MWHPR12MB1310;BCL:0;PCL:0;RULEID:;SRVR:MWHPR12MB1310; X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1310;4:qCYZodcvm5uwEYvXVSf/nLf2YZnQJzeJh4EOaQP4UO48v5k8Pc+5iRk5hnFbv6btDW2lmTP+SrnoaY0l71bzrt4UraueLE0R+L0PET9ouvg6Bslo2fCoxGla+ami12p9eTB3r9KMRkFBdt48LI0yEuD4+bV4gNnmYSWUFp/SLa9Wn4dJQ6qhLEHO0Ii7RTuD1TMPQHTqmCz+mZAOjhnA4vXM1QEX5gZy7osNKqBMEAavTzhqeE/p70tUKdbgupkzfIEWeKetOZdL72Orre6OOKpVGoidlMsAwHPs56X1QG2kUSpRa8RLUtKZE3pesELiyWqjewYv2gbSs2RRUZDwYRNEX/6u33FQymksC9F+jRnDIpt99LxpeWdVx2+h0upEmtsH7/WsPmfgNt8oh9dQNOVKdq8wDY4ifJ8aWPa6dbw2i86aX7Nr2wPnspuMO1LJ X-Forefront-PRVS: 00540983E2 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(199003)(189002)(68736007)(5660300001)(42186005)(1706002)(31696002)(2870700001)(77096005)(23756003)(50466002)(305945005)(83506001)(105586002)(54356999)(2201001)(64126003)(189998001)(19580405001)(19580395003)(33646002)(7846002)(50986999)(106356001)(2950100001)(92566002)(8676002)(7416002)(7736002)(97736004)(76176999)(6116002)(586003)(81166006)(65826007)(101416001)(65956001)(36756003)(4001350100001)(5001770100001)(31686004)(47776003)(65806001)(86362001)(4326007)(81156014)(2906002)(921003)(3826002)(1121003)(2101003)(83996005);DIR:OUT;SFP:1101;SCL:1;SRVR:MWHPR12MB1310;H:[IPv6:2a02:908:1251:7981:852b:c1d5:2598:985f];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?iso-8859-15?Q?1;MWHPR12MB1310;23:RJzdoWaLN9EiLv+Pt0rAvfVb9+MswOdCX+jJkA?= =?iso-8859-15?Q?jg6PSiLrIFmJ71qPNXoLgUYhrnzc5UkLuOj62VBcLPBVIRGNjat1+U8IS?= =?iso-8859-15?Q?V03/wnlb0Jzhy5gmX88gQzNETXtGUvtTZOEWmshE7pqvaGLViK4k+C17L?= =?iso-8859-15?Q?51ZBjcF+0rZkll+kcBo2PlY+yv4UYyCcMBHRcQE3jCFbTVqQWj0pQyqAi?= =?iso-8859-15?Q?+ULpA4rYqNoa9PR24iCITXjbg66w5vhy9/AIjdPEoSfACb5DFT1isrR6o?= =?iso-8859-15?Q?tpnhuAjl4LgqYmLX8VuecLviKCMhUt2QDnlxPw3i2f2/OU8p+8ADgTTIc?= =?iso-8859-15?Q?tKqfZcozHedS+nWne2ZPo9XODIxZanAXMUBOpHVpSO/vbeWXGn4hfZTgt?= =?iso-8859-15?Q?PwiV9/+CFGc3veMtj0tfWuQlULmbuZQykEGHmtz8u4Fk2l8uRba23HRil?= =?iso-8859-15?Q?+izbKaXGwBeCkyfDVGYXUvFCmfq3rGNSGvQvT+n5OlPlIN3x11lMMBK0k?= =?iso-8859-15?Q?PEbMTSaOkGnK+Yv9aR+Qx979tOZP812nCr2gA52q/eYV2YtunmAqJ33I4?= =?iso-8859-15?Q?MtT1Nbw1Vwdo8cK1qMZhWiwK2cr+RynZR1OgsJqKGA0unsWVZs/kU26Ec?= =?iso-8859-15?Q?j3iBvyynlv6/+WanMxSPteHhyXRNHOvtrJHT387ktcVKB1isRv+DorKTW?= =?iso-8859-15?Q?0NqqKrr032PvBw097pj1L87qmCT448QWJtyuL177TCZ+1thQ1MUY60Q6K?= =?iso-8859-15?Q?bskYDMFkvFVjUdQjg8usp+rX8dSgNRnOjXYgcUPHRXfPVmgUEzrzJva3i?= =?iso-8859-15?Q?C0qeDjfdsFJjK5//wf3MXg5CnfkevWc0poJbbYbqsNHT+rmLQiHbPXB/e?= =?iso-8859-15?Q?N07p/VHlpC61wzxyipJ1waihY61V7w8gmMUcDiYkm5ee8kdDAw4S5Ef4s?= =?iso-8859-15?Q?cso+Tzn4Al0OP18sc5WTlAZ4hPi8agmXb5LPdBTy/QVdk/xS4IFn5qrKi?= =?iso-8859-15?Q?Owz0UXwe288amPByU2e0I++wJTlpGXHp2RPBTq7vkDJPp+SlAnZN5xA6l?= =?iso-8859-15?Q?fe+izZVEJbzfos+DJm5rdiOgDnNRAz1zSCd5p1mqNbHlw+m284pch4nEE?= =?iso-8859-15?Q?tCL8UdPm3Id8JnOECVjRQhh+dyFClAAOrAsCSiH+1Oy8RVdJ5A+XXySzC?= =?iso-8859-15?Q?C2M0G6gWMCGzsQIdBI+4E/hS80dRj+LeOmgP/drpmTPNltO8NBI6iwOxK?= =?iso-8859-15?Q?KlYcUhc8mMXGarXAbJgSntqzx5EZtE/zh3iZEYrqepQ+3tfNYKfo1R3QL?= =?iso-8859-15?Q?mYaK4EmqQ+b8kb+YOKXiEpimskn6swQu+5c5wVJRLBgC/10DBcvd2FiKH?= =?iso-8859-15?Q?8jysTRb6AEivYCEa5TKXoROu3YiyxamzM8lOZqBZAdgn6c4laJCJMH60M?= =?iso-8859-15?Q?obf//RIBDaRJfjL+Q=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1310;6:3/iD/4JshB+SyxyaInBXpNZC+daobEBj9S800klaGoWjezEIM+v4NUUmtiLC+M/4qqYf7fkbvtgGjrNSnMnMylQgZlNffvxXEt4q5AZvzJAyZlmGDdYcAzq8sQHeK+/4vkDzdn9hkNeKliN9jKE38hI39RaL/Ofqf+s2WWWP6FeE6sD2w6YnvMvXo2t3Ep7jguS4Z6BOJqwcUOKBGKMAFYvgTeAPLrO2pX8XVPsHkBuZGsFH9xocRIsBEtDRmd8LeqiVr/n72Rc8jTi2dxIO5BT9SfBCuHaDGIWtByIv2W9ZHeOylL/6oT+GR9DHWiTyLo7QLyx3rv+YLFevdMxi3w==;5:3wDHhvKrbSOU6HhbKVIrsh9TotdD31Zvk1XdXcCQjgJuGVn3ws/B1wca7wdBsSlB7omJvByshv/WJIOAXLc/BtiufgaIfzzzU8d0o/vwJQzSmUJ6o5xZQdTETBw0I3syBgjoxC2Zo/loE8uC3XuorA==;24:FoYIN2hps0jdPffmVXbBBZ0P8drmjkysxV43CdCyXJoQ2CVl0DPWK3qrxs75Lue0zCYyyDU4d+WO/Wl+hzgfcwQnqlorLkOGPagp3O/WWxA=;7:vRVQd9Sbfuc5YRuNWQWcXsYNtvhiHWVVORwSb9LU6rbC38tpWCg9wZSGKZUYCdyfU//xnJS/uMvqvcW+h0wwgkdDvi1o56Lo3Amh4mm0jGFQ29rPv2u972hbjBBORwqmoZXi7w2owJAkF7JiBmW09X9bsJ0NEJCIar+ZdQ+QxcXLudAadoortIePoNDwXSI6uy0vhiV1F30xu3VgAoGNTXjuOm9enXIfGs4j1WJjOL8ikRBWKVSDSCinF76bqTYr SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1310;20:2eYLmsfxyY+9PnI8kuzB4SY6Tg8XeeL7QlmZLqUs0jQBgulZSmhRc+iy1PHDtXhWfDXGowH+r0DLpN6nbH58nBLkYS1Wje5Rq1KokfCV+GjyLILOjP/c0vArCPLVhxvfxZZy/HnE48GzfxnBUGN9P2b1WFiuuOAxz2dW2s+0d0B33O6iz/Eo1D3zQm3CixVsE2bFsxqNeQnZ7K0cDEl7BsKdQze7f5ZCwY9mCoLf6l0HtPV5S29ReWzj7PYhlgt6 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Sep 2016 08:12:41.5743 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1310 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 03.09.2016 um 07:57 schrieb Baoyou Xie: > We get a few warnings when building kernel with W=1: > drivers/gpu/drm/amd/amdgpu/cz_smc.c:51:5: warning: no previous prototype for 'cz_send_msg_to_smc_async' [-Wmissing-prototypes] > drivers/gpu/drm/amd/amdgpu/cz_smc.c:143:5: warning: no previous prototype for 'cz_write_smc_sram_dword' [-Wmissing-prototypes] > drivers/gpu/drm/amd/amdgpu/iceland_smc.c:124:6: warning: no previous prototype for 'iceland_start_smc' [-Wmissing-prototypes] > drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c:3926:6: warning: no previous prototype for 'gfx_v8_0_rlc_stop' [-Wmissing-prototypes] > drivers/gpu/drm/amd/amdgpu/amdgpu_job.c:94:6: warning: no previous prototype for 'amdgpu_job_free_cb' [-Wmissing-prototypes] > .... > > In fact, these functions are only used in the file in which they are > declared and don't need a declaration, but can be made static. > So this patch marks these functions with 'static'. > > Signed-off-by: Baoyou Xie Reviewed-by: Christian König . > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c | 4 ++-- > drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +- > drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 2 +- > drivers/gpu/drm/amd/amdgpu/cz_smc.c | 4 ++-- > drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 2 +- > drivers/gpu/drm/amd/amdgpu/iceland_smc.c | 8 ++++---- > 6 files changed, 11 insertions(+), 11 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c > index bc0440f..a831218 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c > @@ -616,7 +616,7 @@ static int amdgpu_cgs_irq_put(struct cgs_device *cgs_device, unsigned src_id, un > return amdgpu_irq_put(adev, adev->irq.sources[src_id], type); > } > > -int amdgpu_cgs_set_clockgating_state(struct cgs_device *cgs_device, > +static int amdgpu_cgs_set_clockgating_state(struct cgs_device *cgs_device, > enum amd_ip_block_type block_type, > enum amd_clockgating_state state) > { > @@ -637,7 +637,7 @@ int amdgpu_cgs_set_clockgating_state(struct cgs_device *cgs_device, > return r; > } > > -int amdgpu_cgs_set_powergating_state(struct cgs_device *cgs_device, > +static int amdgpu_cgs_set_powergating_state(struct cgs_device *cgs_device, > enum amd_ip_block_type block_type, > enum amd_powergating_state state) > { > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c > index 0307ff5..f65bdaf 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c > @@ -287,7 +287,7 @@ static u64 amdgpu_cs_get_threshold_for_moves(struct amdgpu_device *adev) > return max(bytes_moved_threshold, 1024*1024ull); > } > > -int amdgpu_cs_list_validate(struct amdgpu_cs_parser *p, > +static int amdgpu_cs_list_validate(struct amdgpu_cs_parser *p, > struct list_head *validated) > { > struct amdgpu_bo_list_entry *lobj; > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c > index 6674d40..31bfe3a 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c > @@ -91,7 +91,7 @@ void amdgpu_job_free_resources(struct amdgpu_job *job) > amdgpu_ib_free(job->adev, &job->ibs[i], f); > } > > -void amdgpu_job_free_cb(struct amd_sched_job *s_job) > +static void amdgpu_job_free_cb(struct amd_sched_job *s_job) > { > struct amdgpu_job *job = container_of(s_job, struct amdgpu_job, base); > > diff --git a/drivers/gpu/drm/amd/amdgpu/cz_smc.c b/drivers/gpu/drm/amd/amdgpu/cz_smc.c > index ac7fee7..c80c2e9 100644 > --- a/drivers/gpu/drm/amd/amdgpu/cz_smc.c > +++ b/drivers/gpu/drm/amd/amdgpu/cz_smc.c > @@ -48,7 +48,7 @@ static struct cz_smu_private_data *cz_smu_get_priv(struct amdgpu_device *adev) > return priv; > } > > -int cz_send_msg_to_smc_async(struct amdgpu_device *adev, u16 msg) > +static int cz_send_msg_to_smc_async(struct amdgpu_device *adev, u16 msg) > { > int i; > u32 content = 0, tmp; > @@ -140,7 +140,7 @@ int cz_read_smc_sram_dword(struct amdgpu_device *adev, u32 smc_address, > return 0; > } > > -int cz_write_smc_sram_dword(struct amdgpu_device *adev, u32 smc_address, > +static int cz_write_smc_sram_dword(struct amdgpu_device *adev, u32 smc_address, > u32 value, u32 limit) > { > int ret; > diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c > index bff8668..6997f7c 100644 > --- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c > @@ -3923,7 +3923,7 @@ static void gfx_v8_0_init_pg(struct amdgpu_device *adev) > } > } > > -void gfx_v8_0_rlc_stop(struct amdgpu_device *adev) > +static void gfx_v8_0_rlc_stop(struct amdgpu_device *adev) > { > u32 tmp = RREG32(mmRLC_CNTL); > > diff --git a/drivers/gpu/drm/amd/amdgpu/iceland_smc.c b/drivers/gpu/drm/amd/amdgpu/iceland_smc.c > index 2118399..ef7c27d 100644 > --- a/drivers/gpu/drm/amd/amdgpu/iceland_smc.c > +++ b/drivers/gpu/drm/amd/amdgpu/iceland_smc.c > @@ -121,7 +121,7 @@ out: > return result; > } > > -void iceland_start_smc(struct amdgpu_device *adev) > +static void iceland_start_smc(struct amdgpu_device *adev) > { > uint32_t val = RREG32_SMC(ixSMC_SYSCON_RESET_CNTL); > > @@ -129,7 +129,7 @@ void iceland_start_smc(struct amdgpu_device *adev) > WREG32_SMC(ixSMC_SYSCON_RESET_CNTL, val); > } > > -void iceland_reset_smc(struct amdgpu_device *adev) > +static void iceland_reset_smc(struct amdgpu_device *adev) > { > uint32_t val = RREG32_SMC(ixSMC_SYSCON_RESET_CNTL); > > @@ -145,7 +145,7 @@ static int iceland_program_jump_on_start(struct amdgpu_device *adev) > return 0; > } > > -void iceland_stop_smc_clock(struct amdgpu_device *adev) > +static void iceland_stop_smc_clock(struct amdgpu_device *adev) > { > uint32_t val = RREG32_SMC(ixSMC_SYSCON_CLOCK_CNTL_0); > > @@ -153,7 +153,7 @@ void iceland_stop_smc_clock(struct amdgpu_device *adev) > WREG32_SMC(ixSMC_SYSCON_CLOCK_CNTL_0, val); > } > > -void iceland_start_smc_clock(struct amdgpu_device *adev) > +static void iceland_start_smc_clock(struct amdgpu_device *adev) > { > uint32_t val = RREG32_SMC(ixSMC_SYSCON_CLOCK_CNTL_0); >