From: Hamza Mahfooz <hamza.mahfooz@amd.com>
To: Daniel Yang <danielyangkang@gmail.com>, skhan@linuxfoundation.org
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] kerneldoc: Fix two missing newlines in drm_connector.c
Date: Mon, 12 Aug 2024 09:08:24 -0400 [thread overview]
Message-ID: <cf46ea4b-425d-4505-a029-e071b1885d8e@amd.com> (raw)
In-Reply-To: <20240809032350.226382-1-danielyangkang@gmail.com>
On 8/8/24 23:23, Daniel Yang wrote:
> Fix the unexpected indentation errors.
>
> drm_connector.c has some kerneldoc comments that were missing newlines.
> This results in the following warnings when running make htmldocs:
> ./Documentation/gpu/drm-kms:538: ./drivers/gpu/drm/drm_connector.c:2344: WARNING: Definition list ends without a blank line; unexpected unindent. [docutils]
> ./Documentation/gpu/drm-kms:538: ./drivers/gpu/drm/drm_connector.c:2346: ERROR: Unexpected indentation. [docutils]
> ./Documentation/gpu/drm-kms:538: ./drivers/gpu/drm/drm_connector.c:2368: WARNING: Block quote ends without a blank line; unexpected unindent. [docutils]
> ./Documentation/gpu/drm-kms:538: ./drivers/gpu/drm/drm_connector.c:2381: ERROR: Unexpected indentation. [docutils]
>
> Signed-off-by: Daniel Yang <danielyangkang@gmail.com>
Applied, thanks!
> ---
>
> Notes:
> v2: added "Fix the unexpected indentation errors" line to description.
>
> drivers/gpu/drm/drm_connector.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c
> index 80e239a6493..fc35f47e284 100644
> --- a/drivers/gpu/drm/drm_connector.c
> +++ b/drivers/gpu/drm/drm_connector.c
> @@ -2342,7 +2342,9 @@ EXPORT_SYMBOL(drm_mode_create_aspect_ratio_property);
> *
> * Default:
> * The behavior is driver-specific.
> + *
> * BT2020_RGB:
> + *
> * BT2020_YCC:
> * User space configures the pixel operation properties to produce
> * RGB content with Rec. ITU-R BT.2020 colorimetry, Rec.
> @@ -2366,6 +2368,7 @@ EXPORT_SYMBOL(drm_mode_create_aspect_ratio_property);
> * range.
> * The variants BT2020_RGB and BT2020_YCC are equivalent and the
> * driver chooses between RGB and YCbCr on its own.
> + *
> * SMPTE_170M_YCC:
> * BT709_YCC:
> * XVYCC_601:
> @@ -2378,6 +2381,7 @@ EXPORT_SYMBOL(drm_mode_create_aspect_ratio_property);
> * DCI-P3_RGB_Theater:
> * RGB_WIDE_FIXED:
> * RGB_WIDE_FLOAT:
> + *
> * BT601_YCC:
> * The behavior is undefined.
> *
--
Hamza
prev parent reply other threads:[~2024-08-12 13:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-08 8:40 [PATCH] kerneldoc: Fix two missing newlines in drm_connector.c Daniel Yang
2024-08-08 14:45 ` Shuah Khan
2024-08-09 3:23 ` [PATCH v2] " Daniel Yang
2024-08-09 15:52 ` Shuah Khan
2024-08-12 13:08 ` Hamza Mahfooz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf46ea4b-425d-4505-a029-e071b1885d8e@amd.com \
--to=hamza.mahfooz@amd.com \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=danielyangkang@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox