From: Heiner Kallweit <hkallweit1@gmail.com>
To: Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "kuba@kernel.org" <kuba@kernel.org>,
Joakim Zhang <qiangqing.zhang@nxp.com>,
"peppe.cavallaro@st.com" <peppe.cavallaro@st.com>,
"alexandre.torgue@foss.st.com" <alexandre.torgue@foss.st.com>,
"joabreu@synopsys.com" <joabreu@synopsys.com>,
Yannick Vignon <yannick.vignon@nxp.com>,
"boon.leong.ong@intel.com" <boon.leong.ong@intel.com>,
"Jose.Abreu@synopsys.com" <Jose.Abreu@synopsys.com>,
"mst@redhat.com" <mst@redhat.com>,
"Joao.Pinto@synopsys.com" <Joao.Pinto@synopsys.com>,
Mingkai Hu <mingkai.hu@nxp.com>, Leo Li <leoyang.li@nxp.com>
Subject: Re: [EXT] Re: [PATCH net-next 2/2] net: stmmac: make stmmac-tx-timeout configurable in Kconfig
Date: Thu, 2 Dec 2021 11:45:10 +0100 [thread overview]
Message-ID: <cf4accd9-d613-5da4-cf2e-ccd9f06f3786@gmail.com> (raw)
In-Reply-To: <DB8PR04MB5785293BA211B0FD49EA40AFF0699@DB8PR04MB5785.eurprd04.prod.outlook.com>
On 02.12.2021 11:28, Xiaoliang Yang wrote:
> Hi Heiner,
>
> On Dec 02, 2021 at 16:13:20, Heiner Kallweit wrote:
>>> stmmac_tx_timeout() function is called when a queue transmission
>>> timeout. When Strict Priority is used as scheduling algorithms, the
>>> lower priority queue may be blocked by a higher prority queue, which
>>> will lead to tx timeout. We don't want to enable the tx watchdog
>>> timeout in this case. Therefore, this patch make stmmac-tx-timeout
>> configurable.
>>>
>> Your patch just disables the timeout handler, the WARN_ONCE() would still fire.
>> And shouldn't this be a runtime setting rather than a compile-time setting?
>>
> I tried to disable it in stmmac_tx_timeout() at runtime, the WARN_ONCE() will still be called from dev_watchdog() in sch_generic.c. It seems only when the timeout handler is NULL can disable the netdev watchdog up. So I did this in compile-time setting.
>
The issue you're trying to fix is not driver-specific. Therefore the solution
should be added to net core.
> Regards,
> Xiaoliang
>
prev parent reply other threads:[~2021-12-02 10:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-01 1:47 [PATCH net-next 0/2] multiple queues support on imx8mp-evk Xiaoliang Yang
2021-12-01 1:47 ` [PATCH net-next 1/2] arm64: dts: imx8mp-evk: configure multiple queues on eqos Xiaoliang Yang
2021-12-01 1:43 ` Joakim Zhang
2021-12-01 2:45 ` Jakub Kicinski
2021-12-01 1:47 ` [PATCH net-next 2/2] net: stmmac: make stmmac-tx-timeout configurable in Kconfig Xiaoliang Yang
2021-12-02 10:13 ` Heiner Kallweit
2021-12-02 10:28 ` [EXT] " Xiaoliang Yang
2021-12-02 10:45 ` Heiner Kallweit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf4accd9-d613-5da4-cf2e-ccd9f06f3786@gmail.com \
--to=hkallweit1@gmail.com \
--cc=Joao.Pinto@synopsys.com \
--cc=Jose.Abreu@synopsys.com \
--cc=alexandre.torgue@foss.st.com \
--cc=boon.leong.ong@intel.com \
--cc=davem@davemloft.net \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingkai.hu@nxp.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=qiangqing.zhang@nxp.com \
--cc=xiaoliang.yang_1@nxp.com \
--cc=yannick.vignon@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox