From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 515F18405C for ; Wed, 17 Dec 2025 05:02:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=198.175.65.10 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765947754; cv=fail; b=L70Fkws3TmGw5qIfLKngWA7cby4/ynZiwpRGjYWLjbGHkDvFpPrAMZ5UYkLXTl5sWNGDBTF0y8XKP3pOq6nfNk0gnBRqCiSyJQjoVb9ePM1MM3MT9IKafupLTjKb5tLgv43uPrVHTVTGIvntrz8uXS3MWUhkTPHLfbe3mhtTXbM= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765947754; c=relaxed/simple; bh=5zIPAIXDJ+a8c7uRk8b/Q20pU1y2qzpuT8dZFoQe4RM=; h=Message-ID:Date:Subject:To:CC:References:From:In-Reply-To: Content-Type:MIME-Version; b=civCWT0BCpHi3G306LgR1QGXROhDjbnS08TyumBdSgRcRYXQrekJOyemW+os+v3fZkWGzo5N0gOamjVsr6bTHZZiNsEvmZxUQ6s0I/PTbu/knZiKr1pYLN+3WnWX1OJc2NbE2lvhR6tDEI5j6d+wGX2u5DGUgci76RrBEft2quI= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Esjl768W; arc=fail smtp.client-ip=198.175.65.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Esjl768W" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1765947753; x=1797483753; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=5zIPAIXDJ+a8c7uRk8b/Q20pU1y2qzpuT8dZFoQe4RM=; b=Esjl768W4a9O1SHBdCHbYFsZQBSyatajiaqsWOMFB8kQ7ynB4n7RtJqk uIFFwHQJBkdtSWK3NIL0M7J8/KwBdP7OfDsd7GLvF4u1EfpUB4q+9jpRT Z/NX49zNRx/BcWyKpx+EiXg5zuNdwueqHnRSRa2EEljWikbRi974pRowz Y+sBPB/y4JY/utlZW9v8dWngOlNZoobqnWmNk7n4wxo053Xx7QB18KtG8 O+6udY2xK8KCZbQ6lGH18D2lBf3LhwUP7qJNL77WAuOS1FuBjP1s+sZaC rXtYLb1Tywg8jYesr1LbQA0iSRFwAoZSOFpxaEZxnH71obg1Lx+zBXNP/ w==; X-CSE-ConnectionGUID: /oCjHenSTT+gF8Wo5tfrbw== X-CSE-MsgGUID: osq1bqIlSmaXe+Q+IhoyIQ== X-IronPort-AV: E=McAfee;i="6800,10657,11644"; a="85292852" X-IronPort-AV: E=Sophos;i="6.21,154,1763452800"; d="scan'208";a="85292852" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Dec 2025 21:02:32 -0800 X-CSE-ConnectionGUID: INlzucPiQOq6uiGRpAYuZA== X-CSE-MsgGUID: ow0jx3QvSaK2vaoRYDHxOw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,154,1763452800"; d="scan'208";a="197952909" Received: from fmsmsx903.amr.corp.intel.com ([10.18.126.92]) by orviesa009.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Dec 2025 21:02:33 -0800 Received: from FMSMSX901.amr.corp.intel.com (10.18.126.90) by fmsmsx903.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Tue, 16 Dec 2025 21:02:31 -0800 Received: from fmsedg901.ED.cps.intel.com (10.1.192.143) by FMSMSX901.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29 via Frontend Transport; Tue, 16 Dec 2025 21:02:31 -0800 Received: from CH5PR02CU005.outbound.protection.outlook.com (40.107.200.58) by edgegateway.intel.com (192.55.55.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Tue, 16 Dec 2025 21:02:31 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=QGIsC2bnbJYxfKu1BODJWnc2yso4UyZpJLOoTr2VkoY4wjSVnBPe9JU6/OgXouxMlIzLx7MK5X6HCIxMvgXep/a8MAJWmOi/G3qXKo8VSlI59kTOuyPH+U3eRQ3k0KOzjZkwFFFXa8GE3FYRwMEX6sjGmQfvVAtgiJu/9sPdlcN0vkxqicUQIbX5aNO0E6UlOU8wKfPghIX8WvvB0NmEIGDSshKslhA5NrdA4IpqtahbKD63gOybs3ajFatjns+ijAX7Z5zUQazoivxTzUD0Pi6Jz3L3aaaxQUoQaOTXxRQ3Ls8htdTDV44Rw+4APdpf+B2tyq1eVbQmpmFqllkKyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iS1PTz3YibNI0qBiSXwqzvMdaXJRn3sc7h/J2TAdAXM=; b=aMkG+wmH+jUxrxxAbv1tq5VmeM8mbBjNrJ8CQCXTj8CThh3rs1FkjHmmTlHN9ALIER3VP4WhK7VG1be/t8KoSdPkJo85oe+JZIqUgJL7d/qknFKbHrJRTrGqbwdwh0GAiieX9WkAcaYalyz0JgJf3HOlaXSW75xXMncek4tBlJbVhrIBA7XKUKwRJgX1c34slOxl9zBr0STZp8vj/MQw1xOkTb9cKALMABBEeaBAX+Enbv8vjhcun1eeaxOSk9S00Q81pbPGZNxgysTUl19BhT+mGe8hGwsrfola8zmd5dOEvPfBUgs0d4tubjfM8611rIPoP+JTibJDZN+au4CGbA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from SJ2PR11MB7573.namprd11.prod.outlook.com (2603:10b6:a03:4d2::10) by MW4PR11MB6912.namprd11.prod.outlook.com (2603:10b6:303:22a::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9412.10; Wed, 17 Dec 2025 05:02:29 +0000 Received: from SJ2PR11MB7573.namprd11.prod.outlook.com ([fe80::61a:aa57:1d81:a9cf]) by SJ2PR11MB7573.namprd11.prod.outlook.com ([fe80::61a:aa57:1d81:a9cf%3]) with mapi id 15.20.9434.001; Wed, 17 Dec 2025 05:02:29 +0000 Message-ID: Date: Tue, 16 Dec 2025 21:02:27 -0800 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/3] fs/resctrl: Return -EINVAL for a missing seq_show implementation To: Aaron Tomlin , , , , , , , , CC: , References: <20251215230257.1798865-1-atomlin@atomlin.com> <20251215230257.1798865-3-atomlin@atomlin.com> From: Reinette Chatre Content-Language: en-US In-Reply-To: <20251215230257.1798865-3-atomlin@atomlin.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MW4PR03CA0138.namprd03.prod.outlook.com (2603:10b6:303:8c::23) To SJ2PR11MB7573.namprd11.prod.outlook.com (2603:10b6:a03:4d2::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR11MB7573:EE_|MW4PR11MB6912:EE_ X-MS-Office365-Filtering-Correlation-Id: 948cde4e-0e92-46c2-c83f-08de3d297a6a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?Z1NRUFNqMHI1bXNuYXNPVFpib01hNUp6bitwUFh1TER0TWJFdVVWemxKNEt0?= =?utf-8?B?UkIvcjM3WVZjNUk5MGF5TlhRZyt4Yk1lT200cjlFVXFkSmVXd3kxNXVxYUdk?= =?utf-8?B?OUtHdDBNRU1rWVM3ZUhvZ0l5dVltYXlxQzE0N3pwVlNyWGZneE5LQlVncWFM?= =?utf-8?B?VGJIYjl4SUlCVW9pNjNjdVVyaHlYTldFTHM1SE9HU3dHWXRWMmJrUi9sdmdC?= =?utf-8?B?U21uVFZTMzY1Tmk5T3FXODY3S0xuWWtORCtWWVBaS0d5WXhKVXpoRlRqTGtG?= =?utf-8?B?RU9PcS9GMi9kOW1MNzBXT3MraG9IaE1ZL3l6V1dGMWRBWlZGYmZwbysrSnBa?= =?utf-8?B?TTJ5QVI3WURUVmxlOVNPUitNalRMd2NrRTZ5aTBKc0ovOERwQXU0R0EycXBx?= =?utf-8?B?U091SFpwN1g0dGI0Zm1iQmlGZ0YwaEpTWVpqd0VDUlBMWHRJZGxkekJQUStB?= =?utf-8?B?MmxFN3BFVnBLMkVFc1hjcXdqc0c1MU03RVZSSEJTdW13dVdObXZQQjVQSnBa?= =?utf-8?B?TzJSNStPMXlWM2d0WmFDQ3pqU3JHQllhM1BXYlQ4dytQck9uekd0QS9ZQXBU?= =?utf-8?B?c3BpWSs5M2dTZmUzU2hOZGo5SktTVGxxSTF3NGpWS2FibmFIR1NyekUzL2hB?= =?utf-8?B?Q2psbVR3SjhkZHVUS1A5N3hoOFVsTTJmWTVpMzNPZXhNVGdlUk10OGw1UTI3?= =?utf-8?B?SFlUQk5DMW1JZVNlVkpDNFcvaHRkWE04UUt0a1htWjNMeHZSSjNQTUZON0E0?= =?utf-8?B?eE5GMW5oMzNvb3dUWk4yK3dXdjY2VWdTYjhmdEhBRTJRZi8xQ2hDbThCWFNS?= =?utf-8?B?L1pYcEpJbkNpdmdoQUt5dStrUkV2QzA0KzVpWTNpUEV5TklLOTRtZ2RRT3Uy?= =?utf-8?B?cWJxVzA3K3lza2pxQ0ZuUFVTa25QSVd3U2UwMHlaUXQyNUZhWFQ1VkMzL1hF?= =?utf-8?B?c2pDdHpxZjBsRjhGMW1pTG1QZUFmRHBLdjM3b0lWYXdrUWhCN2JnQmRGNDBq?= =?utf-8?B?MzFqZFMwakFjbXZhRERqazlGeDRNZWIzanU4eGM2dWR3MWN1c0dTS2F3dXR0?= =?utf-8?B?TGdCdEl6ZDBFRExqaFVXT0czK2krN2dLeUgzWEpDQ2hkd2lLcVM2SVhhd0Qw?= =?utf-8?B?WW5XN1hJYUVtYjhiMlBXekRZUlExOWRWZ0tGenhlZUdzbDh0T00ybHF2RVpK?= =?utf-8?B?NHY2Z2doRjBiYVVpK2NOblJ5b3hSNyt2VXF3MzhaNHdoWjI2UzNSVGFmUXVp?= =?utf-8?B?REdhRG5kZjA2TVF0NExJUC90cE1sQmZXTlVocjFSL21uWW1pdE9obzFBclNG?= =?utf-8?B?cFZCQ2h4a1VZQ2V0NXZMMC84LzdqL2o1NWNBa2Z2Z1Vpd0FIcEwyYkxxcEpL?= =?utf-8?B?Y245c0p0VWpnK0lNTmNjSlU5T280QVNKOFJuV3NoRDN6RTVMMGxRSzl6d2ZC?= =?utf-8?B?dlRmajMyQ2phTVFpYmVCUWNlQkZQQmhWclU0MGdsMlRNTFJjTmE4bEFwL3Qx?= =?utf-8?B?cFkzNTlmbGxVR2hNdjRCK0p0eTVZREhlcUo1eHBIZCtybGlZSkZ6cnFHV3Nu?= =?utf-8?B?UHhFQS9FR2RXbG1MeDYyeEQ5UTRiN0tBMUNraDEwb0lhTmZrdU1mL25pVTRK?= =?utf-8?B?b0Q0ay9sbjJVQmlXd3Q0R0krMmV1OHFxZHJGaCtEWkFmMzJ1enM1emtOUUFI?= =?utf-8?B?YlBYbHZPdnB1dDUzZitJUk9EdGlabWNKWTVTRnhrOEFUcEFCbEFUS0l4aS9E?= =?utf-8?B?WFVrRHRDdEtITzcxM250ZXVYVUZ2ZjUrTU1TNzE3dXYrek5Ja2U3SlUxKzlP?= =?utf-8?B?am94MnhwRTN3cDZrSUVqVkpSREVPR0NnMzV2dzRCKzJseE03cnNvc1IwbGJF?= =?utf-8?B?QjZ6cWM3U2MzL2ZHbENVNzdvOTVzQVJ0cjdja0laZStGL2p2bjJkU1liUEZa?= =?utf-8?Q?LJwhyCsFYTUZ5Yr+iY2aXGsUYDxg8xEO?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ2PR11MB7573.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(1800799024)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?blF1SVpra3YxMU9ZQnF2dzllNEJhcXlEbXdXZUxyb2NPR2ZyaSswM0F6UDND?= =?utf-8?B?VnQrVFhWVVBUOXNsV0wzVEhTQ0xTb1RoM0ovWC9jMHNkV0pJYUFjZ1VEVW5k?= =?utf-8?B?UWd3Yy9EQ3JiVWg2U1J4U1RQYUI1VmdyWElzUXk0WUdoNjIrYkxHRklEYWRn?= =?utf-8?B?QzdMeG1ERGMxU21GK3JKTFFmWUZEN3VFQ216TkRVMTdWdzRUbzBleGRtVEF3?= =?utf-8?B?a2lZeXhLQ0VjckYxYktkMHBQSkF0QnoxK2d0am1hNlJ1SFRqZS92dStiK3Zn?= =?utf-8?B?cVpoczlnbnd2MDlFNHBlM2FnaDc0LzkweWVjeG9pbHU1dmZDdGxBeko5OENT?= =?utf-8?B?Y2dNaVJNN2ZGZG8zWllFVjFudjNTWWN6WGZqbGhPRDUzaTN5TUxZQjNWdXRF?= =?utf-8?B?S0NnWlBDcFR1TDI0SFpjUmxSU2RsVXoreFliTkgvSzhUY1U5NWpDNkRiQyt2?= =?utf-8?B?RStFdzI4UkEyQk91djB1V1NnYTEzOUl1N1ZmQXFBWFRsZC9HandjSHV0Wi9u?= =?utf-8?B?dVZGVSt2NlplZGJQa2JiMGJXbVpzdUtvLzlPOUtxUEs4Q2Vpak9PTUVBdTBY?= =?utf-8?B?U3JiMnFCTWk5d2JLR1Vrc1lCQjZkU0RYVW5BdVZQcVkrMHNtcUFwLy9WbnEr?= =?utf-8?B?T1RFYkpMMHZwall4bFJaTStpM0o4Y3FlbzhLdDUwNFFzdE9IQ2ZZcFlHQ3dv?= =?utf-8?B?b2tUL2VIbWduS0w3cHVDMytocVA3bVl0amEyZ1k1SHBxL0djTnNGaU83c2s5?= =?utf-8?B?NENOSXUwNXd0Ym1hZ3dqclVzdk9zaWNjc3g3ZFNCdVd1YlpXQ0t6VytINlZm?= =?utf-8?B?R0ZBVGM4NmxrOWlpV3VNZUVyVkxaTW02N2pzaHRMN1IzT0krZXgybE96aVls?= =?utf-8?B?ck9VdHBCOGZqTDFWK3U5YzhVNUg3VmYwclpmMDRWZzVjcjlaU05xbXJwS1FJ?= =?utf-8?B?QzJ5elBKTHI2TlpWOGpkSUpCT2p2ZHpUMDJGMVp6V0FGVjFMYWMzS3BlbWZm?= =?utf-8?B?aFZ4VjVVUTB5c3lPa2wwczNwS0VEWGVqK0Q0WnFRTWp4NjFJTjZvNWZObmhZ?= =?utf-8?B?TnE4TjNERVkxWW5qWWQ0ZlJhSlZKSm5RNzcwbFg1anVUVmoybGFhbTNSYmNS?= =?utf-8?B?Y1ZKR2JvUXM3OFVBMThFWlZ1WjE3ZG5CZXRoNjFObzRrcHZXUnRybFc1TGsv?= =?utf-8?B?UE02aUh3QXE0ZytBaXBkVEUzOVpSeTNwOVRUVlFGc3RMS0tTSjhJY01BWFhT?= =?utf-8?B?czB4cEZna3k0bWE5RUhwd1YrbTd4Y3N6RnpQdzk3K0RtSEU4K0JRZ0Rxbmhw?= =?utf-8?B?Y2xMb0ZFK0QyVVZocldCZ2tFdnJCeDZMcW1lc1R0SW8vTGt6VHN2bnJ5UWRi?= =?utf-8?B?eUN5bFZrM3ZNa2xhVHR2THpJSVNSU1RINUhiOVdKQ2diZ1ozOXlwWkFwMVJS?= =?utf-8?B?dXNqTkppSzBBVjdYM3ZDOUhPUm1sZFVlWHlmUFovdmViM3JUaVBXcm9xZG9G?= =?utf-8?B?ZTV0ZFpFdzVQYWNLV1pFZnRCdlhEeVRBUExOdGgvRU9INXhMdStIU2pRTFFv?= =?utf-8?B?ajlLTnRUL0ZxV0YrbWNsV0xia3ljTTVZbTdHenVZOWVLS21IeVlEcHRYZlhE?= =?utf-8?B?ZEtQUE8vUzN2TWs2UENza29zMHlNd3JYbG1SK1hJN25SZEpBWkErd0Z4ZFFU?= =?utf-8?B?T3ViRFVPVmFOYk9XMzhBOGlHdGc4TGNBTFhvWElhNDhaM2xpcmhVWWdSQ2JS?= =?utf-8?B?QkQ2MUQzeUlqVkJmNmVXbU10ZFl5R2pUNm5vUFozZ1ZnVGU2bXZwc0NSSkEw?= =?utf-8?B?MGJUU0ZRUzJaaEVkcGlGNW9TcmFidlVWZlJYQy9DYmtmRURnWWpvZ1VxU3Bt?= =?utf-8?B?cmZyem83cU5RM0x3NnlVK2pTbkFhQWVuSUJzWTJOR25ndHZJb3NxRUlRK1N0?= =?utf-8?B?c2Q5bnUyMkx6SnNwZU1WMXhtVGVwTmEzT3VLb3pROG12a1hZb2prdjk1bHVw?= =?utf-8?B?VDFna0ZobDlpeGN3d3hLa2svbXE5SlRMOGUrVE4xbytUWHpVNlNrNVkzQXJC?= =?utf-8?B?NFJGR0xUeWNhcjcwWDdQUTJtL0duZFVxenlNWTd2cmRkYllVNlo4cDl1MjZw?= =?utf-8?B?YUZacWgrOG5ZZDNxMElRVHZWeDFNYitUOThwWmNMUHFaTC9yT3oyUVBLSVVI?= =?utf-8?B?TFE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 948cde4e-0e92-46c2-c83f-08de3d297a6a X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Dec 2025 05:02:29.2144 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RdJJlibfFD1aqcqVzHW58XqdItRO+Ht7B+mzpSsykpigeMjG9NSsmwc/ICmubtlzhKMZEtt7z3yb4vRQz1ljBHuA0gejiAG0HO2djxLHJQ0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB6912 X-OriginatorOrg: intel.com Hi Aaron, How is this change required to support the feature of enabling user to set CBM across domains? On 12/15/25 3:02 PM, Aaron Tomlin wrote: > The rdtgroup_seqfile_show() function, which is the sequence file handler > for reading data from resctrl files, previously returned 0 (success) if > the file's associated rftype did not define a .seq_show implementation. > > This behavior is incorrect and confusing, as a read operation that > does not define a display function should be treated as an error. Why should it be treated as an error? Not having rftype::seq_show() set when user is intended to be able to see data when reading from the file is a kernel bug. Otherwise it seems fine to return nothing when there is nothing to show and doing so be successful. Reinette